Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14923

Remove dead code from HealthMonitor

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Resolved
    • Minor
    • Resolution: Fixed
    • 3.3.0, 3.2.1, 3.1.3
    • 3.3.0, 3.1.4, 3.2.2
    • None
    • None

    Description

      Dig ZKFC source code and find that the dead code as follow

      public void removeCallback(Callback cb) {
         callbacks.remove(cb);
      }
      
      public synchronized void removeServiceStateCallback(ServiceStateCallback cb) {
         serviceStateCallbacks.remove(cb);
      }
      
      synchronized HAServiceStatus getLastServiceStatus() {
         return lastServiceState;
      }
      

      It's useless, and should be deleted.

      Attachments

        1. HDFS-14923.001.patch
          1 kB
          Hui Fei

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            ferhui Hui Fei
            ferhui Hui Fei
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment