Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14923

Remove dead code from HealthMonitor

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.3.0, 3.2.1, 3.1.3
    • Fix Version/s: 3.3.0, 3.1.4, 3.2.2
    • Component/s: None
    • Labels:
      None

      Description

      Dig ZKFC source code and find that the dead code as follow

      public void removeCallback(Callback cb) {
         callbacks.remove(cb);
      }
      
      public synchronized void removeServiceStateCallback(ServiceStateCallback cb) {
         serviceStateCallbacks.remove(cb);
      }
      
      synchronized HAServiceStatus getLastServiceStatus() {
         return lastServiceState;
      }
      

      It's useless, and should be deleted.

        Attachments

        1. HDFS-14923.001.patch
          1 kB
          Fei Hui

          Activity

            People

            • Assignee:
              ferhui Fei Hui
              Reporter:
              ferhui Fei Hui
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: