Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14850

Optimize FileSystemAccessService#getFileSystemConfiguration

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.3.0, 3.1.4, 3.2.2
    • Component/s: httpfs, performance
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

       @Override
        public Configuration getFileSystemConfiguration() {
          Configuration conf = new Configuration(true);
          ConfigurationUtils.copy(serviceHadoopConf, conf);
          conf.setBoolean(FILE_SYSTEM_SERVICE_CREATED, true);
      
          // Force-clear server-side umask to make HttpFS match WebHDFS behavior
          conf.set(FsPermission.UMASK_LABEL, "000");
      
          return conf;
        }
      

      As above code´╝îwhen call FileSystemAccessService#getFileSystemConfiguration,current code new Configuration every time.
      It is not necessary and affects performance. I think it only need to new Configuration in FileSystemAccessService#init once and FileSystemAccessService#getFileSystemConfiguration get it.

        Attachments

        1. HDFS-14850.005.patch
          3 kB
          Lisheng Sun
        2. HDFS-14850.004(2).patch
          3 kB
          Lisheng Sun
        3. HDFS-14850.004.patch
          3 kB
          Lisheng Sun
        4. HDFS-14850.003.patch
          2 kB
          Lisheng Sun
        5. HDFS-14850.002.patch
          2 kB
          Lisheng Sun
        6. HDFS-14850.001.patch
          2 kB
          Lisheng Sun

          Activity

            People

            • Assignee:
              leosun08 Lisheng Sun
              Reporter:
              leosun08 Lisheng Sun
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: