[HDFS-14798] Synchronize invalidateBlocks in DatanodeDescriptor

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: namenode
• Labels: n00b newbie
• Assignee: Hemanth Boyina
• Reporter: David Mollitor
• Created: 29/Aug/19 16:25
• Updated: 24/Sep/19 21:11
• Resolved: 12/Sep/19 14:20

Description

DatanodeDescriptor.java

public void resetBlocks() {
  ...
  this.invalidateBlocks.clear();
  ...
}

public void clearBlockQueues() {
  synchronized (invalidateBlocks) {
    this.invalidateBlocks.clear();
  }
  ...
}

It may not be strictly necessary, but why risk it? The invalidateBlocks should be protected in resetBlocks() just like it is in clearBlockQueues()/