Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-9000 Allow reconfiguration without restart for parameters where applicable.
  3. HDFS-1477

Support reconfiguring dfs.heartbeat.interval and dfs.namenode.heartbeat.recheck-interval without NN restart

    Details

    • Type: Sub-task
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.7.0
    • Fix Version/s: 2.9.0, 3.0.0-alpha1
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed
    • Release Note:
      Hide
      Steps to reconfigure:
      1. change value of the parameter in corresponding xml configuration file
      2. to reconfigure, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> start
      3. to check status of the most recent reconfigure operation, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> status
      4. to query a list reconfigurable properties on NN, run
          hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> properties
      Show
      Steps to reconfigure: 1. change value of the parameter in corresponding xml configuration file 2. to reconfigure, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> start 3. to check status of the most recent reconfigure operation, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> status 4. to query a list reconfigurable properties on NN, run     hdfs dfsadmin -reconfig namenode <nn_addr>:<ipc_port> properties

      Description

      Modify NameNode to implement the interface Reconfigurable proposed in HADOOP-7001. This would allow us to change certain configuration properties without restarting the name node.

      1. HDFS-1477-HDFS-9000.009.patch
        33 kB
        Xiaobing Zhou
      2. HDFS-1477-HDFS-9000.008.patch
        31 kB
        Xiaobing Zhou
      3. HDFS-1477-HDFS-9000.007.patch
        31 kB
        Xiaobing Zhou
      4. HDFS-1477-HDFS-9000.006.patch
        22 kB
        Xiaobing Zhou
      5. HDFS-1477.patch
        11 kB
        Patrick Kling
      6. HDFS-1477.4.patch
        23 kB
        Xiaobing Zhou
      7. HDFS-1477.3.patch
        15 kB
        Patrick Kling
      8. HDFS-1477.2.patch
        15 kB
        Patrick Kling
      9. HDFS-1477.005.patch
        23 kB
        Xiaobing Zhou

        Issue Links

          Activity

          Hide
          pkling Patrick Kling added a comment -

          This patch makes NameNode Reconfigurable. It allows the configuration properties dfs.heartbeat.interval and dfs.namenode.heartbeat.recheck-interval to be changed without restarting the name node via a servlet registered at /nnconf.

          Show
          pkling Patrick Kling added a comment - This patch makes NameNode Reconfigurable. It allows the configuration properties dfs.heartbeat.interval and dfs.namenode.heartbeat.recheck-interval to be changed without restarting the name node via a servlet registered at /nnconf.
          Hide
          pkling Patrick Kling added a comment -

          Updated patch, added unit test.

          ant test-patch output:

               [exec] +1 overall.
               [exec]
               [exec]     +1 @author.  The patch does not contain any @author tags.
               [exec]
               [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
               [exec]
               [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
               [exec]
               [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
               [exec]
               [exec]     +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.
               [exec]
               [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
               [exec]
               [exec]     +1 system test framework.  The patch passed system test framework compile.
          

          ant test failures (all these tests also fail on a clean trunk for me):

              [junit] Test org.apache.hadoop.hdfs.TestHDFSServerPorts FAILED
              [junit] Test org.apache.hadoop.hdfs.TestHDFSTrash FAILED (timeout)
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestBackupNode FAILED
              [junit] Test org.apache.hadoop.hdfs.server.namenode.TestStorageRestore FAILED
              [junit] Test org.apache.hadoop.hdfs.TestFileConcurrentReader FAILED (timeout)
          
          Show
          pkling Patrick Kling added a comment - Updated patch, added unit test. ant test-patch output: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system test framework. The patch passed system test framework compile. ant test failures (all these tests also fail on a clean trunk for me): [junit] Test org.apache.hadoop.hdfs.TestHDFSServerPorts FAILED [junit] Test org.apache.hadoop.hdfs.TestHDFSTrash FAILED (timeout) [junit] Test org.apache.hadoop.hdfs.server.namenode.TestBackupNode FAILED [junit] Test org.apache.hadoop.hdfs.server.namenode.TestStorageRestore FAILED [junit] Test org.apache.hadoop.hdfs.TestFileConcurrentReader FAILED (timeout)
          Hide
          jghoman Jakob Homan added a comment -

          The addInternalServlet call is used for machine-to-machine servlets that users won't use and are not authenticated (or are authenticated over kerberos). This servlet should use the standard add call so that in a secure system the user will be authenticated. Haven't reviewed the rest of the patch; just wanted to throw that out.

          Show
          jghoman Jakob Homan added a comment - The addInternalServlet call is used for machine-to-machine servlets that users won't use and are not authenticated (or are authenticated over kerberos). This servlet should use the standard add call so that in a secure system the user will be authenticated. Haven't reviewed the rest of the patch; just wanted to throw that out.
          Hide
          pkling Patrick Kling added a comment -

          Use addServlet() instead of addInternalServlet()

          Show
          pkling Patrick Kling added a comment - Use addServlet() instead of addInternalServlet()
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12466342/HDFS-1477.3.patch
          against trunk revision 1051669.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.server.balancer.TestBalancer
          org.apache.hadoop.hdfs.server.namenode.TestStorageRestore
          org.apache.hadoop.hdfs.TestHDFSTrash

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466342/HDFS-1477.3.patch against trunk revision 1051669. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.server.balancer.TestBalancer org.apache.hadoop.hdfs.server.namenode.TestStorageRestore org.apache.hadoop.hdfs.TestHDFSTrash -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/18//console This message is automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -

          -1 overall. Here are the results of testing the latest attachment
          http://issues.apache.org/jira/secure/attachment/12466342/HDFS-1477.3.patch
          against trunk revision 1072023.

          +1 @author. The patch does not contain any @author tags.

          +1 tests included. The patch appears to include 3 new or modified tests.

          +1 javadoc. The javadoc tool did not generate any warning messages.

          +1 javac. The applied patch does not increase the total number of javac compiler warnings.

          +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

          +1 release audit. The applied patch does not increase the total number of release audit warnings.

          -1 core tests. The patch failed these core unit tests:
          org.apache.hadoop.hdfs.TestFileConcurrentReader

          -1 contrib tests. The patch failed contrib unit tests.

          +1 system test framework. The patch passed system test framework compile.

          Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//testReport/
          Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
          Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//console

          This message is automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12466342/HDFS-1477.3.patch against trunk revision 1072023. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.hdfs.TestFileConcurrentReader -1 contrib tests. The patch failed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//testReport/ Findbugs warnings: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://hudson.apache.org/hudson/job/PreCommit-HDFS-Build/184//console This message is automatically generated.
          Hide
          umamaheswararao Uma Maheswara Rao G added a comment -

          Patrick, do you mind to re-base the patch based on trunk?
          Just canceled the patch, as it no more applies to the trunk.

          Show
          umamaheswararao Uma Maheswara Rao G added a comment - Patrick, do you mind to re-base the patch based on trunk? Just canceled the patch, as it no more applies to the trunk.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I took this over since there's no progress in last years.

          Show
          xiaobingo Xiaobing Zhou added a comment - I took this over since there's no progress in last years.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Changed this as a sub task of HDFS-9000.

          Show
          xiaobingo Xiaobing Zhou added a comment - Changed this as a sub task of HDFS-9000 .
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I made patch V4 with minor changes based on previous work. Could anyone review it? Thanks.

          Show
          xiaobingo Xiaobing Zhou added a comment - I made patch V4 with minor changes based on previous work. Could anyone review it? Thanks.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 22m 14s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 9m 35s There were no new javac warning messages.
          +1 javadoc 10m 58s There were no new javadoc warning messages.
          +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 28s The applied patch generated 37 new checkstyle issues (total was 689, now 705).
          -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 27s mvn install still works.
          +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse.
          -1 findbugs 2m 31s The patch appears to introduce 3 new Findbugs (version 3.0.0) warnings.
          +1 native 3m 12s Pre-build of native portion
          -1 hdfs tests 161m 32s Tests failed in hadoop-hdfs.
              214m 5s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12756388/HDFS-1477.4.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 0832b38
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/whitespace.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12498/testReport/
          Java 1.7.0_55
          uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12498/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 22m 14s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 9m 35s There were no new javac warning messages. +1 javadoc 10m 58s There were no new javadoc warning messages. +1 release audit 0m 24s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 28s The applied patch generated 37 new checkstyle issues (total was 689, now 705). -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 27s mvn install still works. +1 eclipse:eclipse 0m 35s The patch built with eclipse:eclipse. -1 findbugs 2m 31s The patch appears to introduce 3 new Findbugs (version 3.0.0) warnings. +1 native 3m 12s Pre-build of native portion -1 hdfs tests 161m 32s Tests failed in hadoop-hdfs.     214m 5s   Reason Tests FindBugs module:hadoop-hdfs Failed unit tests hadoop.hdfs.server.blockmanagement.TestBlockManager Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12756388/HDFS-1477.4.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 0832b38 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12498/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12498/testReport/ Java 1.7.0_55 uname Linux asf903.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12498/console This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -



          -1 overall



          Vote Subsystem Runtime Comment
          0 pre-patch 18m 29s Pre-patch trunk compilation is healthy.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 tests included 0m 0s The patch appears to include 1 new or modified test files.
          +1 javac 8m 1s There were no new javac warning messages.
          +1 javadoc 10m 23s There were no new javadoc warning messages.
          +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings.
          -1 checkstyle 1m 24s The applied patch generated 37 new checkstyle issues (total was 687, now 703).
          -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix.
          +1 install 1m 33s mvn install still works.
          +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse.
          -1 findbugs 2m 38s The patch appears to introduce 3 new Findbugs (version 3.0.0) warnings.
          +1 native 3m 14s Pre-build of native portion
          -1 hdfs tests 109m 17s Tests failed in hadoop-hdfs.
              156m 5s  



          Reason Tests
          FindBugs module:hadoop-hdfs
          Timed out tests org.apache.hadoop.hdfs.server.namenode.TestBackupNode
            org.apache.hadoop.hdfs.TestFileConcurrentReader
            org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner
            org.apache.hadoop.hdfs.TestBalancerBandwidth



          Subsystem Report/Notes
          Patch URL http://issues.apache.org/jira/secure/attachment/12764332/HDFS-1477.005.patch
          Optional Tests javadoc javac unit findbugs checkstyle
          git revision trunk / 6f335e4
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/whitespace.txt
          Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
          hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/testrun_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12747/testReport/
          Java 1.7.0_55
          uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12747/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 pre-patch 18m 29s Pre-patch trunk compilation is healthy. +1 @author 0m 0s The patch does not contain any @author tags. +1 tests included 0m 0s The patch appears to include 1 new or modified test files. +1 javac 8m 1s There were no new javac warning messages. +1 javadoc 10m 23s There were no new javadoc warning messages. +1 release audit 0m 26s The applied patch does not increase the total number of release audit warnings. -1 checkstyle 1m 24s The applied patch generated 37 new checkstyle issues (total was 687, now 703). -1 whitespace 0m 1s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix. +1 install 1m 33s mvn install still works. +1 eclipse:eclipse 0m 34s The patch built with eclipse:eclipse. -1 findbugs 2m 38s The patch appears to introduce 3 new Findbugs (version 3.0.0) warnings. +1 native 3m 14s Pre-build of native portion -1 hdfs tests 109m 17s Tests failed in hadoop-hdfs.     156m 5s   Reason Tests FindBugs module:hadoop-hdfs Timed out tests org.apache.hadoop.hdfs.server.namenode.TestBackupNode   org.apache.hadoop.hdfs.TestFileConcurrentReader   org.apache.hadoop.hdfs.server.datanode.TestDirectoryScanner   org.apache.hadoop.hdfs.TestBalancerBandwidth Subsystem Report/Notes Patch URL http://issues.apache.org/jira/secure/attachment/12764332/HDFS-1477.005.patch Optional Tests javadoc javac unit findbugs checkstyle git revision trunk / 6f335e4 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/diffcheckstylehadoop-hdfs.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/whitespace.txt Findbugs warnings https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html hadoop-hdfs test log https://builds.apache.org/job/PreCommit-HDFS-Build/12747/artifact/patchprocess/testrun_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/12747/testReport/ Java 1.7.0_55 uname Linux asf904.gq1.ygridcore.net 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Console output https://builds.apache.org/job/PreCommit-HDFS-Build/12747/console This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          Hi Xiaobing Zhou, thanks for taking this up. My comments on the v5 patch:

          1. FsNameSystem and DatanodeManager need not implement Reconfigurable, since their Reconfigurable methods are only invoked via NameNode.
          2. What does getNewConf() do? Looks like it just constructs a new config object by re-reading the config files? There should have been a Javadoc on the base class method, perhaps we can add one now.
          3. Can we just skip implementing reconfiguration via the servlet? A better approach is to have the daemon re-read its config files like HDFS-6808 (which you pointed out to me offline . Looks like you will need a new RPC call and support on the client. Also it would be good to log the reconfiguration request in the hdfs audit log.
          4. Nitpicks: Fix indentation in DatanodeManager#reconfigurePropertyImpl.
          5. #reconfigurePropertyImpl - get namesystem.writeLock() outside the try block.

          Other suggestions for separate subtasks.

          1. The list of reconfigurable properties should not be hard-coded. We can add an annotation to the reconfigurable properties.
          2. Add ReconfigurableBase support for atomic updates, i.e. all or no changes take effect.
          3. Documentation.
          Show
          arpitagarwal Arpit Agarwal added a comment - - edited Hi Xiaobing Zhou , thanks for taking this up. My comments on the v5 patch: FsNameSystem and DatanodeManager need not implement Reconfigurable, since their Reconfigurable methods are only invoked via NameNode. What does getNewConf() do? Looks like it just constructs a new config object by re-reading the config files? There should have been a Javadoc on the base class method, perhaps we can add one now. Can we just skip implementing reconfiguration via the servlet? A better approach is to have the daemon re-read its config files like HDFS-6808 (which you pointed out to me offline . Looks like you will need a new RPC call and support on the client. Also it would be good to log the reconfiguration request in the hdfs audit log. Nitpicks: Fix indentation in DatanodeManager#reconfigurePropertyImpl. #reconfigurePropertyImpl - get namesystem.writeLock() outside the try block. Other suggestions for separate subtasks. The list of reconfigurable properties should not be hard-coded. We can add an annotation to the reconfigurable properties. Add ReconfigurableBase support for atomic updates, i.e. all or no changes take effect. Documentation.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          Thanks Arpit Agarwal for review! The next patch will address your comments.

          Show
          xiaobingo Xiaobing Zhou added a comment - Thanks Arpit Agarwal for review! The next patch will address your comments.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          -1 patch 0m 5s HDFS-1477 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12764332/HDFS-1477.005.patch
          JIRA Issue HDFS-1477
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14252/console

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment -1 patch 0m 5s HDFS-1477 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12764332/HDFS-1477.005.patch JIRA Issue HDFS-1477 Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14252/console This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          I posted patch 006 rebased on HDFS-9094 and HDFS-9801. Kindly review please, thanks!

          Show
          xiaobingo Xiaobing Zhou added a comment - I posted patch 006 rebased on HDFS-9094 and HDFS-9801 . Kindly review please, thanks!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 9s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
          +1 mvninstall 7m 3s trunk passed
          +1 compile 0m 41s trunk passed with JDK v1.8.0_72
          +1 compile 0m 43s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 27s trunk passed
          +1 mvnsite 0m 54s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 1m 58s trunk passed
          +1 javadoc 1m 10s trunk passed with JDK v1.8.0_72
          +1 javadoc 1m 56s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 49s the patch passed
          +1 compile 0m 42s the patch passed with JDK v1.8.0_72
          +1 javac 0m 42s the patch passed
          +1 compile 0m 43s the patch passed with JDK v1.7.0_95
          +1 javac 0m 43s the patch passed
          -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 387 unchanged - 24 fixed = 396 total (was 411)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 11s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          -1 findbugs 2m 21s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0)
          +1 javadoc 1m 7s the patch passed with JDK v1.8.0_72
          +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95
          -1 unit 57m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 54m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 21s Patch does not generate ASF License warnings.
          139m 15s



          Reason Tests
          FindBugs module:hadoop-hdfs-project/hadoop-hdfs
            Result of integer multiplication cast to long in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.setHeartbeatInterval(long, int) At DatanodeManager.java:to long in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.setHeartbeatInterval(long, int) At DatanodeManager.java:[line 1649]
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics
            hadoop.hdfs.TestFileAppend
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788321/HDFS-1477-HDFS-9000.006.patch
          JIRA Issue HDFS-1477
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 9e57c07026d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0fb14aa
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14517/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14517/console
          Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files. +1 mvninstall 7m 3s trunk passed +1 compile 0m 41s trunk passed with JDK v1.8.0_72 +1 compile 0m 43s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 27s trunk passed +1 mvnsite 0m 54s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 1m 10s trunk passed with JDK v1.8.0_72 +1 javadoc 1m 56s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 49s the patch passed +1 compile 0m 42s the patch passed with JDK v1.8.0_72 +1 javac 0m 42s the patch passed +1 compile 0m 43s the patch passed with JDK v1.7.0_95 +1 javac 0m 43s the patch passed -1 checkstyle 0m 25s hadoop-hdfs-project/hadoop-hdfs: patch generated 9 new + 387 unchanged - 24 fixed = 396 total (was 411) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 11s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. -1 findbugs 2m 21s hadoop-hdfs-project/hadoop-hdfs generated 1 new + 0 unchanged - 0 fixed = 1 total (was 0) +1 javadoc 1m 7s the patch passed with JDK v1.8.0_72 +1 javadoc 1m 50s the patch passed with JDK v1.7.0_95 -1 unit 57m 52s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 54m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 21s Patch does not generate ASF License warnings. 139m 15s Reason Tests FindBugs module:hadoop-hdfs-project/hadoop-hdfs   Result of integer multiplication cast to long in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.setHeartbeatInterval(long, int) At DatanodeManager.java:to long in org.apache.hadoop.hdfs.server.blockmanagement.DatanodeManager.setHeartbeatInterval(long, int) At DatanodeManager.java: [line 1649] JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeMetrics   hadoop.hdfs.TestFileAppend JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12788321/HDFS-1477-HDFS-9000.006.patch JIRA Issue HDFS-1477 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 9e57c07026d0 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0fb14aa Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/new-findbugs-hadoop-hdfs-project_hadoop-hdfs.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14517/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14517/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14517/console Powered by Apache Yetus 0.2.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment - - edited

          Hi Xiaobing Zhou, a few comments below:

          1. Let's consider adding the ReconfigurationServlet change in a separate jira.
          2. Jenkins flagged a couple of findbugs warnings.
          3. Can you please fix the coding style to be consistent in NameNode.java? e.g.
                      namesystem.getBlockManager().getDatanodeManager()
                          .setHeartbeatInterval(DFS_HEARTBEAT_INTERVAL_DEFAULT);
            
                      namesystem
                          .getBlockManager()
                          .getDatanodeManager()
                          .setHeartbeatRecheckInterval(
                              DFS_NAMENODE_HEARTBEAT_RECHECK_INTERVAL_DEFAULT);
            
          4. The new test case should also assert that after calling NameNode.reconfigureProperty(), NameNode.getConf().getProperty() returns the new value in case of success.
          5. TestDFSAdmin#testNameNodeStartReconfiguration etc. need fixing.
          Show
          arpitagarwal Arpit Agarwal added a comment - - edited Hi Xiaobing Zhou , a few comments below: Let's consider adding the ReconfigurationServlet change in a separate jira. Jenkins flagged a couple of findbugs warnings. Can you please fix the coding style to be consistent in NameNode.java? e.g. namesystem.getBlockManager().getDatanodeManager() .setHeartbeatInterval(DFS_HEARTBEAT_INTERVAL_DEFAULT); namesystem .getBlockManager() .getDatanodeManager() .setHeartbeatRecheckInterval( DFS_NAMENODE_HEARTBEAT_RECHECK_INTERVAL_DEFAULT); The new test case should also assert that after calling NameNode.reconfigureProperty() , NameNode.getConf().getProperty() returns the new value in case of success. TestDFSAdmin#testNameNodeStartReconfiguration etc. need fixing.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          007 should fix all issues you mentioned, thanks Arpit Agarwal.

          Show
          xiaobingo Xiaobing Zhou added a comment - 007 should fix all issues you mentioned, thanks Arpit Agarwal .
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 25s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 9m 41s trunk passed
          +1 compile 1m 16s trunk passed with JDK v1.8.0_72
          +1 compile 1m 0s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 18s trunk passed
          +1 mvneclipse 0m 19s trunk passed
          +1 findbugs 2m 25s trunk passed
          +1 javadoc 1m 38s trunk passed with JDK v1.8.0_72
          +1 javadoc 2m 17s trunk passed with JDK v1.7.0_95
          +1 mvninstall 1m 5s the patch passed
          +1 compile 1m 9s the patch passed with JDK v1.8.0_72
          +1 javac 1m 9s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_95
          +1 javac 0m 58s the patch passed
          -1 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: patch generated 40 new + 687 unchanged - 23 fixed = 727 total (was 710)
          +1 mvnsite 1m 9s the patch passed
          +1 mvneclipse 0m 16s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 40s the patch passed
          +1 javadoc 1m 41s the patch passed with JDK v1.8.0_72
          +1 javadoc 2m 35s the patch passed with JDK v1.7.0_95
          -1 unit 97m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 83m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 25s Patch does not generate ASF License warnings.
          217m 59s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.security.TestDelegationTokenForProxyUser
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage
            hadoop.hdfs.server.datanode.TestBlockReplacement
            hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl
            hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.namenode.TestEditLog
            hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs
            hadoop.hdfs.server.datanode.TestDirectoryScanner



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791063/HDFS-1477-HDFS-9000.007.patch
          JIRA Issue HDFS-1477
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 1b0c5bb4b405 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 67880cc
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14699/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14699/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 25s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 9m 41s trunk passed +1 compile 1m 16s trunk passed with JDK v1.8.0_72 +1 compile 1m 0s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 18s trunk passed +1 mvneclipse 0m 19s trunk passed +1 findbugs 2m 25s trunk passed +1 javadoc 1m 38s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 17s trunk passed with JDK v1.7.0_95 +1 mvninstall 1m 5s the patch passed +1 compile 1m 9s the patch passed with JDK v1.8.0_72 +1 javac 1m 9s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_95 +1 javac 0m 58s the patch passed -1 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: patch generated 40 new + 687 unchanged - 23 fixed = 727 total (was 710) +1 mvnsite 1m 9s the patch passed +1 mvneclipse 0m 16s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 40s the patch passed +1 javadoc 1m 41s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 35s the patch passed with JDK v1.7.0_95 -1 unit 97m 47s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 83m 25s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 25s Patch does not generate ASF License warnings. 217m 59s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.security.TestDelegationTokenForProxyUser   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.datanode.TestNNHandlesBlockReportPerStorage   hadoop.hdfs.server.datanode.TestBlockReplacement   hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.7.0_95 Failed junit tests hadoop.hdfs.server.datanode.fsdataset.impl.TestFsDatasetImpl   hadoop.hdfs.server.blockmanagement.TestBlockTokenWithDFSStriped   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.namenode.TestEditLog   hadoop.metrics2.sink.TestRollingFileSystemSinkWithSecureHdfs   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791063/HDFS-1477-HDFS-9000.007.patch JIRA Issue HDFS-1477 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 1b0c5bb4b405 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 67880cc Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14699/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14699/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14699/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          008 fixed check style issues, and test failures are not related to the patch 007.

          Show
          xiaobingo Xiaobing Zhou added a comment - 008 fixed check style issues, and test failures are not related to the patch 007.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 40s trunk passed
          +1 compile 0m 48s trunk passed with JDK v1.8.0_72
          +1 compile 0m 46s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 28s trunk passed
          +1 mvnsite 0m 59s trunk passed
          +1 mvneclipse 0m 14s trunk passed
          +1 findbugs 2m 13s trunk passed
          +1 javadoc 1m 14s trunk passed with JDK v1.8.0_72
          +1 javadoc 2m 7s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 53s the patch passed
          +1 compile 0m 49s the patch passed with JDK v1.8.0_72
          +1 javac 0m 49s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.7.0_95
          +1 javac 0m 44s the patch passed
          -1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 686 unchanged - 23 fixed = 689 total (was 709)
          +1 mvnsite 0m 55s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 28s the patch passed
          +1 javadoc 1m 12s the patch passed with JDK v1.8.0_72
          +1 javadoc 2m 6s the patch passed with JDK v1.7.0_95
          -1 unit 73m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_72.
          -1 unit 61m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 20s Patch does not generate ASF License warnings.
          164m 12s



          Reason Tests
          JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.TestFileAppend
            hadoop.hdfs.server.namenode.ha.TestHAAppend
            hadoop.hdfs.TestSafeModeWithStripedFile
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791227/HDFS-1477-HDFS-9000.008.patch
          JIRA Issue HDFS-1477
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 8bb1a356e9f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0a9f00a
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14708/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14708/console
          Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 40s trunk passed +1 compile 0m 48s trunk passed with JDK v1.8.0_72 +1 compile 0m 46s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 28s trunk passed +1 mvnsite 0m 59s trunk passed +1 mvneclipse 0m 14s trunk passed +1 findbugs 2m 13s trunk passed +1 javadoc 1m 14s trunk passed with JDK v1.8.0_72 +1 javadoc 2m 7s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 53s the patch passed +1 compile 0m 49s the patch passed with JDK v1.8.0_72 +1 javac 0m 49s the patch passed +1 compile 0m 44s the patch passed with JDK v1.7.0_95 +1 javac 0m 44s the patch passed -1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 3 new + 686 unchanged - 23 fixed = 689 total (was 709) +1 mvnsite 0m 55s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 28s the patch passed +1 javadoc 1m 12s the patch passed with JDK v1.8.0_72 +1 javadoc 2m 6s the patch passed with JDK v1.7.0_95 -1 unit 73m 6s hadoop-hdfs in the patch failed with JDK v1.8.0_72. -1 unit 61m 53s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 20s Patch does not generate ASF License warnings. 164m 12s Reason Tests JDK v1.8.0_72 Failed junit tests hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.TestFileAppend   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestSafeModeWithStripedFile JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestFileAppend Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12791227/HDFS-1477-HDFS-9000.008.patch JIRA Issue HDFS-1477 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8bb1a356e9f3 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0a9f00a Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_72 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_72.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14708/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14708/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14708/console Powered by Apache Yetus 0.3.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          Hi Xiaobing Zhou, the patch looks almost ready. A few stylistic comments:

          1. Multiple calls to namesystem.getBlockManager.getDatanodeManager() in NameNode#reconfigurePropertyImpl. Let's just make it a local variable to improve readability. e.g.
              protected String reconfigurePropertyImpl(String property, String newVal)
                  throws ReconfigurationException {
                final DatanodeManager datanodeManager =
                    namesystem.getBlockManager().getDatanodeManager();
            
          2. Similar change in testReconfigure for readability.
              public void testReconfigure() throws ReconfigurationException {
                // change properties
                final NameNode nameNode = cluster.getNameNode();
                final DatanodeManager datanodeManager = nameNode.namesystem
                    .getBlockManager().getDatanodeManager();
            
          3. It is better to replace the sleep calls in TestDFSAdmin#testNameNodeGetReconfigurationStatus with GenericTestUtils#waitFor.

          Thanks for your patience with the patch revisions.

          Show
          arpitagarwal Arpit Agarwal added a comment - Hi Xiaobing Zhou , the patch looks almost ready. A few stylistic comments: Multiple calls to namesystem.getBlockManager.getDatanodeManager() in NameNode#reconfigurePropertyImpl. Let's just make it a local variable to improve readability. e.g. protected String reconfigurePropertyImpl( String property, String newVal) throws ReconfigurationException { final DatanodeManager datanodeManager = namesystem.getBlockManager().getDatanodeManager(); Similar change in testReconfigure for readability. public void testReconfigure() throws ReconfigurationException { // change properties final NameNode nameNode = cluster.getNameNode(); final DatanodeManager datanodeManager = nameNode.namesystem .getBlockManager().getDatanodeManager(); It is better to replace the sleep calls in TestDFSAdmin#testNameNodeGetReconfigurationStatus with GenericTestUtils#waitFor . Thanks for your patience with the patch revisions.
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          V009 addressed your comments, thanks Arpit Agarwal for review!

          Show
          xiaobingo Xiaobing Zhou added a comment - V009 addressed your comments, thanks Arpit Agarwal for review!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
          +1 mvninstall 7m 2s trunk passed
          +1 compile 0m 39s trunk passed with JDK v1.8.0_74
          +1 compile 0m 41s trunk passed with JDK v1.7.0_95
          +1 checkstyle 0m 29s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 mvneclipse 0m 13s trunk passed
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 1m 4s trunk passed with JDK v1.8.0_74
          +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95
          +1 mvninstall 0m 45s the patch passed
          +1 compile 0m 36s the patch passed with JDK v1.8.0_74
          +1 javac 0m 36s the patch passed
          +1 compile 0m 38s the patch passed with JDK v1.7.0_95
          +1 javac 0m 38s the patch passed
          +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 688 unchanged - 23 fixed = 688 total (was 711)
          +1 mvnsite 0m 49s the patch passed
          +1 mvneclipse 0m 12s the patch passed
          +1 whitespace 0m 0s Patch has no whitespace issues.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 1m 1s the patch passed with JDK v1.8.0_74
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95
          -1 unit 54m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_74.
          -1 unit 53m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95.
          +1 asflicense 0m 23s Patch does not generate ASF License warnings.
          133m 53s



          Reason Tests
          JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend
            hadoop.hdfs.TestHFlush
          JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:0ca8df7
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792144/HDFS-1477-HDFS-9000.009.patch
          JIRA Issue HDFS-1477
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 00d3bb5633d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 55f73a1
          Default Java 1.7.0_95
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt
          JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14747/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14747/console
          Powered by Apache Yetus 0.2.0 http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files. +1 mvninstall 7m 2s trunk passed +1 compile 0m 39s trunk passed with JDK v1.8.0_74 +1 compile 0m 41s trunk passed with JDK v1.7.0_95 +1 checkstyle 0m 29s trunk passed +1 mvnsite 0m 50s trunk passed +1 mvneclipse 0m 13s trunk passed +1 findbugs 1m 55s trunk passed +1 javadoc 1m 4s trunk passed with JDK v1.8.0_74 +1 javadoc 1m 46s trunk passed with JDK v1.7.0_95 +1 mvninstall 0m 45s the patch passed +1 compile 0m 36s the patch passed with JDK v1.8.0_74 +1 javac 0m 36s the patch passed +1 compile 0m 38s the patch passed with JDK v1.7.0_95 +1 javac 0m 38s the patch passed +1 checkstyle 0m 27s hadoop-hdfs-project/hadoop-hdfs: patch generated 0 new + 688 unchanged - 23 fixed = 688 total (was 711) +1 mvnsite 0m 49s the patch passed +1 mvneclipse 0m 12s the patch passed +1 whitespace 0m 0s Patch has no whitespace issues. +1 findbugs 2m 8s the patch passed +1 javadoc 1m 1s the patch passed with JDK v1.8.0_74 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_95 -1 unit 54m 34s hadoop-hdfs in the patch failed with JDK v1.8.0_74. -1 unit 53m 42s hadoop-hdfs in the patch failed with JDK v1.7.0_95. +1 asflicense 0m 23s Patch does not generate ASF License warnings. 133m 53s Reason Tests JDK v1.8.0_74 Failed junit tests hadoop.hdfs.TestFileAppend   hadoop.hdfs.TestHFlush JDK v1.7.0_95 Failed junit tests hadoop.hdfs.TestHFlush Subsystem Report/Notes Docker Image:yetus/hadoop:0ca8df7 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12792144/HDFS-1477-HDFS-9000.009.patch JIRA Issue HDFS-1477 Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 00d3bb5633d6 3.13.0-36-lowlatency #63-Ubuntu SMP PREEMPT Wed Sep 3 21:56:12 UTC 2014 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 55f73a1 Default Java 1.7.0_95 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_74 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt unit test logs https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.8.0_74.txt https://builds.apache.org/job/PreCommit-HDFS-Build/14747/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_95.txt JDK v1.7.0_95 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/14747/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/14747/console Powered by Apache Yetus 0.2.0 http://yetus.apache.org This message was automatically generated.
          Hide
          arpitagarwal Arpit Agarwal added a comment -

          +1 I've committed this for 2.9. Thanks for the contribution Xiaobing Zhou.

          Show
          arpitagarwal Arpit Agarwal added a comment - +1 I've committed this for 2.9. Thanks for the contribution Xiaobing Zhou .
          Hide
          hudson Hudson added a comment -

          FAILURE: Integrated in Hadoop-trunk-Commit #9452 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9452/)
          HDFS-1477. Support reconfiguring dfs.heartbeat.interval and (arp: rev e01c6ea688e62f25c4310e771a0cd85b53a5fb87)

          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java
          • hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java
          • hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
          Show
          hudson Hudson added a comment - FAILURE: Integrated in Hadoop-trunk-Commit #9452 (See https://builds.apache.org/job/Hadoop-trunk-Commit/9452/ ) HDFS-1477 . Support reconfiguring dfs.heartbeat.interval and (arp: rev e01c6ea688e62f25c4310e771a0cd85b53a5fb87) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNodeRpcServer.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NamenodeFsck.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestComputeInvalidateWork.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/tools/TestDFSAdmin.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/DataNode.java hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/BlockManager.java hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNameNodeReconfigure.java
          Hide
          xiaobingo Xiaobing Zhou added a comment -

          The release note has been added.

          Show
          xiaobingo Xiaobing Zhou added a comment - The release note has been added.

            People

            • Assignee:
              xiaobingo Xiaobing Zhou
              Reporter:
              pkling Patrick Kling
            • Votes:
              0 Vote for this issue
              Watchers:
              20 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development