[HDFS-14632] Reduce useless #getNumLiveDataNodes call in SafeModeMonitor - ASF JIRA

XML

Word

Printable

JSON

Details

Type: Improvement
Status: Resolved
Priority: Major
Resolution: Fixed
Affects Version/s: 2.9.0
Fix Version/s: 2.10.0, 3.3.0, 3.2.1, 3.1.3
Component/s: namenode
Labels:
None

Hadoop Flags:

Reviewed

Description

As mentioned ~~HDFS-14171~~, SafeModeMonitor invoke useless #getNumLiveDataNodes if not config DataNode threshold.
The root cause is BlockManagerSafeMode#reportStatus(for trunk branch) or SafeModeInfo#reportStatus (for branch-2.8) print status every 20 seconds and invoke SafeModeInfo#getTurnOffTip.
Optimize with checking if config DataNode threshold then decide to if get number of live DataNodes.

Attachments

- Sort By Name
- Sort By Date
- Ascending
- Descending

HDFS-14632.001.patch
04/Jul/19 16:09
3 kB
Xiaoqiao He
HDFS-14632.002.patch
05/Jul/19 03:33
7 kB
Xiaoqiao He
HDFS-14632.003.patch
05/Jul/19 06:50
7 kB
Xiaoqiao He
HDFS-14632.004.patch
08/Jul/19 13:17
8 kB
Xiaoqiao He
HDFS-14632.005.patch
09/Jul/19 03:52
10 kB
Xiaoqiao He
HDFS-14632.006.patch
09/Jul/19 13:34
8 kB
Xiaoqiao He

Issue Links

is related to

HDFS-14171 Performance improvement in Tailing EditLog

Resolved

relates to

HDFS-15594 Lazy calculate live datanodes in safe mode tip

Resolved

Activity

People

Assignee:: Xiaoqiao He

Reporter:: Xiaoqiao He

Votes:: 0 Vote for this issue

Watchers:: 4 Start watching this issue

Dates

Created:: 04/Jul/19 14:05

Updated:: 23/Sep/20 19:56

Resolved:: 10/Jul/19 03:04