[HDFS-14599] HDFS-12487 breaks test TestDiskBalancer.testDiskBalancerWithFedClusterWithOneNameServiceEmpty

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.3.0, 3.2.1, 3.1.3
• Fix Version/s: 3.3.0, 3.2.2
• Component/s: diskbalancer
• Labels: newbie
• Hadoop Flags: Reviewed
• Assignee: Xiaoqiao He
• Reporter: Wei-Chiu Chuang
• Created: 24/Jun/19 00:36
• Updated: 10/Jun/21 07:44
• Resolved: 27/Jun/19 17:00

Description

It looks like HDFS-12487 changes the error message expected by TestDiskBalancer#testDiskBalancerWithFedClusterWithOneNameServiceEmpty.

The test expects error "There are no blocks in the blockPool" but after HDFS-12487, it returns error string "NextBlock call returned null.No valid block to copy."

Probably the simplest approach to fix it is to update the expected error string.

Thoughts? bharatviswa you crafted the test in HDFS-13715. Should we update the expected error string, or revert HDFS-12487?

Issue Links

• is broken by: HDFS-12487 FsDatasetSpi.isValidBlock() lacks null pointer check inside and neither do the callers