[HDFS-14542] Remove redundant code when verify quota

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Duplicate
• Affects Version/s: 3.1.1
• Assignee: Jinglun
• Reporter: Jinglun
• Created: 04/Jun/19 12:22
• Updated: 02/Oct/19 17:14
• Resolved: 31/Jul/19 02:58

Description

DirectoryWithQuotaFeature.verifyQuotaByStorageType() does the job of verifying quota. It's redundant to call isQuotaByStorageTypeSet() because the for each iterator nextline has done the same job.

private void verifyQuotaByStorageType(EnumCounters<StorageType> typeDelta) 
     throws QuotaByStorageTypeExceededException {
  if (!isQuotaByStorageTypeSet()) { // REDUNDANT.
    return;
  }
  for (StorageType t: StorageType.getTypesSupportingQuota()) {
    if (!isQuotaByStorageTypeSet(t)) { // CHECK FOR EACH STORAGETYPE.
      continue;
    }
    if (Quota.isViolated(quota.getTypeSpace(t), usage.getTypeSpace(t),
        typeDelta.get(t))) {
      throw new QuotaByStorageTypeExceededException(
      quota.getTypeSpace(t), usage.getTypeSpace(t) + typeDelta.get(t), t);
    }
  }
}

Issue Links

• is a child of: HDFS-14566 Quota improvement in HDFS