Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14494

Move Server logging of StatedId inside receiveRequestState()

VotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 2.10.0, 3.3.0, 3.1.4, 3.2.2
    • None

    Description

      HDFS-14270 introduced logging of the client and server StateIds in trace level. Unfortunately one of the arguments alignmentContext.getLastSeenStateId() holds a lock on FSEdits, which is called even if trace logging level is disabled. I propose to move logging message inside GlobalStateIdContext.receiveRequestState() where clientStateId and serverStateId already calculated and can be easily printed.

      Attachments

        1. HDFS-14494.001.patch
          3 kB
          Shweta

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            shwetayakkali Shweta
            shv Konstantin Shvachko
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Slack

                Issue deployment