[HDFS-14472] FSImageHandler.getPath() throws a FileNotFoundException when the path is malformed

• Type: Sub-task
• Status: Resolved
• Priority: Minor
• Resolution: Not A Problem
• Assignee: Unassigned
• Reporter: Haicheng Chen
• Created: 06/May/19 14:18
• Updated: 29/May/19 18:05
• Resolved: 29/May/19 18:05

Description

Dear HDFS developers, we are developing a tool to detect exception-related bugs in Java. Our prototype has spotted the following throw statement whose exception class and error message indicate different error conditions.

 

Version: Hadoop-3.1.2

File: HADOOP-ROOT/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/FSImageHandler.java

Line: 179-180

throw new FileNotFoundException("Path: " + path + " should " +
        "start with " + WEBHDFS_PREFIX);

 

A FileNotFoundException means that a target file cannot be found. However, the error message indicates that the path is malformed (instead of well-formed but pointing to no file). This mismatch could be a problem. For example, the callers trying to handle other FileNotFoundException may accidentally (and incorrectly) handle the malformed path.