[HDFS-14456] HAState#prepareToEnterState needn't a lock

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: hdfs
• Assignee: hunshenshi
• Reporter: hunshenshi
• Created: 24/Apr/19 09:38
• Updated: 17/Aug/19 00:42
• Resolved: 16/Aug/19 21:53

Description

prepareToEnterState in HAState is called without the context being locked.

But in NameNode#NameNode, prepareToEnterState is after haContext.writeLock()

 

try {
  haContext.writeLock();
  state.prepareToEnterState(haContext);
  state.enterState(haContext);
} finally {
  haContext.writeUnlock();
}

 

Is it OK?

 

Issue Links

• links to: GitHub Pull Request #770