Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-14414

Clean up findbugs warning in branch-2

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.10.0
    • 2.10.0, 2.8.6, 2.9.3
    • None
    • None

    Description

      There's an unused local variable and findbugs doesn't like it.

      Bug type DLS_DEAD_LOCAL_STORE (click for details) 
      In class org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode$Saver
      In method org.apache.hadoop.hdfs.server.namenode.FSImageFormatPBINode$Saver.save(OutputStream, INodeSymlink)
      Local variable named state
      At FSImageFormatPBINode.java:[line 623]

      File this jira to clean it up.

      Attachments

        1. HDFS-14414-branch-2.00.patch
          0.9 kB
          Dinesh Chitlangia

        Activity

          dineshchitlangia Dinesh Chitlangia added a comment - - edited

          weichiu Thanks for filing this. Attached patch 00 for review.

          dineshchitlangia Dinesh Chitlangia added a comment - - edited weichiu Thanks for filing this. Attached patch 00 for review.

          +1 pending Jenkins. Thanks!

          weichiu Wei-Chiu Chuang added a comment - +1 pending Jenkins. Thanks!
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 11m 1s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          +1 mvninstall 13m 8s branch-2 passed
          +1 compile 0m 51s branch-2 passed with JDK v1.7.0_95
          +1 compile 0m 49s branch-2 passed with JDK v1.8.0_191
          +1 checkstyle 0m 31s branch-2 passed
          +1 mvnsite 1m 0s branch-2 passed
          -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings.
          +1 javadoc 1m 8s branch-2 passed with JDK v1.7.0_95
          +1 javadoc 0m 43s branch-2 passed with JDK v1.8.0_191
                Patch Compile Tests
          +1 mvninstall 0m 50s the patch passed
          +1 compile 0m 48s the patch passed with JDK v1.7.0_95
          +1 javac 0m 48s the patch passed
          +1 compile 0m 44s the patch passed with JDK v1.8.0_191
          +1 javac 0m 44s the patch passed
          +1 checkstyle 0m 24s the patch passed
          +1 mvnsite 0m 52s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1)
          +1 javadoc 0m 58s the patch passed with JDK v1.7.0_95
          +1 javadoc 0m 38s the patch passed with JDK v1.8.0_191
                Other Tests
          -1 unit 54m 57s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 23s The patch does not generate ASF License warnings.
          95m 44s



          Reason Tests
          Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys
            hadoop.hdfs.server.namenode.TestNameNodeHttpServerXFrame
            hadoop.hdfs.web.TestWebHdfsTimeouts



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:da67579
          JIRA Issue HDFS-14414
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12965039/HDFS-14414-branch-2.00.patch
          Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 8e595c11fa74 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / dce76e0
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_191
          Multi-JDK versions /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_191
          findbugs v3.0.0
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/26588/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/26588/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/26588/testReport/
          Max. process+thread count 3265 (vs. ulimit of 10000)
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/26588/console
          Powered by Apache Yetus 0.8.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 11m 1s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests +1 mvninstall 13m 8s branch-2 passed +1 compile 0m 51s branch-2 passed with JDK v1.7.0_95 +1 compile 0m 49s branch-2 passed with JDK v1.8.0_191 +1 checkstyle 0m 31s branch-2 passed +1 mvnsite 1m 0s branch-2 passed -1 findbugs 1m 57s hadoop-hdfs-project/hadoop-hdfs in branch-2 has 1 extant Findbugs warnings. +1 javadoc 1m 8s branch-2 passed with JDK v1.7.0_95 +1 javadoc 0m 43s branch-2 passed with JDK v1.8.0_191       Patch Compile Tests +1 mvninstall 0m 50s the patch passed +1 compile 0m 48s the patch passed with JDK v1.7.0_95 +1 javac 0m 48s the patch passed +1 compile 0m 44s the patch passed with JDK v1.8.0_191 +1 javac 0m 44s the patch passed +1 checkstyle 0m 24s the patch passed +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 0s hadoop-hdfs-project/hadoop-hdfs generated 0 new + 0 unchanged - 1 fixed = 0 total (was 1) +1 javadoc 0m 58s the patch passed with JDK v1.7.0_95 +1 javadoc 0m 38s the patch passed with JDK v1.8.0_191       Other Tests -1 unit 54m 57s hadoop-hdfs in the patch failed. +1 asflicense 0m 23s The patch does not generate ASF License warnings. 95m 44s Reason Tests Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeRespectsBindHostKeys   hadoop.hdfs.server.namenode.TestNameNodeHttpServerXFrame   hadoop.hdfs.web.TestWebHdfsTimeouts Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:da67579 JIRA Issue HDFS-14414 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12965039/HDFS-14414-branch-2.00.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 8e595c11fa74 4.4.0-138-generic #164-Ubuntu SMP Tue Oct 2 17:16:02 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision branch-2 / dce76e0 maven version: Apache Maven 3.3.9 Default Java 1.8.0_191 Multi-JDK versions /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_95 /usr/lib/jvm/java-8-openjdk-amd64:1.8.0_191 findbugs v3.0.0 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/26588/artifact/out/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/26588/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/26588/testReport/ Max. process+thread count 3265 (vs. ulimit of 10000) modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/26588/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.

          +1 I think there's something wrong with Yetus. The reported javac warning is exactly what the patch removed.

          weichiu Wei-Chiu Chuang added a comment - +1 I think there's something wrong with Yetus. The reported javac warning is exactly what the patch removed.

          Pushed to branch-2, branch-2.9 and branch-2.8. Thanks dineshchitlangia!

          weichiu Wei-Chiu Chuang added a comment - Pushed to branch-2, branch-2.9 and branch-2.8. Thanks dineshchitlangia !
          dineshchitlangia Dinesh Chitlangia added a comment - - edited

          weichiu Thanks for review and commit!

          dineshchitlangia Dinesh Chitlangia added a comment - - edited weichiu Thanks for review and commit!

          People

            dineshchitlangia Dinesh Chitlangia
            weichiu Wei-Chiu Chuang
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: