Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1440

TestComputeInvalidateWork fails intermittently

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: test
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      TestComputeInvalidateWork fails intermittently. This is due to incorrect synchronization introduced due to HDFS-1093. The test uses blocks synchronized on FSNamesystem monitor, however with HDFS-1093, the FSNamesystem uses explicit read/write lock for synchronization.

      1. HDFS-1440.patch
        3 kB
        Suresh Srinivas

        Issue Links

          Activity

          Suresh Srinivas created issue -
          Hide
          Suresh Srinivas added a comment -

          In the attached patch, the test is changed to use FsNamesystem#fsLock.

          Show
          Suresh Srinivas added a comment - In the attached patch, the test is changed to use FsNamesystem#fsLock.
          Suresh Srinivas made changes -
          Field Original Value New Value
          Attachment HDFS-1440.patch [ 12456338 ]
          Suresh Srinivas made changes -
          Link This issue is related to HDFS-1093 [ HDFS-1093 ]
          Suresh Srinivas made changes -
          Attachment HDFS-1440.patch [ 12456338 ]
          Hide
          Suresh Srinivas added a comment -

          Updated patch.

          Show
          Suresh Srinivas added a comment - Updated patch.
          Suresh Srinivas made changes -
          Attachment HDFS-1440.patch [ 12456339 ]
          Hide
          Jakob Homan added a comment -

          +1

          Show
          Jakob Homan added a comment - +1
          Jakob Homan made changes -
          Hadoop Flags [Reviewed]
          Hide
          dhruba borthakur added a comment -

          +1

          Show
          dhruba borthakur added a comment - +1
          Hide
          Suresh Srinivas added a comment -

          testpatch output:
          [exec] +1 overall.
          [exec]
          [exec] +1 @author. The patch does not contain any @author tags.
          [exec]
          [exec] +1 tests included. The patch appears to include 3 new or modified tests.
          [exec]
          [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
          [exec]
          [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
          [exec]
          [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
          [exec]
          [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
          [exec]
          [exec] +1 system tests framework. The patch passed system tests framework compile.

          TestComputeInvalidateWork does not fail with this patch.

          Show
          Suresh Srinivas added a comment - testpatch output: [exec] +1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] +1 tests included. The patch appears to include 3 new or modified tests. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile. TestComputeInvalidateWork does not fail with this patch.
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to trunk.

          Show
          Suresh Srinivas added a comment - I committed the patch to trunk.
          Suresh Srinivas made changes -
          Status Open [ 1 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/)
          HDFS-1440. Fix TestComputeInvalidateWork failure. Contributed by Suresh Srinvias.

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/ ) HDFS-1440 . Fix TestComputeInvalidateWork failure. Contributed by Suresh Srinvias.
          Konstantin Shvachko made changes -
          Status Resolved [ 5 ] Closed [ 6 ]

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development