Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1434

Refactor Datanode#startDataNode method

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      This method is very long, approximately 190 lines. Splitting this method into smaller methods. This also helps in federation where some of the initialization in this methods will be done once for a datanode and others once in every heartbeat thread per namenode in DN.

      1. HDFS-1434.patch
        13 kB
        Suresh Srinivas

        Activity

        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/ )
        Hide
        Suresh Srinivas added a comment -

        Sorry cut and paste error in my previous comment. It excluded this:
        The patch does not include tests because this is refactoring the existing method into smaller methods. The existing tests cover the changes in the patch.

        Show
        Suresh Srinivas added a comment - Sorry cut and paste error in my previous comment. It excluded this: The patch does not include tests because this is refactoring the existing method into smaller methods. The existing tests cover the changes in the patch.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch. Thanks Boris for the review.

        Show
        Suresh Srinivas added a comment - I committed the patch. Thanks Boris for the review.
        Hide
        Konstantin Boudnik added a comment -

        The patch doesn't include any tests. Why? Is it ok?

        Show
        Konstantin Boudnik added a comment - The patch doesn't include any tests. Why? Is it ok?
        Hide
        Suresh Srinivas added a comment -

        All unit tests passed other than TestComputeInvalidateWork and TestLargeBlock. These failures are unrelated to this patch.

        test-patch output:

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        [exec]
        [exec] +1 system tests framework. The patch passed system tests framework compile.

        Show
        Suresh Srinivas added a comment - All unit tests passed other than TestComputeInvalidateWork and TestLargeBlock. These failures are unrelated to this patch. test-patch output: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. [exec] [exec] +1 system tests framework. The patch passed system tests framework compile.
        Hide
        Konstantin Boudnik added a comment -

        Also, please run test-patch.sh at least locally (Hudson seems to be non-working) to make sure, among oher things, that Herriot bindings remain intact.

        Show
        Konstantin Boudnik added a comment - Also, please run test-patch.sh at least locally (Hudson seems to be non-working) to make sure, among oher things, that Herriot bindings remain intact.
        Hide
        Boris Shkolnik added a comment -

        +1
        Please run the tests..

        Show
        Boris Shkolnik added a comment - +1 Please run the tests..
        Hide
        Suresh Srinivas added a comment -

        Attached patch split the method into smaller methods.

        Show
        Suresh Srinivas added a comment - Attached patch split the method into smaller methods.

          People

          • Assignee:
            Suresh Srinivas
            Reporter:
            Suresh Srinivas
          • Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development