[HDFS-14259] RBF: Fix safemode message for Router

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.3.0, HDFS-13891
• Hadoop Flags: Reviewed
• Assignee: Ranith Sardar
• Reporter: Íñigo Goiri
• Created: 06/Feb/19 21:15
• Updated: 12/Sep/19 20:00
• Resolved: 03/Mar/19 01:17

Description

Currently, the getSafemode() bean checks the state of the Router but returns the error if the status is different than SAFEMODE:

  public String getSafemode() {
      if (!getRouter().isRouterState(RouterServiceState.SAFEMODE)) {
        return "Safe mode is ON. " + this.getSafeModeTip();
      }
    } catch (IOException e) {
      return "Failed to get safemode status. Please check router"
          + "log for more detail.";
    }
    return "";
  }

The condition should be reversed.

Issue Links

• is caused by: HDFS-14191 RBF: Remove hard coded router status from FederationMetrics.