[HDFS-14247] Repeat adding node description into network topology

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.3.0
• Fix Version/s: 2.10.0, 3.0.4, 3.3.0, 2.8.6, 3.2.1, 2.9.3, 3.1.3
• Component/s: datanode
• Hadoop Flags: Reviewed
• Assignee: HuangTao
• Reporter: HuangTao
• Created: 31/Jan/19 04:14
• Updated: 02/Oct/19 17:15
• Resolved: 01/Mar/19 17:20

Description

I find there is a duplicate code to add nodeDescr to networktopology in the DatanodeManager.java#registerDatanode.

It firstly call networktopology.add(nodeDescr), and then call  addDatanode(nodeDescr) to add nodeDescr again

Issue Links

• is duplicated by: HDFS-10865 Datanodemanager adds nodes twice to NetworkTopology
• is related to: HDFS-4521 invalid network topologies should not be cached