Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1417

Add @Override annotation to SimulatedFSDataset methods that implement FSDatasetInterface

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      @Override annotations are inconsistently added to methods implementing the interface.

      1. HDFS-1417.patch
        4 kB
        Suresh Srinivas

        Issue Links

          Activity

          Hide
          Hudson added a comment -

          Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/)

          Show
          Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #406 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/406/ )
          Hide
          Suresh Srinivas added a comment -

          I committed the patch to trunk.

          Show
          Suresh Srinivas added a comment - I committed the patch to trunk.
          Hide
          Suresh Srinivas added a comment -

          This change adds only annotation. So no tests are added. Cannot run testpatch because HDFS trunk is broken (see HADOOP-6951). I will commit the change because this is just adding annotation.

          Show
          Suresh Srinivas added a comment - This change adds only annotation. So no tests are added. Cannot run testpatch because HDFS trunk is broken (see HADOOP-6951 ). I will commit the change because this is just adding annotation.
          Hide
          Suresh Srinivas added a comment -

          With @Override you do not need

          {@inheritDoc}

          to include the Javadoc from the super class/interface.

          Show
          Suresh Srinivas added a comment - With @Override you do not need {@inheritDoc} to include the Javadoc from the super class/interface.
          Hide
          Boris Shkolnik added a comment -

          +1.
          nit. why did you remove

          {@inheritDoc}

          ?

          Show
          Boris Shkolnik added a comment - +1. nit. why did you remove {@inheritDoc} ?
          Hide
          Suresh Srinivas added a comment -

          Attached patch add @Override annotation

          Show
          Suresh Srinivas added a comment - Attached patch add @Override annotation

            People

            • Assignee:
              Suresh Srinivas
              Reporter:
              Suresh Srinivas
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development