[HDFS-14158] Checkpointer ignores configured time period > 5 minutes

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 2.8.1
• Fix Version/s: 3.3.0
• Component/s: namenode
• Labels: checkpoint hdfs namenode
• Hadoop Flags: Reviewed
• Release Note: Fix the Checkpointer not to ignore the configured "dfs.namenode.checkpoint.period" > 5 minutes
• Assignee: Timo Walter
• Reporter: Timo Walter
• Created: 18/Dec/18 12:12
• Updated: 04/Feb/19 04:53
• Resolved: 04/Feb/19 04:52

Description

The checkpointer always triggers a checkpoint every 5 minutes and ignores the flag "dfs.namenode.checkpoint.period", if its greater than 5 minutes.

See the code below (in Checkpointer.java):

//Main work loop of the Checkpointer
public void run() {
  // Check the size of the edit log once every 5 minutes.
  long periodMSec = 5 * 60;   // 5 minutes
  if(checkpointConf.getPeriod() < periodMSec) {
    periodMSec = checkpointConf.getPeriod();
  }

If the configured period ("dfs.namenode.checkpoint.period") is lower than 5 minutes, you choose use the configured one. But it always ignores it, if it's greater than 5 minutes.

 

In my opinion, the if-expression should be:

if(checkpointConf.getPeriod() > periodMSec) {
    periodMSec = checkpointConf.getPeriod();
  }

 

Then "dfs.namenode.checkpoint.period" won't get ignored.

Issue Links

• links to: GitHub Pull Request #449
• links to: GitHub Pull Request #449