[HDFS-14106] Refactor NamenodeFsck#copyBlock

• Type: Improvement
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.2.0
• Fix Version/s: 3.3.0
• Component/s: namenode
• Flags: Patch
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 27/Nov/18 19:41
• Updated: 30/Nov/18 18:49
• Resolved: 30/Nov/18 18:48

Description

1. Code is performing copy with a 1K buffer. 8K is the standard these days
2. Improve code design; do not catch one's own exception, do not log and throw (only do one or the other, never both)
3. Refactor to make a new method for copy