Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1409

The "register" method of the BackupNode class should be "UnsupportedActionException("register")"

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Affects Version/s: 0.21.0
    • Fix Version/s: 0.22.0
    • Component/s: namenode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      The register method of the BackupNode class should be "UnsupportedActionException("register")" rather than "UnsupportedActionException("journal")".

      1. HDFS-1409.patch
        0.6 kB
        Ching-Shen Chen
      2. HDFS-1409.patch
        0.5 kB
        Ching-Shen Chen

        Activity

        Hide
        Ching-Shen Chen added a comment -

        Attached a new patch.

        Show
        Ching-Shen Chen added a comment - Attached a new patch.
        Hide
        Konstantin Shvachko added a comment -

        I agree. Modular the same comments as I made in HDFS-1410

        Show
        Konstantin Shvachko added a comment - I agree. Modular the same comments as I made in HDFS-1410
        Hide
        Ching-Shen Chen added a comment -

        Attached a new patch.

        Show
        Ching-Shen Chen added a comment - Attached a new patch.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12455111/HDFS-1409.patch
        against trunk revision 1133476.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed these core unit tests:
        org.apache.hadoop.cli.TestHDFSCLI
        org.apache.hadoop.hdfs.server.namenode.TestBackupNode

        +1 contrib tests. The patch passed contrib unit tests.

        +1 system test framework. The patch passed system test framework compile.

        Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/753//testReport/
        Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/753//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/753//console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12455111/HDFS-1409.patch against trunk revision 1133476. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed these core unit tests: org.apache.hadoop.cli.TestHDFSCLI org.apache.hadoop.hdfs.server.namenode.TestBackupNode +1 contrib tests. The patch passed contrib unit tests. +1 system test framework. The patch passed system test framework compile. Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/753//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/753//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/753//console This message is automatically generated.
        Hide
        Konstantin Shvachko added a comment -

        +1 Looks good

        Show
        Konstantin Shvachko added a comment - +1 Looks good
        Hide
        Konstantin Shvachko added a comment -

        I just committed this. Thank you Ching-Shen Chen.

        Show
        Konstantin Shvachko added a comment - I just committed this. Thank you Ching-Shen Chen.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-22-branch #66 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/66/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-22-branch #66 (See https://builds.apache.org/job/Hadoop-Hdfs-22-branch/66/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #746 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/746/ )
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk #699 (See https://builds.apache.org/job/Hadoop-Hdfs-trunk/699/ )

          People

          • Assignee:
            Ching-Shen Chen
            Reporter:
            Ching-Shen Chen
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development