[HDFS-13868] WebHDFS: GETSNAPSHOTDIFF API NPE when param "snapshotname" is given but "oldsnapshotname" is not.

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.0, 3.0.3
• Fix Version/s: 3.2.0, 3.0.4, 3.1.2
• Component/s: hdfs, webhdfs
• Assignee: Pranay Singh
• Reporter: Siyao Meng
• Created: 24/Aug/18 21:57
• Updated: 02/Oct/19 17:13
• Resolved: 19/Sep/18 10:22

Description

HDFS-13052 implements GETSNAPSHOTDIFF for WebHDFS.

 

Proof:

# Bash

# Prerequisite: You will need to create the directory "/snapshot", allowSnapshot() on it, and create a snapshot named "snap3" for it to reach NPE.

$ curl "http://<SERVER>:<PORT>/webhdfs/v1/snaptest/?op=GETSNAPSHOTDIFF&user.name=hdfs&oldsnapshotnameZZZ=snap2&snapshotname=snap3"
# Note that I intentionally typed the wrong parameter name for "oldsnapshotname" above to cause NPE.

{"RemoteException":{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException","message":null}}


# OR

$ curl "http://<SERVER>:<PORT>/webhdfs/v1/snaptest/?op=GETSNAPSHOTDIFF&user.name=hdfs&oldsnapshotname=&snapshotname=snap3"
# Empty string for oldsnapshotname

{"RemoteException":{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException","message":null}}


# OR

$ curl "http://<SERVER>:<PORT>/webhdfs/v1/snaptest/?op=GETSNAPSHOTDIFF&user.name=hdfs&snapshotname=snap3"
# Missing param oldsnapshotname, essentially the same as the first case.

{"RemoteException":{"exception":"NullPointerException","javaClassName":"java.lang.NullPointerException","message":null}

Issue Links

• is caused by: HDFS-13052 WebHDFS: Add support for snasphot diff