+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12483782/HDFS-1381-take1.txt
against trunk revision 1139397.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 9 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
+1 system test framework. The patch passed system test framework compile.
Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/834//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/834//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/834//console
This message is automatically generated.
Update: though these configs no longer show up in MiniDFSCluster, they're still in a few places they shouldn't be.