[HDFS-13703] Avoid allocation of CorruptedBlocks hashmap when no corrupted blocks are hit

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 3.2.0, 3.1.1, 3.0.4
• Component/s: performance
• Assignee: Todd Lipcon
• Reporter: Todd Lipcon
• Created: 26/Jun/18 19:25
• Updated: 02/Jul/18 10:26
• Resolved: 02/Jul/18 10:04

Description

The DFSClient creates a CorruptedBlocks object, which contains a HashMap, on every read call. In most cases, a read will not hit any corrupted blocks, and this hashmap is not used. It seems the JIT isn't smart enough to eliminate this allocation. We would be better off avoiding it and only allocating in the rare case when a corrupt block is hit.

Removing this allocation reduced CPU usage of a TeraValidate job by about 10%.