[HDFS-13475] RBF: Admin cannot enforce Router enter SafeMode

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Fix Version/s: 2.10.0, 3.2.0, 3.1.1, 2.9.2, 3.0.4
• Hadoop Flags: Reviewed
• Assignee: Chao Sun
• Reporter: Wei Yan
• Created: 18/Apr/18 17:27
• Updated: 16/Jul/18 17:50
• Resolved: 16/Jul/18 16:50

Description

To reproduce the issue: 

$ bin/hdfs dfsrouteradmin -safemode enter
Successfully enter safe mode.
$ bin/hdfs dfsrouteradmin -safemode get
Safe Mode: true

And then, 

$ bin/hdfs dfsrouteradmin -safemode get
Safe Mode: false

From the code, it looks like the periodicInvoke triggers the leave.

public void periodicInvoke() {
......
  // Always update to indicate our cache was updated
  if (isCacheStale) {
    if (!rpcServer.isInSafeMode()) {
      enter();
    }
  } else if (rpcServer.isInSafeMode()) {
    // Cache recently updated, leave safe mode
    leave();
  }
}

 

 

Issue Links

• is related to: HDFS-13068 RBF: Add router admin option to manage safe mode