[HDFS-13350] Negative legacy block ID will confuse Erasure Coding to be considered as striped block

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.1
• Fix Version/s: 3.2.0, 3.1.1, 3.0.3
• Component/s: erasure-coding
• Target Version/s: 3.0.2, 3.2.0, 3.1.1
• Assignee: Lei (Eddy) Xu
• Reporter: Lei (Eddy) Xu
• Created: 26/Mar/18 21:58
• Updated: 05/Apr/18 17:27
• Resolved: 05/Apr/18 17:12

Description

HDFS-4645 has changed HDFS block ID from randomly generated to sequential positive IDs. And later on, HDFS EC was built on the assumption that normal 3x replica block IDs are positive, so EC re-use negative IDs as striped blocks.

However, there are legacy block IDs can be negative in the system, we should not use hardcode method to check whether a block is stripe or not:

  public static boolean isStripedBlockID(long id) {
    return BlockType.fromBlockId(id) == STRIPED;
  }

Issue Links

• is related to: HDFS-10867 [PROVIDED Phase 2] Block Bit Field Allocation of Provided Storage