Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1334

open in HftpFileSystem does not add delegation tokens to the url.

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.22.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      open method in HftpFileSystem uses ByteRangeInputStream for url connection. But it does not add the delegation tokens, even if security is enabled, to the url before passing it to the ByteRangeInputStream. Therefore request fails if security is enabled.

      1. HDFS-1334.1.patch
        0.7 kB
        Jitendra Nath Pandey

        Activity

        Jitendra Nath Pandey created issue -
        Hide
        Jitendra Nath Pandey added a comment -

        Patch uploaded.

        Show
        Jitendra Nath Pandey added a comment - Patch uploaded.
        Jitendra Nath Pandey made changes -
        Field Original Value New Value
        Attachment HDFS-1334.1.patch [ 12451481 ]
        Jitendra Nath Pandey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Boris Shkolnik added a comment -

        +1

        Show
        Boris Shkolnik added a comment - +1
        Boris Shkolnik made changes -
        Hadoop Flags [Reviewed]
        Hide
        Jitendra Nath Pandey added a comment -

        ant test was run manually. All tests pass except TestHDFSTrash which is unrelated.

        test patch results

        [exec] -1 overall.
        [exec]
        [exec] +1 @author. The patch does not contain any @author tags.
        [exec]
        [exec] -1 tests included. The patch doesn't appear to include any new or modified tests.
        [exec] Please justify why no new tests are needed for this patch.
        [exec] Also please list what manual steps were performed to verify this patch.
        [exec]
        [exec] +1 javadoc. The javadoc tool did not generate any warning messages.
        [exec]
        [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings.
        [exec]
        [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings.
        [exec]
        [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.

        Show
        Jitendra Nath Pandey added a comment - ant test was run manually. All tests pass except TestHDFSTrash which is unrelated. test patch results [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings.
        Hide
        Jitendra Nath Pandey added a comment -

        The patch was tested manually on the trunk.

        Show
        Jitendra Nath Pandey added a comment - The patch was tested manually on the trunk.
        Hide
        Jakob Homan added a comment -

        I've committed this. Thanks, Jitendra. Resolving as fixed.

        Show
        Jakob Homan added a comment - I've committed this. Thanks, Jitendra. Resolving as fixed.
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #370 (See https://hudson.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/370/ )
        Konstantin Shvachko made changes -
        Fix Version/s 0.22.0 [ 12314241 ]
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jitendra Nath Pandey
            Reporter:
            Jitendra Nath Pandey
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development