[HDFS-13167] DatanodeAdminManager Improvements

• Type: Improvement
• Status: Resolved
• Priority: Trivial
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.1.0
• Component/s: hdfs
• Assignee: David Mollitor
• Reporter: David Mollitor
• Created: 18/Feb/18 18:49
• Updated: 19/Mar/18 18:31
• Resolved: 20/Feb/18 23:18

Description

1. Use Collection type Set instead of List for tracking nodes
2. Fix logging statements that are erroneously appending variables instead of using parameters
3. Miscellaneous small improvements

As an example, the node variable is being appended to the string instead of being passed as an argument to the trace method for variable substitution.

LOG.trace("stopDecommission: Node {} in {}, nothing to do." +
          node, node.getAdminState());