Details

    • Improvement
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • None
    • 3.1.0
    • diskbalancer
    • None
    • Reviewed

    Description

      Enable HDFS diskbalancer by default

      Attachments

        1. HDFS-13153.000.patch
          1 kB
          Ajay Kumar

        Issue Links

          Activity

            arp Arpit Agarwal added a comment -

            +1 pending Jenkins. Yes it's a good idea to enable this by default.

            arp Arpit Agarwal added a comment - +1 pending Jenkins. Yes it's a good idea to enable this by default.
            genericqa genericqa added a comment -
            -1 overall



            Vote Subsystem Runtime Comment
            0 reexec 0m 22s Docker mode activated.
                  Prechecks
            +1 @author 0m 0s The patch does not contain any @author tags.
            -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                  trunk Compile Tests
            +1 mvninstall 17m 16s trunk passed
            +1 compile 0m 58s trunk passed
            +1 checkstyle 0m 45s trunk passed
            +1 mvnsite 1m 4s trunk passed
            +1 shadedclient 11m 48s branch has no errors when building and testing our client artifacts.
            +1 findbugs 2m 0s trunk passed
            +1 javadoc 0m 56s trunk passed
                  Patch Compile Tests
            +1 mvninstall 1m 2s the patch passed
            +1 compile 0m 56s the patch passed
            +1 javac 0m 56s the patch passed
            +1 checkstyle 0m 41s the patch passed
            +1 mvnsite 1m 1s the patch passed
            +1 whitespace 0m 0s The patch has no whitespace issues.
            +1 xml 0m 1s The patch has no ill-formed XML file.
            +1 shadedclient 11m 6s patch has no errors when building and testing our client artifacts.
            +1 findbugs 2m 5s the patch passed
            +1 javadoc 0m 54s the patch passed
                  Other Tests
            -1 unit 139m 52s hadoop-hdfs in the patch failed.
            +1 asflicense 0m 28s The patch does not generate ASF License warnings.
            192m 54s



            Reason Tests
            Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks
              hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA
              hadoop.hdfs.server.namenode.TestTruncateQuotaUpdate
              hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
              hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



            Subsystem Report/Notes
            Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
            JIRA Issue HDFS-13153
            JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910810/HDFS-13153.000.patch
            Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml
            uname Linux b02cf01cc430 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
            Build tool maven
            Personality /testptch/patchprocess/precommit/personality/provided.sh
            git revision trunk / 0b489e5
            maven version: Apache Maven 3.3.9
            Default Java 1.8.0_151
            findbugs v3.1.0-RC1
            unit https://builds.apache.org/job/PreCommit-HDFS-Build/23089/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
            Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/23089/testReport/
            Max. process+thread count 2826 (vs. ulimit of 5500)
            modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
            Console output https://builds.apache.org/job/PreCommit-HDFS-Build/23089/console
            Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org

            This message was automatically generated.

            genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 22s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 17m 16s trunk passed +1 compile 0m 58s trunk passed +1 checkstyle 0m 45s trunk passed +1 mvnsite 1m 4s trunk passed +1 shadedclient 11m 48s branch has no errors when building and testing our client artifacts. +1 findbugs 2m 0s trunk passed +1 javadoc 0m 56s trunk passed       Patch Compile Tests +1 mvninstall 1m 2s the patch passed +1 compile 0m 56s the patch passed +1 javac 0m 56s the patch passed +1 checkstyle 0m 41s the patch passed +1 mvnsite 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 shadedclient 11m 6s patch has no errors when building and testing our client artifacts. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 54s the patch passed       Other Tests -1 unit 139m 52s hadoop-hdfs in the patch failed. +1 asflicense 0m 28s The patch does not generate ASF License warnings. 192m 54s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.ha.TestRetryCacheWithHA   hadoop.hdfs.server.namenode.TestTruncateQuotaUpdate   hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HDFS-13153 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12910810/HDFS-13153.000.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle xml uname Linux b02cf01cc430 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 0b489e5 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/23089/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/23089/testReport/ Max. process+thread count 2826 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/23089/console Powered by Apache Yetus 0.8.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
            arp Arpit Agarwal added a comment -

            The test failures are unrelated (verified locally). I've committed this. Thanks ajayydv.

            arp Arpit Agarwal added a comment - The test failures are unrelated (verified locally). I've committed this. Thanks ajayydv .
            hudson Hudson added a comment -

            SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13672/)
            HDFS-13153. Enable HDFS diskbalancer by default. Contributed by Ajay (arp: rev 8d5ea7470a3225319e3bef5626b837572c2e0d3c)

            • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
            • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
            hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13672 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13672/ ) HDFS-13153 . Enable HDFS diskbalancer by default. Contributed by Ajay (arp: rev 8d5ea7470a3225319e3bef5626b837572c2e0d3c) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
            ajayydv Ajay Kumar added a comment -

            Thanks arpitagarwal

            ajayydv Ajay Kumar added a comment - Thanks arpitagarwal

            People

              ajayydv Ajay Kumar
              ajayydv Ajay Kumar
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: