[HDFS-13036] Reusing the volume storage ID obtained by replicaInfo

• Type: Improvement
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.1.0
• Fix Version/s: 3.1.0
• Component/s: datanode
• Assignee: liaoyuxiangqin
• Reporter: liaoyuxiangqin
• Created: 19/Jan/18 03:00
• Updated: 20/Jan/18 02:12
• Resolved: 20/Jan/18 02:01

Description

When i read the getBlockReports() of FsDatasetImpl class in datanode, i found the following case code could be more simplify and need't to obtained volume storage ID by replicaInfo again and again, because the vol id have get by above code.Thanks.

FsDatasetImpl.java

switch(b.getState()) {
case FINALIZED:
case RBW:
case RWR:
 builders.get(b.getVolume().getStorageID()).add(b);
 break;
case RUR:
 ReplicaInfo orig = b.getOriginalReplica();
 builders.get(b.getVolume().getStorageID()).add(orig);
 break;
case TEMPORARY:
 break;
default:
 assert false : "Illegal ReplicaInfo state.";
}