Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-13016

globStatus javadoc refers to glob pattern as "regular expression"

Details

    • Bug
    • Status: Resolved
    • Trivial
    • Resolution: Fixed
    • None
    • 3.1.0
    • documentation, hdfs
    • None
    • Reviewed

    Description

      Glob patterns are not regular expressions. Both are well-defined and universally understood concepts. The term "regular expression" is misapplied here.

      The method name "globStatus" indicates that pathPattern should be a glob, but the javadoc says pathPattern is a regular expression. The documentation goes on to describe the accepted format of pathPattern and clearly describes globs.

      The term "regular expression" should not be associated with pathPattern.

      Attachments

        1. HDFS-13016.001.patch
          2 kB
          Mukul Kumar Singh

        Activity

          arp Arpit Agarwal added a comment -

          +1 pending Jenkins.

          arp Arpit Agarwal added a comment - +1 pending Jenkins.
          genericqa genericqa added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 16m 33s trunk passed
          +1 compile 13m 26s trunk passed
          +1 checkstyle 0m 38s trunk passed
          +1 mvnsite 1m 5s trunk passed
          +1 shadedclient 11m 57s branch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 38s trunk passed
          +1 javadoc 0m 54s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 54s the patch passed
          +1 compile 13m 26s the patch passed
          +1 javac 13m 26s the patch passed
          +1 checkstyle 0m 38s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 10m 14s patch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 41s the patch passed
          +1 javadoc 1m 1s the patch passed
                Other Tests
          +1 unit 9m 35s hadoop-common in the patch passed.
          -1 asflicense 0m 35s The patch generated 1 ASF License warnings.
          85m 27s



          Subsystem Report/Notes
          Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639
          JIRA Issue HDFS-13016
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12905985/HDFS-13016.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux bf07133cdcb0 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / 9afb802
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_151
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/22663/testReport/
          asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/22663/artifact/out/patch-asflicense-problems.txt
          Max. process+thread count 1347 (vs. ulimit of 5000)
          modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/22663/console
          Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          genericqa genericqa added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 16m 33s trunk passed +1 compile 13m 26s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 1m 5s trunk passed +1 shadedclient 11m 57s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 38s trunk passed +1 javadoc 0m 54s trunk passed       Patch Compile Tests +1 mvninstall 0m 54s the patch passed +1 compile 13m 26s the patch passed +1 javac 13m 26s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 10m 14s patch has no errors when building and testing our client artifacts. +1 findbugs 1m 41s the patch passed +1 javadoc 1m 1s the patch passed       Other Tests +1 unit 9m 35s hadoop-common in the patch passed. -1 asflicense 0m 35s The patch generated 1 ASF License warnings. 85m 27s Subsystem Report/Notes Docker Client=17.05.0-ce Server=17.05.0-ce Image:yetus/hadoop:5b98639 JIRA Issue HDFS-13016 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12905985/HDFS-13016.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux bf07133cdcb0 3.13.0-135-generic #184-Ubuntu SMP Wed Oct 18 11:55:51 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 9afb802 maven version: Apache Maven 3.3.9 Default Java 1.8.0_151 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/22663/testReport/ asflicense https://builds.apache.org/job/PreCommit-HDFS-Build/22663/artifact/out/patch-asflicense-problems.txt Max. process+thread count 1347 (vs. ulimit of 5000) modules C: hadoop-common-project/hadoop-common U: hadoop-common-project/hadoop-common Console output https://builds.apache.org/job/PreCommit-HDFS-Build/22663/console Powered by Apache Yetus 0.7.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          arp Arpit Agarwal added a comment -

          I've committed this. Thanks for fixing this Mukul, thanks for the bug report Ryanne.

          arp Arpit Agarwal added a comment - I've committed this. Thanks for fixing this Mukul, thanks for the bug report Ryanne.
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13495 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13495/)
          HDFS-13016. globStatus javadoc refers to glob pattern as "regular (arp: rev 7016dd44e0975274856dc19f19815123c4b2a352)

          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #13495 (See https://builds.apache.org/job/Hadoop-trunk-Commit/13495/ ) HDFS-13016 . globStatus javadoc refers to glob pattern as "regular (arp: rev 7016dd44e0975274856dc19f19815123c4b2a352) (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileContext.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystem.java

          People

            msingh Mukul Kumar Singh
            ryannedolan Ryanne Dolan
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: