Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-13001

Testcase improvement for DFSAdmin

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Patch Available
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: 2.9.0, 3.0.0
    • Fix Version/s: None
    • Component/s: test, tools
    • Labels:
      None

      Description

      Testcase improvement for DFSAdmin command. The commands should be tested under following environments:
      (1) Both Namenode are up online
      (2) NN1 is off offline and NN2 is up online
      (3) NN1 is up online and NN2 is down offline
      (4) Both Namenode are down offline
      The testcases can be improved.

      Testcases can be improved like code below.

        private void testExecuteDFSAdminCommand(int nnIndex, String[] command,
            String message) throws Exception {
          setUpHaCluster(false);
          switch (nnIndex) {
            case 0:
              cluster.getDfsCluster().shutdownNameNode(0);
              cluster.getDfsCluster().transitionToActive(1);
              break;
            case 1:
              cluster.getDfsCluster().shutdownNameNode(1);
              cluster.getDfsCluster().transitionToActive(0);
              break;
            case 2:
              cluster.getDfsCluster().shutdownNameNode(0);
              cluster.getDfsCluster().shutdownNameNode(1);
              break;
            default:
      
          }
          int exitCode = admin.run(command);
          if (nnIndex != 2) {
            assertEquals(err.toString().trim(), 0, exitCode);
            assertOutputMatches(message + newLine);
          } else {
            assertNotEquals(err.toString().trim(), 0, exitCode);
            assertOutputNotMatches(message + newLine);
          }
        }
      

        Attachments

        1. HDFS-13001.001.patch
          37 kB
          Jianfei Jiang
        2. HDFS-13001.002.patch
          39 kB
          Jianfei Jiang
        3. HDFS-13001.003.patch
          39 kB
          Jianfei Jiang

          Issue Links

            Activity

              People

              • Assignee:
                jiangjianfei Jianfei Jiang
                Reporter:
                jiangjianfei Jianfei Jiang
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: