[HDFS-12948] DiskBalancer report command top option should only take positive numeric values

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0
• Fix Version/s: 3.1.0
• Component/s: diskbalancer
• Hadoop Flags: Reviewed
• Assignee: Shashikant Banerjee
• Reporter: Namit Maheshwari
• Created: 20/Dec/17 13:28
• Updated: 20/Jan/18 01:08
• Resolved: 04/Jan/18 02:50

Description

Currently , diskBalancer report command "top" option takes values like "AAA" as well negative/decimal values and gives output. These invalid values should not be processed and some error/warning should be given.

For Example,
$ hdfs diskbalancer -report -top -100
17/12/19 15:07:01 INFO command.Command: Processing report command
17/12/19 15:07:02 INFO balancer.KeyManager: Block token params received from NN: update interval=10hrs, 0sec, token lifetime=10hrs, 0sec
17/12/19 15:07:02 INFO block.BlockTokenSecretManager: Setting block keys
17/12/19 15:07:02 INFO balancer.KeyManager: Update block keys every 2hrs, 30mins, 0sec
17/12/19 15:07:02 INFO command.Command: Reporting top -100 DataNode(s) benefiting from running DiskBalancer.
Processing report command
Reporting top -100 DataNode(s) benefiting from running DiskBalancer.