Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.22.0
    • Fix Version/s: 0.22.0
    • Component/s: build
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Library versions specified by ant eclipse-files have drifted from those used by ivy again. Until HDFS-1035 meanders into the code, we need to make sure we keep these updated, otherwise bedlam breaks loose for Eclipse developers.

        Activity

        Jakob Homan created issue -
        Hide
        Jakob Homan added a comment -

        Patch brings library versions back in sync. Fixes library issues for me in Eclipse, although I still have to use the compile-contrib and test targets to make sure ivy brings in all the libraries, which we should fix at some point.

        Show
        Jakob Homan added a comment - Patch brings library versions back in sync. Fixes library issues for me in Eclipse, although I still have to use the compile-contrib and test targets to make sure ivy brings in all the libraries, which we should fix at some point.
        Jakob Homan made changes -
        Field Original Value New Value
        Attachment HDFS-1238.patch [ 12448844 ]
        Hide
        Jakob Homan added a comment -

        submitting patch.

        Show
        Jakob Homan added a comment - submitting patch.
        Jakob Homan made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12448844/HDFS-1238.patch
        against trunk revision 960949.

        +1 @author. The patch does not contain any @author tags.

        +1 tests included. The patch appears to include 5 new or modified tests.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12448844/HDFS-1238.patch against trunk revision 960949. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 5 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/423/console This message is automatically generated.
        Hide
        Ravi Phulari added a comment -

        Patch looks good to me, tested with eclipse setup on clean source checkout.
        +1

        Show
        Ravi Phulari added a comment - Patch looks good to me, tested with eclipse setup on clean source checkout. +1
        Hide
        Jakob Homan added a comment -

        Test failures are unrelated. Thanks for the review, Ravi. I have committed this. Resolving as fixed.

        Show
        Jakob Homan added a comment - Test failures are unrelated. Thanks for the review, Ravi. I have committed this. Resolving as fixed.
        Jakob Homan made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #332 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/332/)
        HDFS-1283. ant eclipse-files has drifted again. (jghoman)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #332 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/332/ ) HDFS-1283 . ant eclipse-files has drifted again. (jghoman)
        Konstantin Shvachko made changes -
        Status Resolved [ 5 ] Closed [ 6 ]

          People

          • Assignee:
            Jakob Homan
            Reporter:
            Jakob Homan
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development