[HDFS-12655] Ozone: use specific names for RPC.Server instances

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HDFS-7240
• Fix Version/s: HDFS-7240
• Component/s: ozone
• Hadoop Flags: Reviewed
• Assignee: Marton Elek
• Reporter: Marton Elek
• Created: 13/Oct/17 11:50
• Updated: 24/Apr/18 20:57
• Resolved: 26/Oct/17 18:10

Description

My original motivation is using meaningful names on the scm web ui. As you can see on the attached screenshot we display the metrics for all the RPC servers (using hadoop metrics published on jmx). Unfortunatelly we can display only the port number on the web ui as there are no meaningfull names published on the jmx interface.

After some investigation I found that there is a serverName constructor parameter int Rpc.Server but it is NOT used currently.

This patch will:

1. store the serverName in field of RPC.Server a
2. Improve the way how the serverName is calculated from the protocol class names (it's typically an anonnymous inner class, so I remove the unnecessary $-s from the name.)
3. Add a new tag to the RpcMetrics based on the serverName field of the Rpc.Server It will be displayed over JMX
4. Add unit tests for checking the tag values and the default classname->servername mapping.

ps: I need it for Ozone SCM web ui, but let ne know if it should be moved to HADOOP project/trunk.