[HDFS-12614] FSPermissionChecker#getINodeAttrs() throws NPE when INodeAttributesProvider configured

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 3.0.0-beta1
• Fix Version/s: 3.0.0, 2.10.0, 2.9.1, 2.8.4
• Target Version/s: 3.0.0
• Assignee: Manoj Govindassamy
• Reporter: Manoj Govindassamy
• Created: 07/Oct/17 01:40
• Updated: 18/Mar/20 03:46
• Resolved: 17/Oct/17 00:44

Description

When INodeAttributesProvider is configured, and when resolving path (like "/") and checking for permission, the following code when working on pathByNameArr throws NullPointerException.

  private INodeAttributes getINodeAttrs(byte[][] pathByNameArr, int pathIdx,
      INode inode, int snapshotId) {
    INodeAttributes inodeAttrs = inode.getSnapshotINode(snapshotId);
    if (getAttributesProvider() != null) {
      String[] elements = new String[pathIdx + 1];
      for (int i = 0; i < elements.length; i++) {
        elements[i] = DFSUtil.bytes2String(pathByNameArr[i]);  <===
      }
      inodeAttrs = getAttributesProvider().getAttributes(elements, inodeAttrs);
    }
    return inodeAttrs;
  }

Looks like for paths like "/" where the split components based on delimiter "/" can be null, the pathByNameArr array can have null elements and can throw NPE.

Issue Links

• duplicates: HDFS-15226 Ranger integrates HDFS and discovers NPE
• fixes: RANGER-2745 execute hdfs dfs -ls / NPE
• relates to: HDFS-10673 Optimize FSPermissionChecker's internal path usage