Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Blocker Blocker
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 0.21.0
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      It is being compiled, but is not added to the distribution.

      1. HDFS-1256.patch
        0.8 kB
        Tom White
      2. HDFS-1256.patch
        0.5 kB
        Tom White

        Activity

        Hide
        Tom White added a comment -

        Patch to include c++ build directory in the distribution.

        Show
        Tom White added a comment - Patch to include c++ build directory in the distribution.
        Hide
        Eli Collins added a comment -

        +1 patch lgtm.

        Show
        Eli Collins added a comment - +1 patch lgtm.
        Hide
        Tom White added a comment -

        Slight modification to create the c++ build directory, which is needed if you are not building native code.

        Results of test-patch:

             [exec] -1 overall.  
             [exec] 
             [exec]     +1 @author.  The patch does not contain any @author tags.
             [exec] 
             [exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
             [exec]                         Please justify why no new tests are needed for this patch.
             [exec]                         Also please list what manual steps were performed to verify this patch.
             [exec] 
             [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
             [exec] 
             [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
             [exec] 
             [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
             [exec] 
             [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
        

        There are no tests since this is a packaging change.

        Show
        Tom White added a comment - Slight modification to create the c++ build directory, which is needed if you are not building native code. Results of test-patch: [exec] -1 overall. [exec] [exec] +1 @author. The patch does not contain any @author tags. [exec] [exec] -1 tests included. The patch doesn't appear to include any new or modified tests. [exec] Please justify why no new tests are needed for this patch. [exec] Also please list what manual steps were performed to verify this patch. [exec] [exec] +1 javadoc. The javadoc tool did not generate any warning messages. [exec] [exec] +1 javac. The applied patch does not increase the total number of javac compiler warnings. [exec] [exec] +1 findbugs. The patch does not introduce any new Findbugs warnings. [exec] [exec] +1 release audit. The applied patch does not increase the total number of release audit warnings. There are no tests since this is a packaging change.
        Hide
        Tom White added a comment -

        I've just committed this.

        Show
        Tom White added a comment - I've just committed this.
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #321 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/321/)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #321 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/321/ )

          People

          • Assignee:
            Tom White
            Reporter:
            Tom White
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development