Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12530

Processor argument in Offline Image Viewer should be case insensitive

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: tools
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Currently, the processor argument in the Offline Image Viewer (oiv) is case sensitive. For example, it accepts "XML" but does not recognize "xml" as a valid processor argument.

      1. HDFS-12530.001.patch
        2 kB
        Hanisha Koneru
      2. HDFS-12530.002.patch
        2 kB
        Hanisha Koneru

        Activity

        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        I like the proposal. It's pretty annoying I have to look up doc to make sure my command cases are correct. +1 pending Jenkins.

        Show
        jojochuang Wei-Chiu Chuang added a comment - I like the proposal. It's pretty annoying I have to look up doc to make sure my command cases are correct. +1 pending Jenkins.
        Hide
        arpitagarwal Arpit Agarwal added a comment - - edited

        Thanks for this patch Hanisha Koneru.

        Minor point, it may be better to use the toUpperCase overload with locale and pass Locale.ENGLISH. Alternatively you can call StringUtils#toUpperCase.

        Show
        arpitagarwal Arpit Agarwal added a comment - - edited Thanks for this patch Hanisha Koneru . Minor point, it may be better to use the toUpperCase overload with locale and pass Locale.ENGLISH . Alternatively you can call StringUtils#toUpperCase .
        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thanks Wei-Chiu Chuang and Arpit Agarwal for the review.
        Updated the patch to use StringUtils#toUpperCase.

        Show
        hanishakoneru Hanisha Koneru added a comment - Thanks Wei-Chiu Chuang and Arpit Agarwal for the review. Updated the patch to use StringUtils#toUpperCase .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 11s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 3s trunk passed
        +1 compile 1m 4s trunk passed
        +1 checkstyle 0m 40s trunk passed
        +1 mvnsite 1m 10s trunk passed
        +1 findbugs 2m 3s trunk passed
        +1 javadoc 0m 47s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 2s the patch passed
        +1 compile 0m 59s the patch passed
        +1 javac 0m 59s the patch passed
        +1 checkstyle 0m 39s the patch passed
        +1 mvnsite 1m 9s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 5s the patch passed
        +1 javadoc 0m 42s the patch passed
              Other Tests
        -1 unit 94m 14s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 19s The patch does not generate ASF License warnings.
        122m 32s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.hdfs.server.namenode.TestReencryption
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.TestRollingUpgrade
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12530
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888382/HDFS-12530.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 744acf3a1e79 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / e5e1851
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21286/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21286/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 3s trunk passed +1 compile 1m 4s trunk passed +1 checkstyle 0m 40s trunk passed +1 mvnsite 1m 10s trunk passed +1 findbugs 2m 3s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 1m 2s the patch passed +1 compile 0m 59s the patch passed +1 javac 0m 59s the patch passed +1 checkstyle 0m 39s the patch passed +1 mvnsite 1m 9s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 5s the patch passed +1 javadoc 0m 42s the patch passed       Other Tests -1 unit 94m 14s hadoop-hdfs in the patch failed. +1 asflicense 0m 19s The patch does not generate ASF License warnings. 122m 32s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.TestReencryption   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestRollingUpgrade   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.datanode.TestDataNodeErasureCodingMetrics Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12530 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888382/HDFS-12530.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 744acf3a1e79 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / e5e1851 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21286/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21286/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21286/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 2s trunk passed
        +1 compile 0m 56s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 7s trunk passed
        +1 findbugs 1m 59s trunk passed
        +1 javadoc 0m 48s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 59s the patch passed
        +1 javac 0m 59s the patch passed
        +1 checkstyle 0m 37s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 4s the patch passed
        +1 javadoc 0m 45s the patch passed
              Other Tests
        -1 unit 91m 6s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 20s The patch does not generate ASF License warnings.
        120m 12s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12530
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888389/HDFS-12530.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 0d7737ec8dda 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / bfd1a72
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21288/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21288/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 2s trunk passed +1 compile 0m 56s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 7s trunk passed +1 findbugs 1m 59s trunk passed +1 javadoc 0m 48s trunk passed       Patch Compile Tests +1 mvninstall 1m 1s the patch passed +1 compile 0m 59s the patch passed +1 javac 0m 59s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 4s the patch passed +1 javadoc 0m 45s the patch passed       Other Tests -1 unit 91m 6s hadoop-hdfs in the patch failed. +1 asflicense 0m 20s The patch does not generate ASF License warnings. 120m 12s Reason Tests Failed junit tests hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12530 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888389/HDFS-12530.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 0d7737ec8dda 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bfd1a72 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21288/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21288/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21288/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 I will commit this shortly.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 I will commit this shortly.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I've committed this. Thanks for the improvement Hanisha Koneru and thanks Wei-Chiu Chuang for the review.

        Show
        arpitagarwal Arpit Agarwal added a comment - I've committed this. Thanks for the improvement Hanisha Koneru and thanks Wei-Chiu Chuang for the review.
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12947/)
        HDFS-12530. Processor argument in Offline Image Viewer should be case (arp: rev 08fca508e66e8eddc5d8fd1608ec0c9cd54fc990)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12947 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12947/ ) HDFS-12530 . Processor argument in Offline Image Viewer should be case (arp: rev 08fca508e66e8eddc5d8fd1608ec0c9cd54fc990) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineImageViewer/OfflineImageViewerPB.java
        Hide
        andrew.wang Andrew Wang added a comment -

        I've cherry-picked this to branch-3.0 as well, missed.

        Show
        andrew.wang Andrew Wang added a comment - I've cherry-picked this to branch-3.0 as well, missed.

          People

          • Assignee:
            hanishakoneru Hanisha Koneru
            Reporter:
            hanishakoneru Hanisha Koneru
          • Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development