Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12496

Make QuorumJournalManager timeout properties configurable

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Make QuorumJournalManager timeout properties configurable using a common key.

      1. HDFS-12496.01.patch
        9 kB
        Ajay Kumar
      2. HDFS-12496.02.patch
        9 kB
        Ajay Kumar
      3. HDFS-12496.03.patch
        10 kB
        Ajay Kumar
      4. HDFS-12496.04.patch
        8 kB
        Ajay Kumar
      5. HDFS-12496.05.patch
        8 kB
        Ajay Kumar
      6. HDFS-12496.06.patch
        8 kB
        Ajay Kumar

        Activity

        Hide
        hanishakoneru Hanisha Koneru added a comment -

        Thanks for the improvement Ajay Kumar. The patch LGTM.
        One minor nitpick - Can you add the TimeUnit in the name and/or description for the config key - qjm.op.timeout.key

        Show
        hanishakoneru Hanisha Koneru added a comment - Thanks for the improvement Ajay Kumar . The patch LGTM. One minor nitpick - Can you add the TimeUnit in the name and/or description for the config key - qjm.op.timeout.key
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        Hi Ajay Kumar, couple of comments:

        1. We should retain this comment. It clarifies that these timeouts are not used anywhere on the regular data write path. It may need to be reworded a bit though.
          -  // Since these don't occur during normal operation, we can
          -  // use rather lengthy timeouts, and don't need to make them
          -  // configurable.
          
        2. Extension to Hanisha's comment - you can also query this key using conf.getTimeDuration. That allows specifying time units with readable suffixes like 30s, 1m etc.
        Show
        arpitagarwal Arpit Agarwal added a comment - Hi Ajay Kumar , couple of comments: We should retain this comment. It clarifies that these timeouts are not used anywhere on the regular data write path. It may need to be reworded a bit though. - // Since these don't occur during normal operation, we can - // use rather lengthy timeouts, and don't need to make them - // configurable. Extension to Hanisha's comment - you can also query this key using conf.getTimeDuration. That allows specifying time units with readable suffixes like 30s, 1m etc.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 20m 3s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 20s Maven dependency ordering for branch
        +1 mvninstall 13m 24s trunk passed
        +1 compile 15m 10s trunk passed
        +1 checkstyle 2m 9s trunk passed
        +1 mvnsite 2m 8s trunk passed
        +1 findbugs 3m 25s trunk passed
        +1 javadoc 1m 50s trunk passed
              Patch Compile Tests
        0 mvndep 0m 17s Maven dependency ordering for patch
        +1 mvninstall 1m 54s the patch passed
        +1 compile 12m 26s the patch passed
        +1 javac 12m 26s the patch passed
        -0 checkstyle 2m 12s root: The patch generated 4 new + 440 unchanged - 0 fixed = 444 total (was 440)
        +1 mvnsite 2m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 31s the patch passed
        +1 javadoc 1m 38s the patch passed
              Other Tests
        -1 unit 8m 31s hadoop-common in the patch failed.
        -1 unit 96m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 38s The patch does not generate ASF License warnings.
        189m 26s



        Reason Tests
        Failed junit tests hadoop.ha.TestZKFailoverController
          hadoop.net.TestDNS
          hadoop.conf.TestCommonConfigurationFields
          hadoop.security.TestKDiag
          hadoop.hdfs.qjournal.server.TestJournalNodeSync
          hadoop.hdfs.TestLeaseRecoveryStriped
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.tools.TestHdfsConfigFields



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887971/HDFS-12496.01.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux b306153a3834 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 51edaac
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21228/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21228/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 20m 3s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 20s Maven dependency ordering for branch +1 mvninstall 13m 24s trunk passed +1 compile 15m 10s trunk passed +1 checkstyle 2m 9s trunk passed +1 mvnsite 2m 8s trunk passed +1 findbugs 3m 25s trunk passed +1 javadoc 1m 50s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 1m 54s the patch passed +1 compile 12m 26s the patch passed +1 javac 12m 26s the patch passed -0 checkstyle 2m 12s root: The patch generated 4 new + 440 unchanged - 0 fixed = 444 total (was 440) +1 mvnsite 2m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 31s the patch passed +1 javadoc 1m 38s the patch passed       Other Tests -1 unit 8m 31s hadoop-common in the patch failed. -1 unit 96m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 38s The patch does not generate ASF License warnings. 189m 26s Reason Tests Failed junit tests hadoop.ha.TestZKFailoverController   hadoop.net.TestDNS   hadoop.conf.TestCommonConfigurationFields   hadoop.security.TestKDiag   hadoop.hdfs.qjournal.server.TestJournalNodeSync   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.tools.TestHdfsConfigFields Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887971/HDFS-12496.01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux b306153a3834 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 51edaac Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21228/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21228/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21228/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajayydv Ajay Kumar added a comment -

        Harsha Koneru,Arpit Agarwal Thanks for review. Updated patch with suggested changes.

        Show
        ajayydv Ajay Kumar added a comment - Harsha Koneru , Arpit Agarwal Thanks for review. Updated patch with suggested changes.
        Hide
        arpitagarwal Arpit Agarwal added a comment - - edited

        Thanks for the updated patch Ajay Kumar. Couple of additional comments:

        1. The new config key should be in hdfs-default.xml and it should be renamed to something like dfs.qjm.operations.timeout.
        2. Can you please update the description to state that the value accepts suffixes standard units like ns, ms, s and m. And if no unit is specified then the default is milliseconds. Also you can specify the default as 60s or 1m instead of 60000. There are other keys that accept the same suffixes, you can copy this sentence from their description.
          +      Common key to set timeout in milliseconds for related operations in
          +      QuorumJournalManager.
          
        Show
        arpitagarwal Arpit Agarwal added a comment - - edited Thanks for the updated patch Ajay Kumar . Couple of additional comments: The new config key should be in hdfs-default.xml and it should be renamed to something like dfs.qjm.operations.timeout . Can you please update the description to state that the value accepts suffixes standard units like ns, ms, s and m. And if no unit is specified then the default is milliseconds. Also you can specify the default as 60s or 1m instead of 60000. There are other keys that accept the same suffixes, you can copy this sentence from their description. + Common key to set timeout in milliseconds for related operations in + QuorumJournalManager.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for branch
        +1 mvninstall 14m 22s trunk passed
        +1 compile 15m 37s trunk passed
        +1 checkstyle 2m 5s trunk passed
        +1 mvnsite 2m 6s trunk passed
        +1 findbugs 3m 22s trunk passed
        +1 javadoc 1m 45s trunk passed
              Patch Compile Tests
        0 mvndep 0m 16s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 10m 50s the patch passed
        +1 javac 10m 50s the patch passed
        -0 checkstyle 2m 6s root: The patch generated 1 new + 441 unchanged - 0 fixed = 442 total (was 441)
        +1 mvnsite 1m 58s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 29s the patch passed
        +1 javadoc 1m 37s the patch passed
              Other Tests
        -1 unit 8m 3s hadoop-common in the patch failed.
        -1 unit 89m 54s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 33s The patch does not generate ASF License warnings.
        161m 23s



        Reason Tests
        Failed junit tests hadoop.security.TestKDiag
          hadoop.conf.TestCommonConfigurationFields
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.tools.TestHdfsConfigFields
          hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888076/HDFS-12496.02.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
        uname Linux d10ebc49c14d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 7e58b24
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21243/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21243/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 14m 22s trunk passed +1 compile 15m 37s trunk passed +1 checkstyle 2m 5s trunk passed +1 mvnsite 2m 6s trunk passed +1 findbugs 3m 22s trunk passed +1 javadoc 1m 45s trunk passed       Patch Compile Tests 0 mvndep 0m 16s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 10m 50s the patch passed +1 javac 10m 50s the patch passed -0 checkstyle 2m 6s root: The patch generated 1 new + 441 unchanged - 0 fixed = 442 total (was 441) +1 mvnsite 1m 58s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 29s the patch passed +1 javadoc 1m 37s the patch passed       Other Tests -1 unit 8m 3s hadoop-common in the patch failed. -1 unit 89m 54s hadoop-hdfs in the patch failed. +1 asflicense 0m 33s The patch does not generate ASF License warnings. 161m 23s Reason Tests Failed junit tests hadoop.security.TestKDiag   hadoop.conf.TestCommonConfigurationFields   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.tools.TestHdfsConfigFields   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888076/HDFS-12496.02.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux d10ebc49c14d 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 7e58b24 Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21243/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21243/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21243/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajayydv Ajay Kumar added a comment -

        Arpit Agarwal, Thanks for review. Uploaded new patch with changed property name and description in hdfs-default.xml

        Show
        ajayydv Ajay Kumar added a comment - Arpit Agarwal , Thanks for review. Uploaded new patch with changed property name and description in hdfs-default.xml
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 10s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 58s trunk passed
        +1 compile 0m 59s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 1m 9s trunk passed
        +1 findbugs 2m 4s trunk passed
        +1 javadoc 0m 47s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 56s the patch passed
        +1 javac 0m 56s the patch passed
        -0 checkstyle 0m 40s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 440 unchanged - 0 fixed = 441 total (was 440)
        +1 mvnsite 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 43s the patch passed
              Other Tests
        -1 unit 96m 10s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        126m 14s



        Reason Tests
        Failed junit tests hadoop.hdfs.qjournal.client.TestQuorumJournalManager
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.hdfs.server.datanode.TestDirectoryScanner



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888119/HDFS-12496.03.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux dd6167be967e 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a12f09b
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21250/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21250/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21250/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21250/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 58s trunk passed +1 compile 0m 59s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 9s trunk passed +1 findbugs 2m 4s trunk passed +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 1m 1s the patch passed +1 compile 0m 56s the patch passed +1 javac 0m 56s the patch passed -0 checkstyle 0m 40s hadoop-hdfs-project/hadoop-hdfs: The patch generated 1 new + 440 unchanged - 0 fixed = 441 total (was 440) +1 mvnsite 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 43s the patch passed       Other Tests -1 unit 96m 10s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 126m 14s Reason Tests Failed junit tests hadoop.hdfs.qjournal.client.TestQuorumJournalManager   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.hdfs.server.datanode.TestDirectoryScanner Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888119/HDFS-12496.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux dd6167be967e 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21250/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21250/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21250/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21250/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajayydv Ajay Kumar added a comment -

        Arpit Agarwal, Thanks for offline discussion about Unit test. Removing the unit test in patch v4 since it is hard to test reliably without some refactoring and also that QuorumCall testing is covered by other UTs.

        Show
        ajayydv Ajay Kumar added a comment - Arpit Agarwal , Thanks for offline discussion about Unit test. Removing the unit test in patch v4 since it is hard to test reliably without some refactoring and also that QuorumCall testing is covered by other UTs.
        Hide
        ajayydv Ajay Kumar added a comment - - edited

        Changed DFS_QJM_OP_TIMEOUT,DFS_QJM_OP_TIMEOUT_DEFAULT to DFS_QJM_OPERATIONS_TIMEOUT,DFS_QJM_OPERATIONS_TIMEOUT_DEFAULT

        Show
        ajayydv Ajay Kumar added a comment - - edited Changed DFS_QJM_OP_TIMEOUT,DFS_QJM_OP_TIMEOUT_DEFAULT to DFS_QJM_OPERATIONS_TIMEOUT,DFS_QJM_OPERATIONS_TIMEOUT_DEFAULT
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        +1 for the v5 patch, pending Jenkins. Thanks Ajay Kumar.

        Show
        arpitagarwal Arpit Agarwal added a comment - +1 for the v5 patch, pending Jenkins. Thanks Ajay Kumar .
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 51s trunk passed
        +1 compile 0m 59s trunk passed
        +1 checkstyle 0m 44s trunk passed
        +1 mvnsite 1m 8s trunk passed
        +1 findbugs 2m 1s trunk passed
        +1 javadoc 0m 44s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 0s the patch passed
        +1 compile 0m 56s the patch passed
        +1 javac 0m 56s the patch passed
        +1 checkstyle 0m 42s the patch passed
        +1 mvnsite 1m 0s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 1m 51s the patch passed
        +1 javadoc 0m 39s the patch passed
              Other Tests
        -1 unit 89m 35s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        117m 6s



        Reason Tests
        Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeSync
          hadoop.hdfs.server.namenode.TestReencryption



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888141/HDFS-12496.04.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux b2cc3ecaf800 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a12f09b
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21253/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21253/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21253/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 51s trunk passed +1 compile 0m 59s trunk passed +1 checkstyle 0m 44s trunk passed +1 mvnsite 1m 8s trunk passed +1 findbugs 2m 1s trunk passed +1 javadoc 0m 44s trunk passed       Patch Compile Tests +1 mvninstall 1m 0s the patch passed +1 compile 0m 56s the patch passed +1 javac 0m 56s the patch passed +1 checkstyle 0m 42s the patch passed +1 mvnsite 1m 0s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 1m 51s the patch passed +1 javadoc 0m 39s the patch passed       Other Tests -1 unit 89m 35s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 117m 6s Reason Tests Failed junit tests hadoop.hdfs.qjournal.server.TestJournalNodeSync   hadoop.hdfs.server.namenode.TestReencryption Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888141/HDFS-12496.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b2cc3ecaf800 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21253/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21253/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21253/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 16s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 14m 0s trunk passed
        +1 compile 0m 54s trunk passed
        +1 checkstyle 0m 43s trunk passed
        +1 mvnsite 1m 1s trunk passed
        +1 findbugs 1m 53s trunk passed
        +1 javadoc 0m 46s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 1s the patch passed
        +1 compile 1m 0s the patch passed
        +1 javac 1m 0s the patch passed
        -0 checkstyle 0m 42s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 427 unchanged - 0 fixed = 429 total (was 427)
        +1 mvnsite 1m 7s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 2m 9s the patch passed
        +1 javadoc 0m 43s the patch passed
              Other Tests
        -1 unit 194m 28s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 51s The patch does not generate ASF License warnings.
        223m 16s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestReservedRawPaths
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180
          hadoop.hdfs.TestReadStripedFileWithMissingBlocks
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.hdfs.TestHDFSFileSystemContract
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120
          hadoop.hdfs.TestReconstructStripedFile
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
          hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030
          hadoop.hdfs.server.balancer.TestBalancerRPCDelay
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
          hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210
          hadoop.hdfs.server.datanode.TestDirectoryScanner
          hadoop.hdfs.server.datanode.TestDataNodeUUID
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure
          hadoop.hdfs.TestRestartDFS
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040
          hadoop.hdfs.security.TestDelegationTokenForProxyUser
        Timed out junit tests org.apache.hadoop.hdfs.TestFileChecksum
          org.apache.hadoop.hdfs.TestReadStripedFileWithDecodingCorruptData
          org.apache.hadoop.hdfs.TestWriteReadStripedFile
          org.apache.hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888157/HDFS-12496.05.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux e4bf6a2f021f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / a12f09b
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21258/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21258/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21258/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21258/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 16s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 0s trunk passed +1 compile 0m 54s trunk passed +1 checkstyle 0m 43s trunk passed +1 mvnsite 1m 1s trunk passed +1 findbugs 1m 53s trunk passed +1 javadoc 0m 46s trunk passed       Patch Compile Tests +1 mvninstall 1m 1s the patch passed +1 compile 1m 0s the patch passed +1 javac 1m 0s the patch passed -0 checkstyle 0m 42s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 427 unchanged - 0 fixed = 429 total (was 427) +1 mvnsite 1m 7s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 2m 9s the patch passed +1 javadoc 0m 43s the patch passed       Other Tests -1 unit 194m 28s hadoop-hdfs in the patch failed. +1 asflicense 0m 51s The patch does not generate ASF License warnings. 223m 16s Reason Tests Failed junit tests hadoop.hdfs.TestReservedRawPaths   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure180   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure130   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.hdfs.TestHDFSFileSystemContract   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure170   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure200   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure110   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure120   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.server.datanode.TestDataNodeMultipleRegistrations   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure030   hadoop.hdfs.server.balancer.TestBalancerRPCDelay   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure210   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeUUID   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure100   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure   hadoop.hdfs.TestRestartDFS   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure190   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure050   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure000   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure040   hadoop.hdfs.security.TestDelegationTokenForProxyUser Timed out junit tests org.apache.hadoop.hdfs.TestFileChecksum   org.apache.hadoop.hdfs.TestReadStripedFileWithDecodingCorruptData   org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.TestReadStripedFileWithDecodingDeletedData Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888157/HDFS-12496.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux e4bf6a2f021f 3.13.0-129-generic #178-Ubuntu SMP Fri Aug 11 12:48:20 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / a12f09b Default Java 1.8.0_144 findbugs v3.1.0-RC1 checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/21258/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/21258/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21258/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21258/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        ajayydv Ajay Kumar added a comment -

        fixed two checkstyle warnings.

        Show
        ajayydv Ajay Kumar added a comment - fixed two checkstyle warnings.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 9s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 15m 13s trunk passed
        +1 compile 0m 59s trunk passed
        +1 checkstyle 0m 41s trunk passed
        +1 mvnsite 1m 6s trunk passed
        +1 findbugs 1m 57s trunk passed
        +1 javadoc 0m 44s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 57s the patch passed
        +1 javac 0m 57s the patch passed
        +1 checkstyle 0m 40s the patch passed
        +1 mvnsite 1m 3s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 2m 1s the patch passed
        +1 javadoc 0m 43s the patch passed
              Other Tests
        -1 unit 100m 53s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        129m 55s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
          hadoop.hdfs.server.namenode.TestReencryptionWithKMS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12496
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888196/HDFS-12496.06.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux f94da36c389d 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 53047f9
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21263/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21263/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21263/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 9s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 15m 13s trunk passed +1 compile 0m 59s trunk passed +1 checkstyle 0m 41s trunk passed +1 mvnsite 1m 6s trunk passed +1 findbugs 1m 57s trunk passed +1 javadoc 0m 44s trunk passed       Patch Compile Tests +1 mvninstall 1m 1s the patch passed +1 compile 0m 57s the patch passed +1 javac 0m 57s the patch passed +1 checkstyle 0m 40s the patch passed +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 2m 1s the patch passed +1 javadoc 0m 43s the patch passed       Other Tests -1 unit 100m 53s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 129m 55s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.server.namenode.TestReencryptionWithKMS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12496 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12888196/HDFS-12496.06.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f94da36c389d 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 53047f9 Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21263/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21263/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21263/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        arpitagarwal Arpit Agarwal added a comment -

        I've committed this to trunk and branch-2. Thanks for the contribution Ajay Kumar.

        Show
        arpitagarwal Arpit Agarwal added a comment - I've committed this to trunk and branch-2. Thanks for the contribution Ajay Kumar .
        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12937 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12937/)
        HDFS-12496. Make QuorumJournalManager timeout properties configurable. (arp: rev b9e423fa8d30ea89244f6ec018a8064cc87d94a9)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12937 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12937/ ) HDFS-12496 . Make QuorumJournalManager timeout properties configurable. (arp: rev b9e423fa8d30ea89244f6ec018a8064cc87d94a9) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/DFSConfigKeys.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/qjournal/client/QuorumJournalManager.java
        Hide
        ajayydv Ajay Kumar added a comment - - edited

        Arpit Agarwal,Harsha Koneru thanks for review and commit.

        Show
        ajayydv Ajay Kumar added a comment - - edited Arpit Agarwal , Harsha Koneru thanks for review and commit.
        Hide
        andrew.wang Andrew Wang added a comment -

        I've cherry-picked this to branch-3.0 for beta1.

        Show
        andrew.wang Andrew Wang added a comment - I've cherry-picked this to branch-3.0 for beta1.
        Hide
        ajayydv Ajay Kumar added a comment -

        Thanks Andrew Wang

        Show
        ajayydv Ajay Kumar added a comment - Thanks Andrew Wang

          People

          • Assignee:
            ajayydv Ajay Kumar
            Reporter:
            ajayydv Ajay Kumar
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development