Details
-
Type:
Improvement
-
Status: Resolved
-
Priority:
Minor
-
Resolution: Fixed
-
Affects Version/s: None
-
Fix Version/s: 3.0.0-beta1
-
Component/s: erasure-coding
-
Labels:None
-
Hadoop Flags:Reviewed
Activity
- All
- Comments
- Work Log
- History
- Activity
- Transitions
Hide
Huafeng Wang
added a comment -
Permalink
- In MultipleBlockingQueue, the underlying list is immutable so there will be no concurrent modification and lock here is not needed.
- In Coordinator, ConcurrentHashMap will have better performance than Collections.synchronizedMap.
Show
Huafeng Wang
added a comment -
In MultipleBlockingQueue , the underlying list is immutable so there will be no concurrent modification and lock here is not needed.
In Coordinator , ConcurrentHashMap will have better performance than Collections.synchronizedMap .
 -1 overall |
| Vote | Subsystem | Runtime | Comment |
|---|---|---|---|
| 0 | reexec | 0m 14s | Docker mode activated. |
| Prechecks | |||
| +1 | @author | 0m 0s | The patch does not contain any @author tags. |
| -1 | test4tests | 0m 0s | The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. |
| trunk Compile Tests | |||
| +1 | mvninstall | 13m 26s | trunk passed |
| +1 | compile | 0m 40s | trunk passed |
| +1 | checkstyle | 0m 19s | trunk passed |
| +1 | mvnsite | 0m 42s | trunk passed |
| +1 | findbugs | 1m 37s | trunk passed |
| +1 | javadoc | 0m 24s | trunk passed |
| Patch Compile Tests | |||
| +1 | mvninstall | 0m 40s | the patch passed |
| +1 | compile | 0m 36s | the patch passed |
| +1 | javac | 0m 36s | the patch passed |
| +1 | checkstyle | 0m 15s | the patch passed |
| +1 | mvnsite | 0m 39s | the patch passed |
| +1 | whitespace | 0m 0s | The patch has no whitespace issues. |
| +1 | findbugs | 1m 38s | the patch passed |
| +1 | javadoc | 0m 19s | the patch passed |
| Other Tests | |||
| +1 | unit | 1m 12s | hadoop-hdfs-client in the patch passed. |
| +1 | asflicense | 0m 14s | The patch does not generate ASF License warnings. |
| 24m 15s |
| Subsystem | Report/Notes |
|---|---|
| Docker | Image:yetus/hadoop:71bbb86 |
| JIRA Issue | |
| JIRA Patch URL | https://issues.apache.org/jira/secure/attachment/12887627/HDFS-12479.001.patch |
| Optional Tests | asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle |
| uname | Linux 961c4de8df2b 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /testptch/hadoop/patchprocess/precommit/personality/provided.sh |
| git revision | trunk / e81596d |
| Default Java | 1.8.0_144 |
| findbugs | v3.1.0-RC1 |
| Test Results | https://builds.apache.org/job/PreCommit-HDFS-Build/21192/testReport/ |
| modules | C: hadoop-hdfs-project/hadoop-hdfs-client U: hadoop-hdfs-project/hadoop-hdfs-client |
| Console output | https://builds.apache.org/job/PreCommit-HDFS-Build/21192/console |
| Powered by | Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org |
This message was automatically generated.
Hi Kai Zheng, can you help to review this patch? Thanks!
Good catches, Huafeng! The patch LGTM and +1.
Committed to branch-3.0 and trunk. Thanks Huafeng Wang!
FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #12908 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12908/)
HDFS-12479. Some misuses of lock in DFSStripedOutputStream. Contributed (kai.zheng: rev dba7a7dd9d70adfab36a78eb55059c54e553a5cb)
- (edit) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSStripedOutputStream.java