Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12460

Make addErasureCodingPolicy an idempotent operation

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 3.0.0-beta1
    • Component/s: erasure-coding
    • Labels:
      None

      Description

      Make addErasureCodingPolicy an idempotent operation to guarantee after HA switch, addErasureCodingPolicy edit log can be applied smoothly.

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12895/)
        HDFS-12460. Make addErasureCodingPolicy an idempotent operation. (kai.zheng: rev 0f9af246e89e4ad3c4d7ff2c1d7ec9b397494a03)

        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNamenodeRetryCache.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12895 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12895/ ) HDFS-12460 . Make addErasureCodingPolicy an idempotent operation. (kai.zheng: rev 0f9af246e89e4ad3c4d7ff2c1d7ec9b397494a03) (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestErasureCodingPolicies.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestRetryCacheWithHA.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/TestNamenodeRetryCache.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ErasureCodingPolicyManager.java
        Hide
        drankye Kai Zheng added a comment -

        Committed to branch 3.0 and trunk. Thanks SammiChen for the contribution.

        Note this also cleared some test failures introduced by HDFS-12395 by the way.

        Show
        drankye Kai Zheng added a comment - Committed to branch 3.0 and trunk. Thanks SammiChen for the contribution. Note this also cleared some test failures introduced by HDFS-12395 by the way.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 2m 45s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.
              trunk Compile Tests
        +1 mvninstall 15m 41s trunk passed
        +1 compile 0m 57s trunk passed
        +1 checkstyle 0m 49s trunk passed
        +1 mvnsite 1m 11s trunk passed
        +1 findbugs 1m 58s trunk passed
        +1 javadoc 0m 45s trunk passed
              Patch Compile Tests
        +1 mvninstall 1m 1s the patch passed
        +1 compile 0m 59s the patch passed
        +1 javac 0m 59s the patch passed
        +1 checkstyle 0m 38s the patch passed
        +1 mvnsite 1m 1s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 2m 7s the patch passed
        +1 javadoc 0m 42s the patch passed
              Other Tests
        -1 unit 101m 3s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        133m 22s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.TestDecommission
          hadoop.hdfs.TestLeaseRecoveryStriped
          hadoop.hdfs.TestFileCorruption
          hadoop.hdfs.server.namenode.ha.TestHAAppend
          hadoop.hdfs.TestReconstructStripedFile
          hadoop.hdfs.TestLease
        Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile
          org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:71bbb86
        JIRA Issue HDFS-12460
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887284/HDFS-12460.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 846dd094b3c3 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / ef8cd5d
        Default Java 1.8.0_144
        findbugs v3.1.0-RC1
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/21180/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21180/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21180/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 2m 45s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 3 new or modified test files.       trunk Compile Tests +1 mvninstall 15m 41s trunk passed +1 compile 0m 57s trunk passed +1 checkstyle 0m 49s trunk passed +1 mvnsite 1m 11s trunk passed +1 findbugs 1m 58s trunk passed +1 javadoc 0m 45s trunk passed       Patch Compile Tests +1 mvninstall 1m 1s the patch passed +1 compile 0m 59s the patch passed +1 javac 0m 59s the patch passed +1 checkstyle 0m 38s the patch passed +1 mvnsite 1m 1s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 42s the patch passed       Other Tests -1 unit 101m 3s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 133m 22s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.TestDecommission   hadoop.hdfs.TestLeaseRecoveryStriped   hadoop.hdfs.TestFileCorruption   hadoop.hdfs.server.namenode.ha.TestHAAppend   hadoop.hdfs.TestReconstructStripedFile   hadoop.hdfs.TestLease Timed out junit tests org.apache.hadoop.hdfs.TestWriteReadStripedFile   org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12460 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12887284/HDFS-12460.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 846dd094b3c3 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ef8cd5d Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21180/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21180/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21180/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Sammi for this. The patch LGTM. +1 pending on Jenkins.

        Show
        drankye Kai Zheng added a comment - Thanks Sammi for this. The patch LGTM. +1 pending on Jenkins.
        Hide
        Sammi SammiChen added a comment -

        Initial patch.

        Show
        Sammi SammiChen added a comment - Initial patch.

          People

          • Assignee:
            Sammi SammiChen
            Reporter:
            Sammi SammiChen
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development