Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12424

Datatable sorting on the Datanode Information page in the Namenode UI is broken

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 2.8.1
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.3, 3.1.0
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Hadoop Flags:
      Reviewed

      Description

      Attempting to sort the "In operation" table by Last contact, Capacity, Blocks, or Version can result in unexpected behavior. Sorting by Blocks and Version actually sort by entirely different columns, and Last contact and Capacity are not being sorted numerically but rather alphabetically.

      1. HDFS-12424.1.patch
        1 kB
        Kihwal Lee
      2. HDFS-12424.1.patch
        1 kB
        Shawna Martell
      3. HDFS-12424-branch-2.8.1.patch
        1 kB
        Shawna Martell

        Issue Links

          Activity

          Hide
          daryn Daryn Sharp added a comment -

          Quasi +1. I really don't understand the JS magic but it looks straightforward. All I know is sorting has been completely broken ever since it was added to the new ui. I clicked around on a test NN and certainly seems to work.

          Any other web experts want to review? Otherwise I'll commit in a few days.

          Show
          daryn Daryn Sharp added a comment - Quasi +1. I really don't understand the JS magic but it looks straightforward. All I know is sorting has been completely broken ever since it was added to the new ui. I clicked around on a test NN and certainly seems to work. Any other web experts want to review? Otherwise I'll commit in a few days.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 docker 11m 1s Docker failed to build yetus/hadoop:5af2af1.



          Subsystem Report/Notes
          JIRA Issue HDFS-12424
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886702/HDFS-12424-branch-2.8.1.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21105/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 docker 11m 1s Docker failed to build yetus/hadoop:5af2af1. Subsystem Report/Notes JIRA Issue HDFS-12424 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886702/HDFS-12424-branch-2.8.1.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21105/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          kihwal Kihwal Lee added a comment - - edited

          Reattaching the patch to kick the trunk precommit build. Unfortunately the 2.8 patch naming caused to build branch-2.8.1, which still tried to download jdk7 from Oracle. It should be named to not match other existing branch unintentionally. In any case, the build does not build or test the UI change.

          Show
          kihwal Kihwal Lee added a comment - - edited Reattaching the patch to kick the trunk precommit build. Unfortunately the 2.8 patch naming caused to build branch-2.8.1, which still tried to download jdk7 from Oracle. It should be named to not match other existing branch unintentionally. In any case, the build does not build or test the UI change.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 21m 20s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
                trunk Compile Tests
                Patch Compile Tests
          +1 whitespace 0m 0s The patch has no whitespace issues.
                Other Tests
          +1 asflicense 0m 13s The patch does not generate ASF License warnings.
          21m 47s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:71bbb86
          JIRA Issue HDFS-12424
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886896/HDFS-12424.1.patch
          Optional Tests asflicense
          uname Linux c5c18fc0d3e8 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / fa6cc43
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21122/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 21m 20s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags.       trunk Compile Tests       Patch Compile Tests +1 whitespace 0m 0s The patch has no whitespace issues.       Other Tests +1 asflicense 0m 13s The patch does not generate ASF License warnings. 21m 47s Subsystem Report/Notes Docker Image:yetus/hadoop:71bbb86 JIRA Issue HDFS-12424 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12886896/HDFS-12424.1.patch Optional Tests asflicense uname Linux c5c18fc0d3e8 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / fa6cc43 modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21122/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajayydv Ajay Kumar added a comment -

          LGTM.

          Show
          ajayydv Ajay Kumar added a comment - LGTM.
          Hide
          kihwal Kihwal Lee added a comment -

          +1

          Show
          kihwal Kihwal Lee added a comment - +1
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12882/)
          HDFS-12424. Datatable sorting on the Datanode Information page in the (kihwal: rev 78bdf10ae40300a5f2f3b95491d280802edc1df2)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12882 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12882/ ) HDFS-12424 . Datatable sorting on the Datanode Information page in the (kihwal: rev 78bdf10ae40300a5f2f3b95491d280802edc1df2) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/webapps/hdfs/dfshealth.js
          Hide
          kihwal Kihwal Lee added a comment -

          Thanks for fixing this, Shawna Martell. I've committed this to trunk, branch-3.0, branch-2 and branch-2.8.

          Show
          kihwal Kihwal Lee added a comment - Thanks for fixing this, Shawna Martell . I've committed this to trunk, branch-3.0, branch-2 and branch-2.8.

            People

            • Assignee:
              shawnam Shawna Martell
              Reporter:
              shawnam Shawna Martell
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development