[HDFS-12336] Listing encryption zones still fails when deleted EZ is not a direct child of snapshottable directory

• Type: Bug
• Status: Resolved
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: 3.0.0-alpha4
• Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.3
• Component/s: encryption, hdfs
• Hadoop Flags: Reviewed
• Assignee: Wellington Chevreuil
• Reporter: Wellington Chevreuil
• Created: 22/Aug/17 07:32
• Updated: 30/Aug/17 11:44
• Resolved: 30/Aug/17 11:44

Description

The fix proposed on HDFS-11197 didn't cover the scenario where the EZ deleted but still under a snapshot is not a direct child of the snapshottable directory.

Here the code snippet proposed on HDFS-11197 that would avoid the error reported by hdfs crypto -listZones when a deleted EZ is still under a given snapshot:

      INode lastINode = null;
      if (inode.getParent() != null || inode.isRoot()) {
        INodesInPath iip = dir.getINodesInPath(pathName, DirOp.READ_LINK);
        lastINode = iip.getLastINode();
      }
      if (lastINode == null || lastINode.getId() != ezi.getINodeId()) {
        continue;
      }

It will ignore EZs when it's a direct child of a snapshot, because its parent inode will be null, and it isn't the root inode. However, if the EZ is not directly under snapshottable directory, its parent will not be null, and it will pass this check, so it will fail further due absolute path required validation error.

I would like to work on a fix that would also cover this scenario.

Issue Links

• relates to: HDFS-11197 Listing encryption zones fails when deleting a EZ that is on a snapshotted directory