[HDFS-12255] Block Storage: Cblock should generated unique trace ID for the ops

• Type: Sub-task
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: HDFS-7240
• Fix Version/s: HDFS-7240
• Component/s: ozone
• Target Version/s: HDFS-7240
• Assignee: Mukul Kumar Singh
• Reporter: Mukul Kumar Singh
• Created: 03/Aug/17 11:04
• Updated: 26/Apr/18 21:53
• Resolved: 15/Aug/17 18:06

Description

Cblock tests fails because cblock does not generate unique trace id for each op.

java.lang.AssertionError: expected:<0> but was:<1051>
	at org.junit.Assert.fail(Assert.java:88)
	at org.junit.Assert.failNotEquals(Assert.java:743)
	at org.junit.Assert.assertEquals(Assert.java:118)
	at org.junit.Assert.assertEquals(Assert.java:555)
	at org.junit.Assert.assertEquals(Assert.java:542)
	at org.apache.hadoop.cblock.TestBufferManager.testRepeatedBlockWrites(TestBufferManager.java:448)

This failure is because of following error.

017-08-02 17:50:34,569 [Cache Block Writer Thread #4] ERROR scm.XceiverClientHandler (XceiverClientHandler.java:sendCommandAsync(134)) - Command with Trace already exists. Ignoring this command. . Previous Command: java.util.concurrent.CompletableFuture@7847fc2d[Not completed, 1 dependents]
2017-08-02 17:50:34,569 [Cache Block Writer Thread #4] ERROR jscsiHelper.ContainerCacheFlusher (BlockWriterTask.java:run(108)) - Writing of block:44 failed, We have attempted to write this block 7 tim
es to the container container2483304118.Trace ID:
java.lang.IllegalStateException: Duplicate trace ID. Command with this trace ID is already executing. Please ensure that trace IDs are not reused. ID: 
        at org.apache.hadoop.scm.XceiverClientHandler.sendCommandAsync(XceiverClientHandler.java:139)
        at org.apache.hadoop.scm.XceiverClientHandler.sendCommand(XceiverClientHandler.java:114)
        at org.apache.hadoop.scm.XceiverClient.sendCommand(XceiverClient.java:132)
        at org.apache.hadoop.scm.storage.ContainerProtocolCalls.writeSmallFile(ContainerProtocolCalls.java:225)
        at org.apache.hadoop.cblock.jscsiHelper.BlockWriterTask.run(BlockWriterTask.java:97)
        at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
        at java.util.concurrent.FutureTask.run(FutureTask.java:266)
        at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)
        at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)
        at java.lang.Thread.run(Thread.java:745)

Issue Links

• duplicates: HDFS-11744 Ozone: Implement the trace ID generator