Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12250

Reduce usage of FsPermissionExtension in unit tests

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Minor
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1
    • Component/s: test
    • Labels:
      None

      Description

      HDFS-6984 deprecated FsPermissionExtension, moving the flags to FileStatus. This generated a large number of deprecation warnings, particularly in unit tests.

      1. HDFS-12250.000.patch
        17 kB
        Chris Douglas
      2. HDFS-12250.001.patch
        16 kB
        Chris Douglas
      3. HDFS-12250.002.patch
        16 kB
        Chris Douglas

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #12204 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12204/)
          HDFS-12250. Reduce usage of FsPermissionExtension in unit tests. (wang: rev dd7916d3cd5d880d0b257d229f43f10feff04c93)

          • (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/TestGetFileStatus.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSAclBaseTest.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListingFileStatus.java
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/filecache/ClientDistributedCacheManager.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CommandWithDestination.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java
          • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/AclCommands.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
          • (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java
          Show
          hudson Hudson added a comment - ABORTED: Integrated in Jenkins build Hadoop-trunk-Commit #12204 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12204/ ) HDFS-12250 . Reduce usage of FsPermissionExtension in unit tests. (wang: rev dd7916d3cd5d880d0b257d229f43f10feff04c93) (edit) hadoop-tools/hadoop-azure-datalake/src/test/java/org/apache/hadoop/fs/adl/TestGetFileStatus.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/permission/FsPermission.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/client/BaseTestHttpFSWith.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/FSAclBaseTest.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/CopyListingFileStatus.java (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapreduce/filecache/ClientDistributedCacheManager.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/CommandWithDestination.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Ls.java (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/AclCommands.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java (edit) hadoop-tools/hadoop-distcp/src/main/java/org/apache/hadoop/tools/util/DistCpUtils.java
          Hide
          andrew.wang Andrew Wang added a comment -

          Committed to trunk, thank you for the contribution!

          Show
          andrew.wang Andrew Wang added a comment - Committed to trunk, thank you for the contribution!
          Hide
          andrew.wang Andrew Wang added a comment -

          LGTM +1 thanks Chris!

          Show
          andrew.wang Andrew Wang added a comment - LGTM +1 thanks Chris!
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 30s Maven dependency ordering for branch
          +1 mvninstall 16m 27s trunk passed
          +1 compile 13m 49s trunk passed
          +1 checkstyle 2m 5s trunk passed
          +1 mvnsite 5m 14s trunk passed
          -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 3m 4s trunk passed
                Patch Compile Tests
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 2m 42s the patch passed
          +1 compile 10m 26s the patch passed
          +1 javac 10m 26s root generated 0 new + 1357 unchanged - 20 fixed = 1357 total (was 1377)
          +1 checkstyle 2m 5s the patch passed
          +1 mvnsite 5m 11s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 6m 25s the patch passed
          +1 javadoc 3m 3s the patch passed
                Other Tests
          +1 unit 7m 38s hadoop-common in the patch passed.
          -1 unit 65m 50s hadoop-hdfs in the patch failed.
          +1 unit 3m 33s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 2m 46s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 13m 57s hadoop-distcp in the patch passed.
          +1 unit 3m 37s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          177m 42s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12250
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880961/HDFS-12250.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b9bc16788566 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 07694fc
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20613/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20613/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20613/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-distcp hadoop-tools/hadoop-azure-datalake U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20613/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 1m 30s Maven dependency ordering for branch +1 mvninstall 16m 27s trunk passed +1 compile 13m 49s trunk passed +1 checkstyle 2m 5s trunk passed +1 mvnsite 5m 14s trunk passed -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 4s trunk passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 2m 42s the patch passed +1 compile 10m 26s the patch passed +1 javac 10m 26s root generated 0 new + 1357 unchanged - 20 fixed = 1357 total (was 1377) +1 checkstyle 2m 5s the patch passed +1 mvnsite 5m 11s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 6m 25s the patch passed +1 javadoc 3m 3s the patch passed       Other Tests +1 unit 7m 38s hadoop-common in the patch passed. -1 unit 65m 50s hadoop-hdfs in the patch failed. +1 unit 3m 33s hadoop-hdfs-httpfs in the patch passed. +1 unit 2m 46s hadoop-mapreduce-client-core in the patch passed. +1 unit 13m 57s hadoop-distcp in the patch passed. +1 unit 3m 37s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 177m 42s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12250 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880961/HDFS-12250.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b9bc16788566 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 07694fc Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20613/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20613/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20613/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-distcp hadoop-tools/hadoop-azure-datalake U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20613/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 18s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for branch
          +1 mvninstall 14m 16s trunk passed
          +1 compile 14m 43s trunk passed
          +1 checkstyle 2m 19s trunk passed
          +1 mvnsite 5m 21s trunk passed
          -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 3m 8s trunk passed
                Patch Compile Tests
          0 mvndep 0m 18s Maven dependency ordering for patch
          +1 mvninstall 3m 11s the patch passed
          +1 compile 12m 51s the patch passed
          +1 javac 12m 51s root generated 0 new + 1357 unchanged - 20 fixed = 1357 total (was 1377)
          -0 checkstyle 2m 20s root: The patch generated 2 new + 630 unchanged - 0 fixed = 632 total (was 630)
          +1 mvnsite 5m 46s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 7m 7s the patch passed
          +1 javadoc 3m 57s the patch passed
                Other Tests
          +1 unit 8m 31s hadoop-common in the patch passed.
          -1 unit 71m 7s hadoop-hdfs in the patch failed.
          +1 unit 3m 36s hadoop-hdfs-httpfs in the patch passed.
          +1 unit 2m 47s hadoop-mapreduce-client-core in the patch passed.
          +1 unit 13m 42s hadoop-distcp in the patch passed.
          +1 unit 3m 37s hadoop-azure-datalake in the patch passed.
          +1 asflicense 0m 30s The patch does not generate ASF License warnings.
          187m 36s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12250
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880923/HDFS-12250.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux b55f91e41612 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / f4e1aa0
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20604/testReport/
          modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-distcp hadoop-tools/hadoop-azure-datalake U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20604/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 18s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 4 new or modified test files.       trunk Compile Tests 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 14m 16s trunk passed +1 compile 14m 43s trunk passed +1 checkstyle 2m 19s trunk passed +1 mvnsite 5m 21s trunk passed -1 findbugs 1m 50s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 8s trunk passed       Patch Compile Tests 0 mvndep 0m 18s Maven dependency ordering for patch +1 mvninstall 3m 11s the patch passed +1 compile 12m 51s the patch passed +1 javac 12m 51s root generated 0 new + 1357 unchanged - 20 fixed = 1357 total (was 1377) -0 checkstyle 2m 20s root: The patch generated 2 new + 630 unchanged - 0 fixed = 632 total (was 630) +1 mvnsite 5m 46s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 7m 7s the patch passed +1 javadoc 3m 57s the patch passed       Other Tests +1 unit 8m 31s hadoop-common in the patch passed. -1 unit 71m 7s hadoop-hdfs in the patch failed. +1 unit 3m 36s hadoop-hdfs-httpfs in the patch passed. +1 unit 2m 47s hadoop-mapreduce-client-core in the patch passed. +1 unit 13m 42s hadoop-distcp in the patch passed. +1 unit 3m 37s hadoop-azure-datalake in the patch passed. +1 asflicense 0m 30s The patch does not generate ASF License warnings. 187m 36s Reason Tests Failed junit tests hadoop.hdfs.server.namenode.web.resources.TestWebHdfsDataLocality   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12250 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880923/HDFS-12250.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux b55f91e41612 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / f4e1aa0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20604/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20604/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs hadoop-hdfs-project/hadoop-hdfs-httpfs hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core hadoop-tools/hadoop-distcp hadoop-tools/hadoop-azure-datalake U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20604/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          chris.douglas Chris Douglas added a comment -

          Rebased after HADOOP-14730

          Show
          chris.douglas Chris Douglas added a comment - Rebased after HADOOP-14730

            People

            • Assignee:
              chris.douglas Chris Douglas
              Reporter:
              chris.douglas Chris Douglas
            • Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development