XmlEditsVisitor should use new XML capability in the newer JDK, to make JAR shading easier (HADOOP-14672)
Shaded Hadoop-client-minicluster include unshaded classes, like: javax, sax, dom, etc.
Lei (Eddy) Xu I am planning to work on this. Could you plz elaborate on what new XML capability you are referring to. Do we want to just replace OutputFormat and XMLSerializer from xcerces with jdk inbuilt classes?
Hi, Ajay Kumar thanks a lot for picking this up. You are right that it'd be great to replace OutputFormat / XMLSerializer with JDK 8+ builtins
Lei (Eddy) Xu Thanks for confirming. Attaching the patch and output of fsimage and edit logs after the changes. Please review.
Can we drop the xerces dependency after this change?
Andrew Wang I checked for references within hdfs and other projects but can't find one. I agree, we shall remove it as dependency if its not used anywhere else.
Lei (Eddy) Xu,Andrew Wang If we agree on removing xerces dependency then i can update the patch with changes in pom files.
Please do! Thanks Ajay.
This message was automatically generated.
Andrew Wang, Lei (Eddy) Xu Updated the patch with changes in pom file as well. Plz review.
Ajay Kumar Thanks for the patch. Please rebase your branch and fix conflicts with trunk.
Also is this a duplicated line?
Aaron Lei Uploaded the patch again after fixing the conflicts. " <runningWithNative>$
</runningWithNative>" is not there in new patch. Please review.
i checked the findbugs, yarn and mapreduce errors. They seems unrelated to patch.
Andrew Wang, Lei (Eddy) Xu Added updated binary file to resolve the HDFS test which is failing. (i.e TestOfflineEditsViewer#testStored). Please test the patch with updated binary file "editsStored"
Hi, Ajay Kumar
Thanks for working this. It LGTM.
Hi Lei (Eddy) Xu, without that we get <EDITS> tag in first line along with xml declaration tag.
<?xml version="1.0" encoding="UTF-8" standalone="yes"?><EDITS>
Thanks Ajay Kumar, +1 and committed to trunk.
SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12177 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12177/)
HDFS-12221. Replace xcerces in XmlEditsVisitor. (Ajay Kumar via lei) (lei: rev ce797a170669524224cfeaaf70647047e7626816)
Andrew Wang,Lei (Eddy) Xu thanks for review and commit.