Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1
    • Component/s: None
    • Labels:
      None
    • Target Version/s:
    • Release Note:
      New patch with changes in maven dependency. (removed apache xcerces as dependency)

      Description

      XmlEditsVisitor should use new XML capability in the newer JDK, to make JAR shading easier (HADOOP-14672)

      1. editsStored
        6 kB
        Ajay Kumar
      2. fsimage_hdfs-12221.xml
        1 kB
        Ajay Kumar
      3. HDFS-12221.01.patch
        3 kB
        Ajay Kumar
      4. HDFS-12221.02.patch
        12 kB
        Ajay Kumar
      5. HDFS-12221.03.patch
        12 kB
        Ajay Kumar
      6. HDFS-12221.04.patch
        18 kB
        Ajay Kumar
      7. HDFS-12221.05.patch
        19 kB
        Ajay Kumar

        Issue Links

          Activity

          Hide
          ajayydv Ajay Kumar added a comment -

          Lei (Eddy) Xu I am planning to work on this. Could you plz elaborate on what new XML capability you are referring to. Do we want to just replace OutputFormat and XMLSerializer from xcerces with jdk inbuilt classes?

          Show
          ajayydv Ajay Kumar added a comment - Lei (Eddy) Xu I am planning to work on this. Could you plz elaborate on what new XML capability you are referring to. Do we want to just replace OutputFormat and XMLSerializer from xcerces with jdk inbuilt classes?
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Ajay Kumar thanks a lot for picking this up. You are right that it'd be great to replace OutputFormat / XMLSerializer with JDK 8+ builtins

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Ajay Kumar thanks a lot for picking this up. You are right that it'd be great to replace OutputFormat / XMLSerializer with JDK 8+ builtins
          Hide
          ajayydv Ajay Kumar added a comment -

          Lei (Eddy) Xu Thanks for confirming. Attaching the patch and output of fsimage and edit logs after the changes. Please review.

          Show
          ajayydv Ajay Kumar added a comment - Lei (Eddy) Xu Thanks for confirming. Attaching the patch and output of fsimage and edit logs after the changes. Please review.
          Hide
          andrew.wang Andrew Wang added a comment -

          Can we drop the xerces dependency after this change?

          Show
          andrew.wang Andrew Wang added a comment - Can we drop the xerces dependency after this change?
          Hide
          ajayydv Ajay Kumar added a comment - - edited

          Andrew Wang I checked for references within hdfs and other projects but can't find one. I agree, we shall remove it as dependency if its not used anywhere else.

          Show
          ajayydv Ajay Kumar added a comment - - edited Andrew Wang I checked for references within hdfs and other projects but can't find one. I agree, we shall remove it as dependency if its not used anywhere else.
          Hide
          ajayydv Ajay Kumar added a comment -

          Lei (Eddy) Xu,Andrew Wang If we agree on removing xerces dependency then i can update the patch with changes in pom files.

          Show
          ajayydv Ajay Kumar added a comment - Lei (Eddy) Xu , Andrew Wang If we agree on removing xerces dependency then i can update the patch with changes in pom files.
          Hide
          andrew.wang Andrew Wang added a comment -

          Please do! Thanks Ajay.

          Show
          andrew.wang Andrew Wang added a comment - Please do! Thanks Ajay.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 4s HDFS-12221 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-12221
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880277/edits_hdfs-12221.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20547/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 4s HDFS-12221 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-12221 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880277/edits_hdfs-12221.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20547/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajayydv Ajay Kumar added a comment -

          Andrew Wang, Lei (Eddy) Xu Updated the patch with changes in pom file as well. Plz review.

          Show
          ajayydv Ajay Kumar added a comment - Andrew Wang , Lei (Eddy) Xu Updated the patch with changes in pom file as well. Plz review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 0s Docker mode activated.
          -1 patch 0m 5s HDFS-12221 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



          Subsystem Report/Notes
          JIRA Issue HDFS-12221
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880507/HDFS-12221.02.patch
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20568/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 5s HDFS-12221 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-12221 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880507/HDFS-12221.02.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20568/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Ajay Kumar Thanks for the patch. Please rebase your branch and fix conflicts with trunk.

          Also is this a duplicated line?

                      <runningWithNative>${runningWithNative}</runningWithNative>
          
          Show
          eddyxu Lei (Eddy) Xu added a comment - Ajay Kumar Thanks for the patch. Please rebase your branch and fix conflicts with trunk. Also is this a duplicated line? <runningWithNative>${runningWithNative}</runningWithNative>
          Hide
          ajayydv Ajay Kumar added a comment -

          Aaron Lei Uploaded the patch again after fixing the conflicts. " <runningWithNative>$

          {runningWithNative}

          </runningWithNative>" is not there in new patch. Please review.

          Show
          ajayydv Ajay Kumar added a comment - Aaron Lei Uploaded the patch again after fixing the conflicts. " <runningWithNative>$ {runningWithNative} </runningWithNative>" is not there in new patch. Please review.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          0 mvndep 0m 16s Maven dependency ordering for branch
          +1 mvninstall 14m 8s trunk passed
          +1 compile 14m 37s trunk passed
          +1 checkstyle 1m 58s trunk passed
          +1 mvnsite 7m 21s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 4m 14s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 11m 6s the patch passed
          +1 compile 13m 20s the patch passed
          +1 javac 13m 20s root generated 0 new + 1373 unchanged - 6 fixed = 1373 total (was 1379)
          -0 checkstyle 2m 29s root: The patch generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7)
          +1 mvnsite 6m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 9s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          +1 findbugs 1m 49s the patch passed
          +1 javadoc 3m 53s the patch passed
                Other Tests
          +1 unit 0m 10s hadoop-project in the patch passed.
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          -1 unit 64m 24s hadoop-hdfs in the patch failed.
          -1 unit 70m 8s hadoop-yarn in the patch failed.
          -1 unit 20m 47s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 22s hadoop-client-runtime in the patch passed.
          +1 unit 0m 23s hadoop-client-minicluster in the patch passed.
          +1 asflicense 0m 31s The patch does not generate ASF License warnings.
          242m 38s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
            hadoop.mapreduce.v2.app.TestRuntimeEstimators



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12221
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880719/HDFS-12221.03.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux e83e3dc0a944 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / bc20680
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/diff-checkstyle-root.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20585/testReport/
          modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20585/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests 0 mvndep 0m 16s Maven dependency ordering for branch +1 mvninstall 14m 8s trunk passed +1 compile 14m 37s trunk passed +1 checkstyle 1m 58s trunk passed +1 mvnsite 7m 21s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster -1 findbugs 1m 52s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 4m 14s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 11m 6s the patch passed +1 compile 13m 20s the patch passed +1 javac 13m 20s root generated 0 new + 1373 unchanged - 6 fixed = 1373 total (was 1379) -0 checkstyle 2m 29s root: The patch generated 5 new + 7 unchanged - 0 fixed = 12 total (was 7) +1 mvnsite 6m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 9s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster +1 findbugs 1m 49s the patch passed +1 javadoc 3m 53s the patch passed       Other Tests +1 unit 0m 10s hadoop-project in the patch passed. +1 unit 0m 9s hadoop-project-dist in the patch passed. -1 unit 64m 24s hadoop-hdfs in the patch failed. -1 unit 70m 8s hadoop-yarn in the patch failed. -1 unit 20m 47s hadoop-mapreduce-client in the patch failed. +1 unit 0m 22s hadoop-client-runtime in the patch passed. +1 unit 0m 23s hadoop-client-minicluster in the patch passed. +1 asflicense 0m 31s The patch does not generate ASF License warnings. 242m 38s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.yarn.server.resourcemanager.security.TestDelegationTokenRenewer   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities   hadoop.mapreduce.v2.app.TestRuntimeEstimators Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12221 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880719/HDFS-12221.03.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux e83e3dc0a944 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / bc20680 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20585/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20585/testReport/ modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20585/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          0 mvndep 0m 15s Maven dependency ordering for branch
          +1 mvninstall 15m 6s trunk passed
          +1 compile 14m 3s trunk passed
          +1 checkstyle 1m 56s trunk passed
          +1 mvnsite 6m 29s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 3m 52s trunk passed
                Patch Compile Tests
          0 mvndep 0m 15s Maven dependency ordering for patch
          +1 mvninstall 10m 4s the patch passed
          +1 compile 10m 43s the patch passed
          +1 javac 10m 43s root generated 0 new + 1371 unchanged - 6 fixed = 1371 total (was 1377)
          +1 checkstyle 2m 0s the patch passed
          +1 mvnsite 7m 17s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 12s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          +1 findbugs 1m 59s the patch passed
          +1 javadoc 4m 12s the patch passed
                Other Tests
          +1 unit 0m 9s hadoop-project in the patch passed.
          +1 unit 0m 9s hadoop-project-dist in the patch passed.
          -1 unit 70m 42s hadoop-hdfs in the patch failed.
          -1 unit 76m 2s hadoop-yarn in the patch failed.
          -1 unit 23m 3s hadoop-mapreduce-client in the patch failed.
          +1 unit 0m 52s hadoop-client-runtime in the patch passed.
          +1 unit 0m 43s hadoop-client-minicluster in the patch passed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          253m 42s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010
            hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
            hadoop.yarn.server.TestContainerManagerSecurity
            hadoop.mapreduce.v2.app.TestRuntimeEstimators



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12221
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880892/HDFS-12221.04.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle
          uname Linux a72ac16158a9 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 1794de3
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20602/testReport/
          modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20602/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests 0 mvndep 0m 15s Maven dependency ordering for branch +1 mvninstall 15m 6s trunk passed +1 compile 14m 3s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 6m 29s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 3m 52s trunk passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 10m 4s the patch passed +1 compile 10m 43s the patch passed +1 javac 10m 43s root generated 0 new + 1371 unchanged - 6 fixed = 1371 total (was 1377) +1 checkstyle 2m 0s the patch passed +1 mvnsite 7m 17s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 12s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster +1 findbugs 1m 59s the patch passed +1 javadoc 4m 12s the patch passed       Other Tests +1 unit 0m 9s hadoop-project in the patch passed. +1 unit 0m 9s hadoop-project-dist in the patch passed. -1 unit 70m 42s hadoop-hdfs in the patch failed. -1 unit 76m 2s hadoop-yarn in the patch failed. -1 unit 23m 3s hadoop-mapreduce-client in the patch failed. +1 unit 0m 52s hadoop-client-runtime in the patch passed. +1 unit 0m 43s hadoop-client-minicluster in the patch passed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 253m 42s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure010   hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps   hadoop.yarn.server.TestContainerManagerSecurity   hadoop.mapreduce.v2.app.TestRuntimeEstimators Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12221 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880892/HDFS-12221.04.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle uname Linux a72ac16158a9 3.13.0-117-generic #164-Ubuntu SMP Fri Apr 7 11:05:26 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 1794de3 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20602/artifact/patchprocess/patch-unit-hadoop-mapreduce-project_hadoop-mapreduce-client.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20602/testReport/ modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20602/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajayydv Ajay Kumar added a comment - - edited

          i checked the findbugs, yarn and mapreduce errors. They seems unrelated to patch.

          Show
          ajayydv Ajay Kumar added a comment - - edited i checked the findbugs, yarn and mapreduce errors. They seems unrelated to patch.
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
                trunk Compile Tests
          0 mvndep 1m 27s Maven dependency ordering for branch
          +1 mvninstall 13m 56s trunk passed
          +1 compile 13m 57s trunk passed
          +1 checkstyle 2m 8s trunk passed
          +1 mvnsite 7m 35s trunk passed
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          -1 findbugs 1m 59s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
          +1 javadoc 4m 46s trunk passed
                Patch Compile Tests
          0 mvndep 0m 17s Maven dependency ordering for patch
          +1 mvninstall 11m 22s the patch passed
          +1 compile 12m 7s the patch passed
          +1 javac 12m 7s root generated 0 new + 1371 unchanged - 6 fixed = 1371 total (was 1377)
          +1 checkstyle 2m 7s the patch passed
          +1 mvnsite 7m 13s the patch passed
          +1 shellcheck 0m 0s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 9s The patch has no ill-formed XML file.
          0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster
          +1 findbugs 1m 50s the patch passed
          +1 javadoc 4m 11s the patch passed
                Other Tests
          +1 unit 0m 12s hadoop-project in the patch passed.
          +1 unit 0m 11s hadoop-project-dist in the patch passed.
          -1 unit 73m 15s hadoop-hdfs in the patch failed.
          -1 unit 70m 23s hadoop-yarn in the patch failed.
          +1 unit 123m 5s hadoop-mapreduce-client in the patch passed.
          +1 unit 0m 37s hadoop-client-runtime in the patch passed.
          +1 unit 0m 38s hadoop-client-minicluster in the patch passed.
          +1 asflicense 0m 48s The patch does not generate ASF License warnings.
          355m 51s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
            hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer
            hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps
            hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities
          Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12221
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880956/HDFS-12221.05.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle shellcheck shelldocs
          uname Linux dc60c94435ed 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / ebabc70
          Default Java 1.8.0_131
          shellcheck v0.4.6
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20612/testReport/
          modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: .
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20612/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 1m 27s Maven dependency ordering for branch +1 mvninstall 13m 56s trunk passed +1 compile 13m 57s trunk passed +1 checkstyle 2m 8s trunk passed +1 mvnsite 7m 35s trunk passed 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster -1 findbugs 1m 59s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 4m 46s trunk passed       Patch Compile Tests 0 mvndep 0m 17s Maven dependency ordering for patch +1 mvninstall 11m 22s the patch passed +1 compile 12m 7s the patch passed +1 javac 12m 7s root generated 0 new + 1371 unchanged - 6 fixed = 1371 total (was 1377) +1 checkstyle 2m 7s the patch passed +1 mvnsite 7m 13s the patch passed +1 shellcheck 0m 0s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 9s The patch has no ill-formed XML file. 0 findbugs 0m 0s Skipped patched modules with no Java source: hadoop-project hadoop-project-dist hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster +1 findbugs 1m 50s the patch passed +1 javadoc 4m 11s the patch passed       Other Tests +1 unit 0m 12s hadoop-project in the patch passed. +1 unit 0m 11s hadoop-project-dist in the patch passed. -1 unit 73m 15s hadoop-hdfs in the patch failed. -1 unit 70m 23s hadoop-yarn in the patch failed. +1 unit 123m 5s hadoop-mapreduce-client in the patch passed. +1 unit 0m 37s hadoop-client-runtime in the patch passed. +1 unit 0m 38s hadoop-client-minicluster in the patch passed. +1 asflicense 0m 48s The patch does not generate ASF License warnings. 355m 51s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.tools.offlineEditsViewer.TestOfflineEditsViewer   hadoop.yarn.server.nodemanager.containermanager.logaggregation.TestLogAggregationService   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageApps   hadoop.yarn.server.timelineservice.storage.TestHBaseTimelineStorageEntities Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12221 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880956/HDFS-12221.05.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit xml findbugs checkstyle shellcheck shelldocs uname Linux dc60c94435ed 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / ebabc70 Default Java 1.8.0_131 shellcheck v0.4.6 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20612/artifact/patchprocess/patch-unit-hadoop-yarn-project_hadoop-yarn.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20612/testReport/ modules C: hadoop-project hadoop-project-dist hadoop-hdfs-project/hadoop-hdfs hadoop-yarn-project/hadoop-yarn hadoop-mapreduce-project/hadoop-mapreduce-client hadoop-client-modules/hadoop-client-runtime hadoop-client-modules/hadoop-client-minicluster U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20612/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          ajayydv Ajay Kumar added a comment -

          Andrew Wang, Lei (Eddy) Xu Added updated binary file to resolve the HDFS test which is failing. (i.e TestOfflineEditsViewer#testStored). Please test the patch with updated binary file "editsStored"

          Show
          ajayydv Ajay Kumar added a comment - Andrew Wang , Lei (Eddy) Xu Added updated binary file to resolve the HDFS test which is failing. (i.e TestOfflineEditsViewer#testStored). Please test the patch with updated binary file "editsStored"
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Hi, Ajay Kumar

          Thanks for working this. It LGTM.

          One nit:

          • Is handler.getTransformer().setOutputProperty(OutputKeys.STANDALONE, "yes"); necessary?

          +1 pending.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Hi, Ajay Kumar Thanks for working this. It LGTM. One nit: Is handler.getTransformer().setOutputProperty(OutputKeys.STANDALONE, "yes"); necessary? +1 pending.
          Hide
          ajayydv Ajay Kumar added a comment -

          Hi Lei (Eddy) Xu, without that we get <EDITS> tag in first line along with xml declaration tag.

          <?xml version="1.0" encoding="UTF-8" standalone="yes"?><EDITS>
          
          Show
          ajayydv Ajay Kumar added a comment - Hi Lei (Eddy) Xu , without that we get <EDITS> tag in first line along with xml declaration tag. <?xml version= "1.0" encoding= "UTF-8" standalone= "yes" ?> <EDITS>
          Hide
          eddyxu Lei (Eddy) Xu added a comment -

          Thanks Ajay Kumar, +1 and committed to trunk.

          Show
          eddyxu Lei (Eddy) Xu added a comment - Thanks Ajay Kumar , +1 and committed to trunk.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12177 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12177/)
          HDFS-12221. Replace xcerces in XmlEditsVisitor. (Ajay Kumar via lei) (lei: rev ce797a170669524224cfeaaf70647047e7626816)

          • (edit) hadoop-yarn-project/hadoop-yarn/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored
          • (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml
          • (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml
          • (edit) hadoop-project-dist/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java
          • (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml
          • (edit) hadoop-project/pom.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored.xml
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12177 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12177/ ) HDFS-12221 . Replace xcerces in XmlEditsVisitor. (Ajay Kumar via lei) (lei: rev ce797a170669524224cfeaaf70647047e7626816) (edit) hadoop-yarn-project/hadoop-yarn/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored (edit) hadoop-client-modules/hadoop-client-runtime/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/pom.xml (edit) hadoop-mapreduce-project/hadoop-mapreduce-client/pom.xml (edit) hadoop-project-dist/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/offlineEditsViewer/XmlEditsVisitor.java (edit) hadoop-client-modules/hadoop-client-minicluster/pom.xml (edit) hadoop-project/pom.xml (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/resources/editsStored.xml
          Hide
          ajayydv Ajay Kumar added a comment -

          Andrew Wang,Lei (Eddy) Xu thanks for review and commit.

          Show
          ajayydv Ajay Kumar added a comment - Andrew Wang , Lei (Eddy) Xu thanks for review and commit.

            People

            • Assignee:
              ajayydv Ajay Kumar
              Reporter:
              eddyxu Lei (Eddy) Xu
            • Votes:
              0 Vote for this issue
              Watchers:
              9 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development