Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12212

Options.Rename.To_TRASH is considered even when Options.Rename.NONE is specified

Details

    • Bug
    • Status: Resolved
    • Major
    • Resolution: Fixed
    • 2.9.0, 2.7.4, 3.0.0-alpha1, 2.8.2
    • 3.3.0, 3.2.1, 3.1.3
    • namenode
    • None
    • Reviewed

    Description

      HDFS-8312 introduced Options.Rename.TO_TRASH to differentiate the movement to trash and other renames for permission checks.

      When Options.Rename.NONE is passed also TO_TRASH is considered for rename and wrong permissions are checked for rename.

      Attachments

        1. HDFS-12212-01.patch
          0.9 kB
          Vinayakumar B

        Activity

          vinayakumarb Vinayakumar B added a comment -

          attached a simple 1-line fix.

          vinayakumarb Vinayakumar B added a comment - attached a simple 1-line fix.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 10s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 14m 20s trunk passed
          +1 compile 0m 52s trunk passed
          +1 checkstyle 0m 37s trunk passed
          +1 mvnsite 0m 57s trunk passed
          -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 46s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 59s the patch passed
          +1 compile 0m 54s the patch passed
          +1 javac 0m 54s the patch passed
          +1 checkstyle 0m 36s the patch passed
          +1 mvnsite 0m 57s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 1m 52s the patch passed
          +1 javadoc 0m 42s the patch passed
                Other Tests
          -1 unit 73m 27s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          100m 39s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12212
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux f485569cd601 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 369f731
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20464/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20464/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20464/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20464/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 10s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 20s trunk passed +1 compile 0m 52s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 57s trunk passed -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 46s trunk passed       Patch Compile Tests +1 mvninstall 0m 59s the patch passed +1 compile 0m 54s the patch passed +1 javac 0m 54s the patch passed +1 checkstyle 0m 36s the patch passed +1 mvnsite 0m 57s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 52s the patch passed +1 javadoc 0m 42s the patch passed       Other Tests -1 unit 73m 27s hadoop-hdfs in the patch failed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 100m 39s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12212 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux f485569cd601 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 369f731 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20464/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20464/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20464/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20464/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          hanishakoneru Hanisha Koneru added a comment -

          Thanks for the fix vinayrpet.
          LGTM. +1 (non-binding).

          hanishakoneru Hanisha Koneru added a comment - Thanks for the fix vinayrpet . LGTM. +1 (non-binding).
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 17s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 18m 57s trunk passed
          +1 compile 1m 8s trunk passed
          +1 checkstyle 0m 47s trunk passed
          +1 mvnsite 1m 16s trunk passed
          +1 shadedclient 12m 4s branch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 19s trunk passed
          +1 javadoc 1m 5s trunk passed
                Patch Compile Tests
          +1 mvninstall 1m 17s the patch passed
          +1 compile 1m 9s the patch passed
          +1 javac 1m 9s the patch passed
          +1 checkstyle 0m 46s the patch passed
          +1 mvnsite 1m 15s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 11m 43s patch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 43s the patch passed
          +1 javadoc 1m 4s the patch passed
                Other Tests
          -1 unit 131m 7s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          189m 6s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy
            hadoop.hdfs.TestReadStripedFileWithMissingBlocks
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.TestEncryptionZones
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure
            hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean
          Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150
            org.apache.hadoop.hdfs.TestDFSPermission
            org.apache.hadoop.hdfs.TestRestartDFS
            org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060
            org.apache.hadoop.hdfs.TestReplaceDatanodeFailureReplication
            org.apache.hadoop.cli.TestHDFSCLI



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:3d04c00
          JIRA Issue HDFS-12212
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux 2940c9f4ecf9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 8acdf5c
          Default Java 1.8.0_144
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/21652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21652/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21652/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 18m 57s trunk passed +1 compile 1m 8s trunk passed +1 checkstyle 0m 47s trunk passed +1 mvnsite 1m 16s trunk passed +1 shadedclient 12m 4s branch has no errors when building and testing our client artifacts. +1 findbugs 2m 19s trunk passed +1 javadoc 1m 5s trunk passed       Patch Compile Tests +1 mvninstall 1m 17s the patch passed +1 compile 1m 9s the patch passed +1 javac 1m 9s the patch passed +1 checkstyle 0m 46s the patch passed +1 mvnsite 1m 15s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 11m 43s patch has no errors when building and testing our client artifacts. +1 findbugs 2m 43s the patch passed +1 javadoc 1m 4s the patch passed       Other Tests -1 unit 131m 7s hadoop-hdfs in the patch failed. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 189m 6s Reason Tests Failed junit tests hadoop.hdfs.TestSafeModeWithStripedFileWithRandomECPolicy   hadoop.hdfs.TestReadStripedFileWithMissingBlocks   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.TestEncryptionZones   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure   hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Timed out junit tests org.apache.hadoop.hdfs.TestLeaseRecovery2   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure160   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150   org.apache.hadoop.hdfs.TestDFSPermission   org.apache.hadoop.hdfs.TestRestartDFS   org.apache.hadoop.hdfs.TestDFSStripedOutputStreamWithFailure060   org.apache.hadoop.hdfs.TestReplaceDatanodeFailureReplication   org.apache.hadoop.cli.TestHDFSCLI Subsystem Report/Notes Docker Image:yetus/hadoop:3d04c00 JIRA Issue HDFS-12212 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux 2940c9f4ecf9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 8acdf5c Default Java 1.8.0_144 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/21652/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/21652/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/21652/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          Updated Affects versions based on HDFS-8312's affects versions.

          weichiu Wei-Chiu Chuang added a comment - Updated Affects versions based on HDFS-8312 's affects versions.

          Hi vinayrpet thanks for the patch.
          The fix itself looks to me. Would you also like to contribute a test as well?

          weichiu Wei-Chiu Chuang added a comment - Hi vinayrpet thanks for the patch. The fix itself looks to me. Would you also like to contribute a test as well?
          ayushtkn Ayush Saxena added a comment -

          Thanx vinayakumarb for the report. The fix seems straightforward.
          Have triggered the build again. If everything seems steady, will push this ahead.

          ayushtkn Ayush Saxena added a comment - Thanx vinayakumarb for the report. The fix seems straightforward. Have triggered the build again. If everything seems steady, will push this ahead.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 35s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 17m 23s trunk passed
          +1 compile 1m 2s trunk passed
          +1 checkstyle 0m 46s trunk passed
          +1 mvnsite 1m 4s trunk passed
          +1 shadedclient 12m 42s branch has no errors when building and testing our client artifacts.
          +1 findbugs 1m 55s trunk passed
          +1 javadoc 0m 51s trunk passed
                Patch Compile Tests
          +1 mvninstall 1m 2s the patch passed
          +1 compile 0m 56s the patch passed
          +1 javac 0m 56s the patch passed
          +1 checkstyle 0m 37s the patch passed
          +1 mvnsite 1m 3s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 shadedclient 11m 48s patch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 8s the patch passed
          +1 javadoc 0m 52s the patch passed
                Other Tests
          -1 unit 100m 59s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 36s The patch does not generate ASF License warnings.
          156m 22s



          Reason Tests
          Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
            hadoop.hdfs.TestFileChecksumCompositeCrc
            hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.cli.TestHDFSCLI
            hadoop.hdfs.TestEncryptedTransfer
            hadoop.hdfs.TestMaintenanceState
            hadoop.hdfs.TestBlockStoragePolicy
            hadoop.hdfs.TestBlockTokenWrappingQOP
            hadoop.hdfs.TestFileLengthOnClusterRestart



          Subsystem Report/Notes
          Docker Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4
          JIRA Issue HDFS-12212
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch
          Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux d2636458eb04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / 872cdf4
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_222
          findbugs v3.1.0-RC1
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/27713/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/27713/testReport/
          Max. process+thread count 3804 (vs. ulimit of 5500)
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/27713/console
          Powered by Apache Yetus 0.8.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 35s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 17m 23s trunk passed +1 compile 1m 2s trunk passed +1 checkstyle 0m 46s trunk passed +1 mvnsite 1m 4s trunk passed +1 shadedclient 12m 42s branch has no errors when building and testing our client artifacts. +1 findbugs 1m 55s trunk passed +1 javadoc 0m 51s trunk passed       Patch Compile Tests +1 mvninstall 1m 2s the patch passed +1 compile 0m 56s the patch passed +1 javac 0m 56s the patch passed +1 checkstyle 0m 37s the patch passed +1 mvnsite 1m 3s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 shadedclient 11m 48s patch has no errors when building and testing our client artifacts. +1 findbugs 2m 8s the patch passed +1 javadoc 0m 52s the patch passed       Other Tests -1 unit 100m 59s hadoop-hdfs in the patch failed. +1 asflicense 0m 36s The patch does not generate ASF License warnings. 156m 22s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestFileChecksumCompositeCrc   hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.cli.TestHDFSCLI   hadoop.hdfs.TestEncryptedTransfer   hadoop.hdfs.TestMaintenanceState   hadoop.hdfs.TestBlockStoragePolicy   hadoop.hdfs.TestBlockTokenWrappingQOP   hadoop.hdfs.TestFileLengthOnClusterRestart Subsystem Report/Notes Docker Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 JIRA Issue HDFS-12212 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux d2636458eb04 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 872cdf4 maven version: Apache Maven 3.3.9 Default Java 1.8.0_222 findbugs v3.1.0-RC1 unit https://builds.apache.org/job/PreCommit-HDFS-Build/27713/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/27713/testReport/ Max. process+thread count 3804 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/27713/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 46s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 20m 45s trunk passed
          +1 compile 1m 4s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 15s trunk passed
          +1 shadedclient 14m 20s branch has no errors when building and testing our client artifacts.
          +1 findbugs 2m 9s trunk passed
          +1 javadoc 0m 56s trunk passed
                Patch Compile Tests
          +1 mvninstall 1m 11s the patch passed
          +1 compile 1m 6s the patch passed
          +1 javac 1m 6s the patch passed
          +1 checkstyle 0m 46s the patch passed
          -1 mvnsite 0m 9s hadoop-hdfs in the patch failed.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          -1 shadedclient 0m 29s patch has errors when building and testing our client artifacts.
          +1 findbugs 2m 32s the patch passed
          +1 javadoc 0m 51s the patch passed
                Other Tests
          -1 unit 92m 52s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 34s The patch does not generate ASF License warnings.
          142m 31s



          Reason Tests
          Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController
            hadoop.hdfs.TestDistributedFileSystem



          Subsystem Report/Notes
          Docker Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4
          JIRA Issue HDFS-12212
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch
          Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle
          uname Linux b5ba9721eb2b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/patchprocess/precommit/personality/provided.sh
          git revision trunk / 371c9eb
          maven version: Apache Maven 3.3.9
          Default Java 1.8.0_222
          findbugs v3.1.0-RC1
          mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/27716/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/27716/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/27716/testReport/
          Max. process+thread count 4058 (vs. ulimit of 5500)
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/27716/console
          Powered by Apache Yetus 0.8.0 http://yetus.apache.org

          This message was automatically generated.

          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 46s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 20m 45s trunk passed +1 compile 1m 4s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 15s trunk passed +1 shadedclient 14m 20s branch has no errors when building and testing our client artifacts. +1 findbugs 2m 9s trunk passed +1 javadoc 0m 56s trunk passed       Patch Compile Tests +1 mvninstall 1m 11s the patch passed +1 compile 1m 6s the patch passed +1 javac 1m 6s the patch passed +1 checkstyle 0m 46s the patch passed -1 mvnsite 0m 9s hadoop-hdfs in the patch failed. +1 whitespace 0m 0s The patch has no whitespace issues. -1 shadedclient 0m 29s patch has errors when building and testing our client artifacts. +1 findbugs 2m 32s the patch passed +1 javadoc 0m 51s the patch passed       Other Tests -1 unit 92m 52s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 142m 31s Reason Tests Failed junit tests hadoop.hdfs.tools.TestDFSZKFailoverController   hadoop.hdfs.TestDistributedFileSystem Subsystem Report/Notes Docker Client=19.03.1 Server=19.03.1 Image:yetus/hadoop:bdbca0e53b4 JIRA Issue HDFS-12212 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879333/HDFS-12212-01.patch Optional Tests dupname asflicense compile javac javadoc mvninstall mvnsite unit shadedclient findbugs checkstyle uname Linux b5ba9721eb2b 4.15.0-58-generic #64-Ubuntu SMP Tue Aug 6 11:12:41 UTC 2019 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/patchprocess/precommit/personality/provided.sh git revision trunk / 371c9eb maven version: Apache Maven 3.3.9 Default Java 1.8.0_222 findbugs v3.1.0-RC1 mvnsite https://builds.apache.org/job/PreCommit-HDFS-Build/27716/artifact/out/patch-mvnsite-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/27716/artifact/out/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/27716/testReport/ Max. process+thread count 4058 (vs. ulimit of 5500) modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/27716/console Powered by Apache Yetus 0.8.0 http://yetus.apache.org This message was automatically generated.
          ayushtkn Ayush Saxena added a comment -

          The warnings seems unrelated, Due to unable to create native thread.
          v01 LGTM +1,
          if no objections will commit by EOD.

          ayushtkn Ayush Saxena added a comment - The warnings seems unrelated, Due to unable to create native thread. v01 LGTM +1, if no objections will commit by EOD.
          ayushtkn Ayush Saxena added a comment -

          Committed to trunk, branch-3.2 and branch-3.1
          Thanx vinayakumarb for the contribution!!!

          ayushtkn Ayush Saxena added a comment - Committed to trunk, branch-3.2 and branch-3.1 Thanx vinayakumarb for the contribution!!!
          hudson Hudson added a comment -

          FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17202 (See https://builds.apache.org/job/Hadoop-trunk-Commit/17202/)
          HDFS-12212. Options.Rename.To_TRASH is considered even when (ayushsaxena: rev e220dac15cc9972ebdd54ea9c82f288f234fca51)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          hudson Hudson added a comment - FAILURE: Integrated in Jenkins build Hadoop-trunk-Commit #17202 (See https://builds.apache.org/job/Hadoop-trunk-Commit/17202/ ) HDFS-12212 . Options.Rename.To_TRASH is considered even when (ayushsaxena: rev e220dac15cc9972ebdd54ea9c82f288f234fca51) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/ClientNamenodeProtocolServerSideTranslatorPB.java
          vinayakumarb Vinayakumar B added a comment - - edited

          thanks ayushtkn for review and commit.

          hanishakoneru  and weichiu for reviews.

          vinayakumarb Vinayakumar B added a comment - - edited thanks ayushtkn  for review and commit. hanishakoneru   and weichiu  for reviews.

          People

            vinayakumarb Vinayakumar B
            vinayakumarb Vinayakumar B
            Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: