Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12190

Enable 'hdfs dfs -stat' to display access time

    Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1
    • Component/s: hdfs, shell
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      "hdfs dfs -stat" currently only can show modification time of a file but not access time. Sometimes it's useful to show access time.

      1. HDFS-12190.001.patch
        6 kB
        Yongjun Zhang
      2. HDFS-12190.002.patch
        6 kB
        Yongjun Zhang
      3. HDFS-12190.003.patch
        6 kB
        Yongjun Zhang
      4. HDFS-12190.004.patch
        9 kB
        Yongjun Zhang
      5. HDFS-12190.005.patch
        9 kB
        Yongjun Zhang

        Activity

        Hide
        hudson Hudson added a comment -

        SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12063 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12063/)
        HDFS-12190. Enable 'hdfs dfs -stat' to display access time. Contributed (yzhang: rev c6330f22a5e5c2370bab885f9bea4bf8f5e9cf44)

        • (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md
        • (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Stat.java
        • (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java
        • (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Show
        hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12063 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12063/ ) HDFS-12190 . Enable 'hdfs dfs -stat' to display access time. Contributed (yzhang: rev c6330f22a5e5c2370bab885f9bea4bf8f5e9cf44) (edit) hadoop-common-project/hadoop-common/src/site/markdown/FileSystemShell.md (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/shell/Stat.java (edit) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestDFSShell.java (edit) hadoop-common-project/hadoop-common/src/test/resources/testConf.xml
        Hide
        yzhangal Yongjun Zhang added a comment -

        Committed to trunk and branch-2. Thanks Wei-Chiu Chuang again for the review!

        Show
        yzhangal Yongjun Zhang added a comment - Committed to trunk and branch-2. Thanks Wei-Chiu Chuang again for the review!
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Wei-Chiu Chuang for the review, the failed tests are not related. Will commit shortly.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Wei-Chiu Chuang for the review, the failed tests are not related. Will commit shortly.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 19s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 18s Maven dependency ordering for branch
        +1 mvninstall 13m 25s trunk passed
        +1 compile 15m 12s trunk passed
        +1 checkstyle 2m 4s trunk passed
        +1 mvnsite 2m 45s trunk passed
        -1 findbugs 2m 15s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 47s trunk passed
              Patch Compile Tests
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 37s the patch passed
        +1 compile 12m 3s the patch passed
        +1 javac 12m 3s the patch passed
        -0 checkstyle 2m 5s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201)
        +1 mvnsite 2m 47s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 56s the patch passed
        +1 javadoc 1m 43s the patch passed
              Other Tests
        +1 unit 9m 27s hadoop-common in the patch passed.
        -1 unit 88m 55s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 34s The patch does not generate ASF License warnings.
        164m 34s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879238/HDFS-12190.005.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux d3ce0a567b9f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 5f4808c
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20443/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20443/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 19s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 0m 18s Maven dependency ordering for branch +1 mvninstall 13m 25s trunk passed +1 compile 15m 12s trunk passed +1 checkstyle 2m 4s trunk passed +1 mvnsite 2m 45s trunk passed -1 findbugs 2m 15s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 47s trunk passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 37s the patch passed +1 compile 12m 3s the patch passed +1 javac 12m 3s the patch passed -0 checkstyle 2m 5s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201) +1 mvnsite 2m 47s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 56s the patch passed +1 javadoc 1m 43s the patch passed       Other Tests +1 unit 9m 27s hadoop-common in the patch passed. -1 unit 88m 55s hadoop-hdfs in the patch failed. +1 asflicense 0m 34s The patch does not generate ASF License warnings. 164m 34s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879238/HDFS-12190.005.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux d3ce0a567b9f 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5f4808c Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20443/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20443/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20443/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        LGTM +1 pending Jenkins. Thanks!

        Show
        jojochuang Wei-Chiu Chuang added a comment - LGTM +1 pending Jenkins. Thanks!
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Wei-Chiu Chuang, good suggestion again. updated patch.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks Wei-Chiu Chuang , good suggestion again. updated patch.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Checkstyle warning can be ignored due to existing indentation.

        I think the test is good, but it shouldn't need to sleep before getting t1 and t2. How about setting t1 = Time.now() + 3000 and t2 = Time.now() + 6000? This way the test can complete faster.

        Thanks.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Checkstyle warning can be ignored due to existing indentation. I think the test is good, but it shouldn't need to sleep before getting t1 and t2. How about setting t1 = Time.now() + 3000 and t2 = Time.now() + 6000? This way the test can complete faster. Thanks.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 59s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 13m 14s trunk passed
        +1 compile 13m 39s trunk passed
        +1 checkstyle 1m 56s trunk passed
        +1 mvnsite 2m 27s trunk passed
        -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 38s trunk passed
              Patch Compile Tests
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 10m 13s the patch passed
        +1 javac 10m 13s the patch passed
        -0 checkstyle 1m 58s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201)
        +1 mvnsite 2m 25s the patch passed
        -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 23s the patch passed
        +1 javadoc 1m 37s the patch passed
              Other Tests
        -1 unit 8m 5s hadoop-common in the patch failed.
        -1 unit 65m 35s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 37s The patch does not generate ASF License warnings.
        134m 5s



        Reason Tests
        Failed junit tests hadoop.fs.shell.TestCopyFromLocal
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879192/HDFS-12190.004.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux b3d63dd98d55 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 27a1a5f
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/diff-checkstyle-root.txt
        whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/whitespace-eol.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20435/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20435/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 59s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 14s trunk passed +1 compile 13m 39s trunk passed +1 checkstyle 1m 56s trunk passed +1 mvnsite 2m 27s trunk passed -1 findbugs 1m 46s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 38s trunk passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 10m 13s the patch passed +1 javac 10m 13s the patch passed -0 checkstyle 1m 58s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201) +1 mvnsite 2m 25s the patch passed -1 whitespace 0m 0s The patch has 1 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 23s the patch passed +1 javadoc 1m 37s the patch passed       Other Tests -1 unit 8m 5s hadoop-common in the patch failed. -1 unit 65m 35s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 134m 5s Reason Tests Failed junit tests hadoop.fs.shell.TestCopyFromLocal   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure140   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailure Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879192/HDFS-12190.004.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux b3d63dd98d55 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27a1a5f Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/diff-checkstyle-root.txt whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20435/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20435/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20435/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks much Wei-Chiu Chuang, very good suggestion! rev4 to address that.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks much Wei-Chiu Chuang , very good suggestion! rev4 to address that.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 26s Maven dependency ordering for branch
        +1 mvninstall 13m 16s trunk passed
        -1 compile 5m 55s root in trunk failed.
        +1 checkstyle 1m 56s trunk passed
        +1 mvnsite 2m 27s trunk passed
        -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 35s trunk passed
              Patch Compile Tests
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 28s the patch passed
        +1 compile 13m 8s the patch passed
        -1 javac 13m 8s root generated 553 new + 760 unchanged - 0 fixed = 1313 total (was 760)
        -0 checkstyle 1m 56s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201)
        +1 mvnsite 2m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 2s The patch has no ill-formed XML file.
        +1 findbugs 3m 26s the patch passed
        +1 javadoc 1m 35s the patch passed
              Other Tests
        -1 unit 8m 4s hadoop-common in the patch failed.
        -1 unit 66m 1s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 37s The patch does not generate ASF License warnings.
        130m 6s



        Reason Tests
        Failed junit tests hadoop.net.TestDNS
          hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879111/HDFS-12190.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux f024a42dace9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 27a1a5f
        Default Java 1.8.0_131
        compile https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/branch-compile-root.txt
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        javac https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/diff-compile-javac-root.txt
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20430/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20430/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 1m 26s Maven dependency ordering for branch +1 mvninstall 13m 16s trunk passed -1 compile 5m 55s root in trunk failed. +1 checkstyle 1m 56s trunk passed +1 mvnsite 2m 27s trunk passed -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 35s trunk passed       Patch Compile Tests 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 28s the patch passed +1 compile 13m 8s the patch passed -1 javac 13m 8s root generated 553 new + 760 unchanged - 0 fixed = 1313 total (was 760) -0 checkstyle 1m 56s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201) +1 mvnsite 2m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 2s The patch has no ill-formed XML file. +1 findbugs 3m 26s the patch passed +1 javadoc 1m 35s the patch passed       Other Tests -1 unit 8m 4s hadoop-common in the patch failed. -1 unit 66m 1s hadoop-hdfs in the patch failed. +1 asflicense 0m 37s The patch does not generate ASF License warnings. 130m 6s Reason Tests Failed junit tests hadoop.net.TestDNS   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879111/HDFS-12190.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux f024a42dace9 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27a1a5f Default Java 1.8.0_131 compile https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/branch-compile-root.txt findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html javac https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/diff-compile-javac-root.txt checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20430/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20430/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20430/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Yongjun Zhang the code looks mostly good to me.
        Could you also verify the output of atime in the test?
        For example,

        final String atime1 = fmt.format(new Date(status1.getAccessTime()));
        ...
        assertTrue(out.toString(), out.toString().contains(atime1));
        
        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Yongjun Zhang the code looks mostly good to me. Could you also verify the output of atime in the test? For example, final String atime1 = fmt.format( new Date(status1.getAccessTime())); ... assertTrue(out.toString(), out.toString().contains(atime1));
        Hide
        yzhangal Yongjun Zhang added a comment -

        rev3 to take care of a missed place in last rev.

        Show
        yzhangal Yongjun Zhang added a comment - rev3 to take care of a missed place in last rev.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        0 mvndep 0m 14s Maven dependency ordering for branch
        +1 mvninstall 13m 26s trunk passed
        +1 compile 13m 40s trunk passed
        +1 checkstyle 1m 55s trunk passed
        +1 mvnsite 2m 29s trunk passed
        -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 36s trunk passed
              Patch Compile Tests
        0 mvndep 0m 15s Maven dependency ordering for patch
        +1 mvninstall 1m 27s the patch passed
        +1 compile 10m 16s the patch passed
        +1 javac 10m 16s the patch passed
        -0 checkstyle 1m 55s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201)
        +1 mvnsite 2m 27s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 24s the patch passed
        +1 javadoc 1m 35s the patch passed
              Other Tests
        -1 unit 8m 2s hadoop-common in the patch failed.
        -1 unit 64m 50s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 39s The patch does not generate ASF License warnings.
        132m 46s



        Reason Tests
        Failed junit tests hadoop.cli.TestCLI
          hadoop.security.TestRaceWhenRelogin
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879095/HDFS-12190.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux ab18033ea17b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 27a1a5f
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20426/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20426/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 0m 14s Maven dependency ordering for branch +1 mvninstall 13m 26s trunk passed +1 compile 13m 40s trunk passed +1 checkstyle 1m 55s trunk passed +1 mvnsite 2m 29s trunk passed -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 36s trunk passed       Patch Compile Tests 0 mvndep 0m 15s Maven dependency ordering for patch +1 mvninstall 1m 27s the patch passed +1 compile 10m 16s the patch passed +1 javac 10m 16s the patch passed -0 checkstyle 1m 55s root: The patch generated 10 new + 198 unchanged - 3 fixed = 208 total (was 201) +1 mvnsite 2m 27s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 24s the patch passed +1 javadoc 1m 35s the patch passed       Other Tests -1 unit 8m 2s hadoop-common in the patch failed. -1 unit 64m 50s hadoop-hdfs in the patch failed. +1 asflicense 0m 39s The patch does not generate ASF License warnings. 132m 46s Reason Tests Failed junit tests hadoop.cli.TestCLI   hadoop.security.TestRaceWhenRelogin   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879095/HDFS-12190.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux ab18033ea17b 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 27a1a5f Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/patch-unit-hadoop-common-project_hadoop-common.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20426/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20426/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20426/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 0s Docker mode activated.
        -1 patch 0m 6s HDFS-12190 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help.



        Subsystem Report/Notes
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879085/HDFS-12190.002.patch
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20425/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 0s Docker mode activated. -1 patch 0m 6s HDFS-12190 does not apply to trunk. Rebase required? Wrong Branch? See https://wiki.apache.org/hadoop/HowToContribute for help. Subsystem Report/Notes JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879085/HDFS-12190.002.patch Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20425/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks a lot Wei-Chiu Chuang, very good point! Just uploaded 002 to address this comment. Would you please take a look? Thanks.

        Show
        yzhangal Yongjun Zhang added a comment - Thanks a lot Wei-Chiu Chuang , very good point! Just uploaded 002 to address this comment. Would you please take a look? Thanks.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Hi Yongjun Zhang thanks for the patch.
        I am +1 for the proposal, but would like add extra comment:

        The Linux state command uses %X and %x for access time. How about we use %X and %x in Hadoop to make it more familiar with Linux administrators? Thanks.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Hi Yongjun Zhang thanks for the patch. I am +1 for the proposal, but would like add extra comment: The Linux state command uses %X and %x for access time. How about we use %X and %x in Hadoop to make it more familiar with Linux administrators? Thanks.
        Hide
        vagarychen Chen Liang added a comment -

        Thanks Yongjun Zhang for the check, I probably put some wrong git argument when applying the patch earlier. the v001 patch LGTM.

        Show
        vagarychen Chen Liang added a comment - Thanks Yongjun Zhang for the check, I probably put some wrong git argument when applying the patch earlier. the v001 patch LGTM.
        Hide
        yzhangal Yongjun Zhang added a comment -

        Thanks Chen Liang, I tried it and it's still applicable at

        commit a68b5b31cf846c0fc94c430bafd07a9bca369234
        Author: Kihwal Lee <kihwal@apache.org>
        Date:   Tue Jul 25 11:03:09 2017 -0500
        
        Show
        yzhangal Yongjun Zhang added a comment - Thanks Chen Liang , I tried it and it's still applicable at commit a68b5b31cf846c0fc94c430bafd07a9bca369234 Author: Kihwal Lee <kihwal@apache.org> Date: Tue Jul 25 11:03:09 2017 -0500
        Hide
        vagarychen Chen Liang added a comment -

        Looks like v001 patch needs to be rebased.

        Show
        vagarychen Chen Liang added a comment - Looks like v001 patch needs to be rebased.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 13s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.
              trunk Compile Tests
        0 mvndep 1m 25s Maven dependency ordering for branch
        -1 mvninstall 14m 59s root in trunk failed.
        +1 compile 14m 2s trunk passed
        +1 checkstyle 1m 57s trunk passed
        +1 mvnsite 2m 26s trunk passed
        -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 1m 36s trunk passed
              Patch Compile Tests
        0 mvndep 0m 14s Maven dependency ordering for patch
        +1 mvninstall 1m 26s the patch passed
        +1 compile 10m 10s the patch passed
        +1 javac 10m 10s the patch passed
        -0 checkstyle 1m 54s root: The patch generated 9 new + 199 unchanged - 2 fixed = 208 total (was 201)
        +1 mvnsite 2m 25s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 xml 0m 1s The patch has no ill-formed XML file.
        +1 findbugs 3m 25s the patch passed
        +1 javadoc 1m 36s the patch passed
              Other Tests
        +1 unit 8m 28s hadoop-common in the patch passed.
        -1 unit 65m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 40s The patch does not generate ASF License warnings.
        136m 50s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks
          hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
          hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics
          hadoop.hdfs.server.namenode.ha.TestPipelinesFailover
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12190
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878454/HDFS-12190.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml
        uname Linux a0db36731684 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 465c213
        Default Java 1.8.0_131
        mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/branch-mvninstall-root.txt
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/diff-checkstyle-root.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20387/testReport/
        modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: .
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20387/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 2 new or modified test files.       trunk Compile Tests 0 mvndep 1m 25s Maven dependency ordering for branch -1 mvninstall 14m 59s root in trunk failed. +1 compile 14m 2s trunk passed +1 checkstyle 1m 57s trunk passed +1 mvnsite 2m 26s trunk passed -1 findbugs 1m 45s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 1m 36s trunk passed       Patch Compile Tests 0 mvndep 0m 14s Maven dependency ordering for patch +1 mvninstall 1m 26s the patch passed +1 compile 10m 10s the patch passed +1 javac 10m 10s the patch passed -0 checkstyle 1m 54s root: The patch generated 9 new + 199 unchanged - 2 fixed = 208 total (was 201) +1 mvnsite 2m 25s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 3m 25s the patch passed +1 javadoc 1m 36s the patch passed       Other Tests +1 unit 8m 28s hadoop-common in the patch passed. -1 unit 65m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 40s The patch does not generate ASF License warnings. 136m 50s Reason Tests Failed junit tests hadoop.hdfs.server.blockmanagement.TestUnderReplicatedBlocks   hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.namenode.metrics.TestNameNodeMetrics   hadoop.hdfs.server.namenode.ha.TestPipelinesFailover   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure150 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12190 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878454/HDFS-12190.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle xml uname Linux a0db36731684 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 465c213 Default Java 1.8.0_131 mvninstall https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/branch-mvninstall-root.txt findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/diff-checkstyle-root.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20387/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20387/testReport/ modules C: hadoop-common-project/hadoop-common hadoop-hdfs-project/hadoop-hdfs U: . Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20387/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.

          People

          • Assignee:
            yzhangal Yongjun Zhang
            Reporter:
            yzhangal Yongjun Zhang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development