Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12157

Do fsyncDirectory(..) outside of FSDataset lock

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Critical
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 2.9.0, 3.0.0-beta1, 2.8.2, 2.7.5
    • Component/s: datanode
    • Labels:
      None

      Description

      HDFS-5042 introduced fsyncDirectory(..) to save blocks from power failure.
      Do it outside of FSDataset lock to avoid overall performance degradation if disk takes more time to sync.

      1. HDFS-12157-branch-2-01.patch
        5 kB
        Vinayakumar B
      2. HDFS-12157-branch-2.7-01.patch
        6 kB
        Vinayakumar B
      3. HDFS-12157-branch-2.7-01.patch
        6 kB
        Vinayakumar B
      4. HDFS-12157-01.patch
        5 kB
        Vinayakumar B

        Issue Links

          Activity

          Hide
          vinayrpet Vinayakumar B added a comment -

          Attached the patch for trunk

          Show
          vinayrpet Vinayakumar B added a comment - Attached the patch for trunk
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 11s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                trunk Compile Tests
          +1 mvninstall 14m 24s trunk passed
          +1 compile 1m 1s trunk passed
          +1 checkstyle 0m 42s trunk passed
          +1 mvnsite 1m 6s trunk passed
          -1 findbugs 2m 3s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
          +1 javadoc 0m 47s trunk passed
                Patch Compile Tests
          +1 mvninstall 1m 8s the patch passed
          +1 compile 1m 1s the patch passed
          +1 javac 1m 1s the patch passed
          +1 checkstyle 0m 40s the patch passed
          +1 mvnsite 1m 2s the patch passed
          +1 whitespace 0m 1s The patch has no whitespace issues.
          +1 findbugs 2m 17s the patch passed
          +1 javadoc 0m 50s the patch passed
                Other Tests
          -1 unit 82m 18s hadoop-hdfs in the patch failed.
          +1 asflicense 0m 24s The patch does not generate ASF License warnings.
          111m 40s



          Reason Tests
          Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy
            hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
            hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12157
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877835/HDFS-12157-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux ed9da5ef022c 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 0b7afc0
          Default Java 1.8.0_131
          findbugs v3.1.0-RC1
          findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20327/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20327/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20327/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20327/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 11s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 14m 24s trunk passed +1 compile 1m 1s trunk passed +1 checkstyle 0m 42s trunk passed +1 mvnsite 1m 6s trunk passed -1 findbugs 2m 3s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 47s trunk passed       Patch Compile Tests +1 mvninstall 1m 8s the patch passed +1 compile 1m 1s the patch passed +1 javac 1m 1s the patch passed +1 checkstyle 0m 40s the patch passed +1 mvnsite 1m 2s the patch passed +1 whitespace 0m 1s The patch has no whitespace issues. +1 findbugs 2m 17s the patch passed +1 javadoc 0m 50s the patch passed       Other Tests -1 unit 82m 18s hadoop-hdfs in the patch failed. +1 asflicense 0m 24s The patch does not generate ASF License warnings. 111m 40s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedInputStreamWithRandomECPolicy   hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12157 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12877835/HDFS-12157-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux ed9da5ef022c 3.13.0-123-generic #172-Ubuntu SMP Mon Jun 26 18:04:35 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 0b7afc0 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20327/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20327/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20327/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20327/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Attached the branch-2 and branch-2.7 patches

          Show
          vinayrpet Vinayakumar B added a comment - Attached the branch-2 and branch-2.7 patches
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 15s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2 Compile Tests
          +1 mvninstall 6m 57s branch-2 passed
          +1 compile 0m 40s branch-2 passed with JDK v1.8.0_131
          +1 compile 0m 44s branch-2 passed with JDK v1.7.0_131
          +1 checkstyle 0m 29s branch-2 passed
          +1 mvnsite 0m 52s branch-2 passed
          +1 findbugs 1m 56s branch-2 passed
          +1 javadoc 0m 39s branch-2 passed with JDK v1.8.0_131
          +1 javadoc 1m 1s branch-2 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 44s the patch passed
          +1 compile 0m 37s the patch passed with JDK v1.8.0_131
          +1 javac 0m 37s the patch passed
          +1 compile 0m 40s the patch passed with JDK v1.7.0_131
          +1 javac 0m 40s the patch passed
          +1 checkstyle 0m 26s the patch passed
          +1 mvnsite 0m 48s the patch passed
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 findbugs 2m 7s the patch passed
          +1 javadoc 0m 35s the patch passed with JDK v1.8.0_131
          +1 javadoc 0m 57s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 49m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 27s The patch does not generate ASF License warnings.
          134m 59s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner
          JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:5e40efe
          JIRA Issue HDFS-12157
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878202/HDFS-12157-branch-2-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 00afd4fa8122 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2 / 5070c9b
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20355/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20355/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20355/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 15s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2 Compile Tests +1 mvninstall 6m 57s branch-2 passed +1 compile 0m 40s branch-2 passed with JDK v1.8.0_131 +1 compile 0m 44s branch-2 passed with JDK v1.7.0_131 +1 checkstyle 0m 29s branch-2 passed +1 mvnsite 0m 52s branch-2 passed +1 findbugs 1m 56s branch-2 passed +1 javadoc 0m 39s branch-2 passed with JDK v1.8.0_131 +1 javadoc 1m 1s branch-2 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 44s the patch passed +1 compile 0m 37s the patch passed with JDK v1.8.0_131 +1 javac 0m 37s the patch passed +1 compile 0m 40s the patch passed with JDK v1.7.0_131 +1 javac 0m 40s the patch passed +1 checkstyle 0m 26s the patch passed +1 mvnsite 0m 48s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 2m 7s the patch passed +1 javadoc 0m 35s the patch passed with JDK v1.8.0_131 +1 javadoc 0m 57s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 49m 59s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 27s The patch does not generate ASF License warnings. 134m 59s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.server.datanode.TestDirectoryScanner JDK v1.8.0_131 Timed out junit tests org.apache.hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.blockmanagement.TestReplicationPolicyWithUpgradeDomain Subsystem Report/Notes Docker Image:yetus/hadoop:5e40efe JIRA Issue HDFS-12157 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12878202/HDFS-12157-branch-2-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 00afd4fa8122 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2 / 5070c9b Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 unit https://builds.apache.org/job/PreCommit-HDFS-Build/20355/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20355/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20355/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Failures seems to be unrelated

          Show
          vinayrpet Vinayakumar B added a comment - Failures seems to be unrelated
          Hide
          brahmareddy Brahma Reddy Battula added a comment -

          +1, looks jenkins didn't run on branch-2.7 patch.

          Show
          brahmareddy Brahma Reddy Battula added a comment - +1, looks jenkins didn't run on branch-2.7 patch.
          Hide
          vinayrpet Vinayakumar B added a comment -

          Attaching branch-2.7 patch again for jenkins

          Show
          vinayrpet Vinayakumar B added a comment - Attaching branch-2.7 patch again for jenkins
          Hide
          hadoopqa Hadoop QA added a comment -
          -1 overall



          Vote Subsystem Runtime Comment
          0 reexec 10m 41s Docker mode activated.
                Prechecks
          +1 @author 0m 0s The patch does not contain any @author tags.
          -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
                branch-2.7 Compile Tests
          +1 mvninstall 8m 8s branch-2.7 passed
          +1 compile 0m 57s branch-2.7 passed with JDK v1.8.0_131
          +1 compile 0m 59s branch-2.7 passed with JDK v1.7.0_131
          +1 checkstyle 0m 26s branch-2.7 passed
          +1 mvnsite 0m 59s branch-2.7 passed
          +1 findbugs 2m 52s branch-2.7 passed
          +1 javadoc 0m 59s branch-2.7 passed with JDK v1.8.0_131
          +1 javadoc 1m 45s branch-2.7 passed with JDK v1.7.0_131
                Patch Compile Tests
          +1 mvninstall 0m 52s the patch passed
          +1 compile 0m 54s the patch passed with JDK v1.8.0_131
          +1 javac 0m 54s the patch passed
          +1 compile 0m 58s the patch passed with JDK v1.7.0_131
          +1 javac 0m 58s the patch passed
          +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 125 unchanged - 1 fixed = 125 total (was 126)
          +1 mvnsite 0m 56s the patch passed
          -1 whitespace 0m 0s The patch has 60 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply
          +1 findbugs 3m 3s the patch passed
          +1 javadoc 0m 56s the patch passed with JDK v1.8.0_131
          +1 javadoc 1m 43s the patch passed with JDK v1.7.0_131
                Other Tests
          -1 unit 43m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_131.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          130m 13s



          Reason Tests
          JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestHttpsFileSystem
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots
          JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes
            hadoop.hdfs.TestDFSShell
            hadoop.hdfs.web.TestHttpsFileSystem
            hadoop.hdfs.server.datanode.TestDirectoryScanner
            hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:67e87c9
          JIRA Issue HDFS-12157
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879762/HDFS-12157-branch-2.7-01.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
          uname Linux 27dbdab6eb4a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision branch-2.7 / 7be4898
          Default Java 1.7.0_131
          Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131
          findbugs v3.0.0
          whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/20509/artifact/patchprocess/whitespace-eol.txt
          unit https://builds.apache.org/job/PreCommit-HDFS-Build/20509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt
          JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20509/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20509/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 10m 41s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       branch-2.7 Compile Tests +1 mvninstall 8m 8s branch-2.7 passed +1 compile 0m 57s branch-2.7 passed with JDK v1.8.0_131 +1 compile 0m 59s branch-2.7 passed with JDK v1.7.0_131 +1 checkstyle 0m 26s branch-2.7 passed +1 mvnsite 0m 59s branch-2.7 passed +1 findbugs 2m 52s branch-2.7 passed +1 javadoc 0m 59s branch-2.7 passed with JDK v1.8.0_131 +1 javadoc 1m 45s branch-2.7 passed with JDK v1.7.0_131       Patch Compile Tests +1 mvninstall 0m 52s the patch passed +1 compile 0m 54s the patch passed with JDK v1.8.0_131 +1 javac 0m 54s the patch passed +1 compile 0m 58s the patch passed with JDK v1.7.0_131 +1 javac 0m 58s the patch passed +1 checkstyle 0m 22s hadoop-hdfs-project/hadoop-hdfs: The patch generated 0 new + 125 unchanged - 1 fixed = 125 total (was 126) +1 mvnsite 0m 56s the patch passed -1 whitespace 0m 0s The patch has 60 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply +1 findbugs 3m 3s the patch passed +1 javadoc 0m 56s the patch passed with JDK v1.8.0_131 +1 javadoc 1m 43s the patch passed with JDK v1.7.0_131       Other Tests -1 unit 43m 38s hadoop-hdfs in the patch failed with JDK v1.7.0_131. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 130m 13s Reason Tests JDK v1.8.0_131 Failed junit tests hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots JDK v1.7.0_131 Failed junit tests hadoop.hdfs.server.balancer.TestBalancerWithMultipleNameNodes   hadoop.hdfs.TestDFSShell   hadoop.hdfs.web.TestHttpsFileSystem   hadoop.hdfs.server.datanode.TestDirectoryScanner   hadoop.hdfs.server.namenode.snapshot.TestRenameWithSnapshots Subsystem Report/Notes Docker Image:yetus/hadoop:67e87c9 JIRA Issue HDFS-12157 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879762/HDFS-12157-branch-2.7-01.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 27dbdab6eb4a 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision branch-2.7 / 7be4898 Default Java 1.7.0_131 Multi-JDK versions /usr/lib/jvm/java-8-oracle:1.8.0_131 /usr/lib/jvm/java-7-openjdk-amd64:1.7.0_131 findbugs v3.0.0 whitespace https://builds.apache.org/job/PreCommit-HDFS-Build/20509/artifact/patchprocess/whitespace-eol.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20509/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs-jdk1.7.0_131.txt JDK v1.7.0_131 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20509/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20509/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          vinayrpet Vinayakumar B added a comment -

          no test failures are related to this change.

          Show
          vinayrpet Vinayakumar B added a comment - no test failures are related to this change.
          Hide
          brahmareddy Brahma Reddy Battula added a comment - - edited

          will hold for commit till Kihwal Lee review once.

          Hi Kihwal Lee
          can you please check once..?

          thanks

          Show
          brahmareddy Brahma Reddy Battula added a comment - - edited will hold for commit till Kihwal Lee review once. Hi Kihwal Lee can you please check once..? thanks
          Hide
          kihwal Kihwal Lee added a comment -

          +1 LGTM.

          Show
          kihwal Kihwal Lee added a comment - +1 LGTM.
          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12153 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12153/)
          HDFS-12157. Do fsyncDirectory(..) outside of FSDataset lock. Contributed (kihwal: rev 69afa26f19adad4c630a307c274130eb8b697141)

          • (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #12153 (See https://builds.apache.org/job/Hadoop-trunk-Commit/12153/ ) HDFS-12157 . Do fsyncDirectory(..) outside of FSDataset lock. Contributed (kihwal: rev 69afa26f19adad4c630a307c274130eb8b697141) (edit) hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/fsdataset/impl/FsDatasetImpl.java
          Hide
          kihwal Kihwal Lee added a comment -

          I've committed this to trunk, branch-2, branch-2.8, branch-2.8.2 and branch-2.7. Thanks for working on this Vinay and thanks for reviewing it Brahma.

          Show
          kihwal Kihwal Lee added a comment - I've committed this to trunk, branch-2, branch-2.8, branch-2.8.2 and branch-2.7. Thanks for working on this Vinay and thanks for reviewing it Brahma.

            People

            • Assignee:
              vinayrpet Vinayakumar B
              Reporter:
              vinayrpet Vinayakumar B
            • Votes:
              0 Vote for this issue
              Watchers:
              10 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development