Details

    • Type: Bug
    • Status: Resolved
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: 3.0.0-alpha4
    • Fix Version/s: 3.0.0-beta1
    • Component/s: httpfs
    • Labels:
      None

      Description

      The patch for HDFS-10860 used 2 diffferent property names to indicate SSL is enabled for HttpFS: hadoop.httpfs.ssl.enabled and httpfs.ssl.enabled. The correct one is httpfs.ssl.enabled.

      1. HDFS-12114.001.patch
        9 kB
        John Zhuge
      2. HDFS-12114.002.patch
        9 kB
        John Zhuge

        Issue Links

          Activity

          Hide
          hudson Hudson added a comment -

          SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11991 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11991/)
          HDFS-12114. Consistent HttpFS property names. Contributed by John Zhuge. (jzhuge: rev ac0a04a6e165920a6d43c2aa3dab06ca38f3135b)

          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/ServerSetup.md.vm
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerWebServer.java
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml
          • (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java
          Show
          hudson Hudson added a comment - SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #11991 (See https://builds.apache.org/job/Hadoop-trunk-Commit/11991/ ) HDFS-12114 . Consistent HttpFS property names. Contributed by John Zhuge. (jzhuge: rev ac0a04a6e165920a6d43c2aa3dab06ca38f3135b) (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/site/markdown/ServerSetup.md.vm (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/test/java/org/apache/hadoop/fs/http/server/TestHttpFSServerWebServer.java (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/libexec/shellprofile.d/hadoop-httpfs.sh (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/resources/httpfs-default.xml (edit) hadoop-hdfs-project/hadoop-hdfs-httpfs/src/main/java/org/apache/hadoop/fs/http/server/HttpFSServerWebServer.java
          Hide
          jzhuge John Zhuge added a comment -

          Committed to trunk.

          Thanks Ravi Prakash for the review!

          Show
          jzhuge John Zhuge added a comment - Committed to trunk. Thanks Ravi Prakash for the review!
          Hide
          raviprak Ravi Prakash added a comment -

          Thanks John! LGTM. +1.

          Show
          raviprak Ravi Prakash added a comment - Thanks John! LGTM. +1.
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 14s Docker mode activated.
                Prechecks
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 33s trunk passed
          +1 compile 0m 21s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 findbugs 0m 28s trunk passed
          +1 javadoc 0m 16s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 17s the patch passed
          +1 javac 0m 17s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 2m 19s the patch passed
          +1 shellcheck 0m 2s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 13s the patch passed
                Other Tests
          +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          24m 51s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12114
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876673/HDFS-12114.002.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs xml
          uname Linux d8f5cb691f8a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 12c8fdc
          Default Java 1.8.0_131
          shellcheck v0.4.6
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20234/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20234/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 33s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 50s trunk passed +1 findbugs 0m 28s trunk passed +1 javadoc 0m 16s trunk passed       Patch Compile Tests +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 2m 19s the patch passed +1 shellcheck 0m 2s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 13s the patch passed       Other Tests +1 unit 3m 20s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 24m 51s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12114 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876673/HDFS-12114.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs xml uname Linux d8f5cb691f8a 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 12c8fdc Default Java 1.8.0_131 shellcheck v0.4.6 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20234/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20234/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 002

          • Rebase
          Show
          jzhuge John Zhuge added a comment - Patch 002 Rebase
          Hide
          hadoopqa Hadoop QA added a comment -
          +1 overall



          Vote Subsystem Runtime Comment
          0 reexec 0m 13s Docker mode activated.
                Prechecks
          0 shelldocs 0m 0s Shelldocs was not available.
          +1 @author 0m 0s The patch does not contain any @author tags.
          +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.
                trunk Compile Tests
          +1 mvninstall 13m 18s trunk passed
          +1 compile 0m 21s trunk passed
          +1 checkstyle 0m 16s trunk passed
          +1 mvnsite 0m 50s trunk passed
          +1 findbugs 0m 27s trunk passed
          +1 javadoc 0m 17s trunk passed
                Patch Compile Tests
          +1 mvninstall 0m 18s the patch passed
          +1 compile 0m 17s the patch passed
          +1 javac 0m 17s the patch passed
          +1 checkstyle 0m 11s the patch passed
          +1 mvnsite 2m 27s the patch passed
          +1 shellcheck 0m 1s There were no new shellcheck issues.
          +1 whitespace 0m 0s The patch has no whitespace issues.
          +1 xml 0m 1s The patch has no ill-formed XML file.
          +1 findbugs 0m 32s the patch passed
          +1 javadoc 0m 13s the patch passed
                Other Tests
          +1 unit 3m 19s hadoop-hdfs-httpfs in the patch passed.
          +1 asflicense 0m 18s The patch does not generate ASF License warnings.
          24m 39s



          Subsystem Report/Notes
          Docker Image:yetus/hadoop:14b5c93
          JIRA Issue HDFS-12114
          JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876539/HDFS-12114.001.patch
          Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs xml
          uname Linux c2106e9452bf 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
          Build tool maven
          Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
          git revision trunk / 5496a34
          Default Java 1.8.0_131
          shellcheck v0.4.6
          findbugs v3.1.0-RC1
          Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20220/testReport/
          modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs
          Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20220/console
          Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

          This message was automatically generated.

          Show
          hadoopqa Hadoop QA added a comment - +1 overall Vote Subsystem Runtime Comment 0 reexec 0m 13s Docker mode activated.       Prechecks 0 shelldocs 0m 0s Shelldocs was not available. +1 @author 0m 0s The patch does not contain any @author tags. +1 test4tests 0m 0s The patch appears to include 1 new or modified test files.       trunk Compile Tests +1 mvninstall 13m 18s trunk passed +1 compile 0m 21s trunk passed +1 checkstyle 0m 16s trunk passed +1 mvnsite 0m 50s trunk passed +1 findbugs 0m 27s trunk passed +1 javadoc 0m 17s trunk passed       Patch Compile Tests +1 mvninstall 0m 18s the patch passed +1 compile 0m 17s the patch passed +1 javac 0m 17s the patch passed +1 checkstyle 0m 11s the patch passed +1 mvnsite 2m 27s the patch passed +1 shellcheck 0m 1s There were no new shellcheck issues. +1 whitespace 0m 0s The patch has no whitespace issues. +1 xml 0m 1s The patch has no ill-formed XML file. +1 findbugs 0m 32s the patch passed +1 javadoc 0m 13s the patch passed       Other Tests +1 unit 3m 19s hadoop-hdfs-httpfs in the patch passed. +1 asflicense 0m 18s The patch does not generate ASF License warnings. 24m 39s Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12114 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12876539/HDFS-12114.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle shellcheck shelldocs xml uname Linux c2106e9452bf 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 5496a34 Default Java 1.8.0_131 shellcheck v0.4.6 findbugs v3.1.0-RC1 Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20220/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs-httpfs U: hadoop-hdfs-project/hadoop-hdfs-httpfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20220/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
          Hide
          jzhuge John Zhuge added a comment -

          Patch 001

          • Rename “hadoop.httpfs.ssl.enabled” to “httpfs.ssl.enabled”
          • Rename “hadoop.httpfs.http.host to “httpfs.http.hostname” inline with env var HTTPFS_HTTP_HOSTNAME
          • Rename “hadoop.httpfs.http.port” to “httpfs.http.port”
          • Rename “hadoop.httpfs.http.administrators” to “httpfs.http.administrators”
          • Properly deprecate env var HTTPFS_HTTP_HOSTNAME
          • Remove unnecessary code in hadoop-httpfs.sh

          Testing Done

          • HttpFS sanity tests in insecure, SSL, and SSL+Kerberos mode
             ✓ httpfs daemonlog
             ✓ httpfs servlet /jmx
             ✓ httpfs servlet /conf
             ✓ httpfs servlet /logLevel
             ✓ httpfs servlet /logs
             ✓ httpfs servlet /stacks
             ✓ httpfs ls
            
          Show
          jzhuge John Zhuge added a comment - Patch 001 Rename “hadoop.httpfs.ssl.enabled” to “httpfs.ssl.enabled” Rename “hadoop.httpfs.http.host to “httpfs.http.hostname” inline with env var HTTPFS_HTTP_HOSTNAME Rename “hadoop.httpfs.http.port” to “httpfs.http.port” Rename “hadoop.httpfs.http.administrators” to “httpfs.http.administrators” Properly deprecate env var HTTPFS_HTTP_HOSTNAME Remove unnecessary code in hadoop-httpfs.sh Testing Done HttpFS sanity tests in insecure, SSL, and SSL+Kerberos mode ✓ httpfs daemonlog ✓ httpfs servlet /jmx ✓ httpfs servlet /conf ✓ httpfs servlet /logLevel ✓ httpfs servlet /logs ✓ httpfs servlet /stacks ✓ httpfs ls
          Hide
          jzhuge John Zhuge added a comment -

          To be consistent, rename hadoop.httpfs.http.host, hadoop.httpfs.http.port, and hadoop.httpfs.http.administrators as well.

          Show
          jzhuge John Zhuge added a comment - To be consistent, rename hadoop.httpfs.http.host, hadoop.httpfs.http.port, and hadoop.httpfs.http.administrators as well.

            People

            • Assignee:
              jzhuge John Zhuge
              Reporter:
              jzhuge John Zhuge
            • Votes:
              0 Vote for this issue
              Watchers:
              4 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development