Uploaded image for project: 'Hadoop HDFS'
  1. Hadoop HDFS
  2. HDFS-12036

Add audit log for some erasure coding operations

    Details

    • Hadoop Flags:
      Reviewed

      Description

      These three FSNameSystem operations do not yet record audit logs. I am not sure how useful these audit logs would be, but thought I should file them so that they don't get dropped if they turn out to be needed.

      1. HDFS-12036.001.patch
        3 kB
        Huafeng Wang
      2. HDFS-12036.002.patch
        3 kB
        Huafeng Wang
      3. HDFS-12036.003.patch
        6 kB
        Huafeng Wang

        Activity

        Hide
        andrew.wang Andrew Wang added a comment -

        Nice find Wei-chiu, we definitely need audit logs for these.

        Show
        andrew.wang Andrew Wang added a comment - Nice find Wei-chiu, we definitely need audit logs for these.
        Hide
        HuafengWang Huafeng Wang added a comment -

        Hi Andrew Wang , I'd like to take this one.

        Show
        HuafengWang Huafeng Wang added a comment - Hi Andrew Wang , I'd like to take this one.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        Huafeng Wang assigned it to you.

        Show
        jojochuang Wei-Chiu Chuang added a comment - Huafeng Wang assigned it to you.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 29s trunk passed
        +1 compile 0m 50s trunk passed
        +1 checkstyle 0m 37s trunk passed
        +1 mvnsite 0m 53s trunk passed
        -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 0m 40s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 50s the patch passed
        +1 compile 0m 46s the patch passed
        +1 javac 0m 46s the patch passed
        -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 0 fixed = 180 total (was 178)
        +1 mvnsite 0m 52s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 46s the patch passed
        +1 javadoc 0m 37s the patch passed
              Other Tests
        -1 unit 65m 26s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 17s The patch does not generate ASF License warnings.
        90m 47s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy
          hadoop.hdfs.web.TestWebHDFS



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12036
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879289/HDFS-12036.001.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 8f13f3fa6d8e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 38c6fa5
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20459/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20459/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 29s trunk passed +1 compile 0m 50s trunk passed +1 checkstyle 0m 37s trunk passed +1 mvnsite 0m 53s trunk passed -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 40s trunk passed       Patch Compile Tests +1 mvninstall 0m 50s the patch passed +1 compile 0m 46s the patch passed +1 javac 0m 46s the patch passed -0 checkstyle 0m 35s hadoop-hdfs-project/hadoop-hdfs: The patch generated 2 new + 178 unchanged - 0 fixed = 180 total (was 178) +1 mvnsite 0m 52s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 46s the patch passed +1 javadoc 0m 37s the patch passed       Other Tests -1 unit 65m 26s hadoop-hdfs in the patch failed. +1 asflicense 0m 17s The patch does not generate ASF License warnings. 90m 47s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure080   hadoop.hdfs.TestDFSStripedOutputStreamWithFailureWithRandomECPolicy   hadoop.hdfs.web.TestWebHDFS Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12036 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879289/HDFS-12036.001.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 8f13f3fa6d8e 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38c6fa5 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html checkstyle https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/diff-checkstyle-hadoop-hdfs-project_hadoop-hdfs.txt unit https://builds.apache.org/job/PreCommit-HDFS-Build/20459/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20459/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20459/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 17s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 23s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 53s trunk passed
        -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings.
        +1 javadoc 0m 38s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 48s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 37s the patch passed
              Other Tests
        -1 unit 69m 1s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 15s The patch does not generate ASF License warnings.
        94m 8s



        Reason Tests
        Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090
          hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock
          hadoop.hdfs.TestEncryptionZonesWithKMS
        Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12036
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879299/HDFS-12036.002.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux 52960bf78417 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / 38c6fa5
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20460/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20460/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20460/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20460/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 17s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 23s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 53s trunk passed -1 findbugs 1m 41s hadoop-hdfs-project/hadoop-hdfs in trunk has 10 extant Findbugs warnings. +1 javadoc 0m 38s trunk passed       Patch Compile Tests +1 mvninstall 0m 48s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 37s the patch passed       Other Tests -1 unit 69m 1s hadoop-hdfs in the patch failed. +1 asflicense 0m 15s The patch does not generate ASF License warnings. 94m 8s Reason Tests Failed junit tests hadoop.hdfs.TestDFSStripedOutputStreamWithFailure090   hadoop.hdfs.server.blockmanagement.TestPendingInvalidateBlock   hadoop.hdfs.TestEncryptionZonesWithKMS Timed out junit tests org.apache.hadoop.hdfs.server.blockmanagement.TestBlockStatsMXBean Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12036 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12879299/HDFS-12036.002.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux 52960bf78417 3.13.0-116-generic #163-Ubuntu SMP Fri Mar 31 14:13:22 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / 38c6fa5 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20460/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20460/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20460/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20460/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        HuafengWang Huafeng Wang added a comment -

        Hi Wei-Chiu Chuang, the patch is ready, can you take a look? I think the test failure is irrelevant.

        Show
        HuafengWang Huafeng Wang added a comment - Hi Wei-Chiu Chuang , the patch is ready, can you take a look? I think the test failure is irrelevant.
        Hide
        jojochuang Wei-Chiu Chuang added a comment -

        LGTM

        Show
        jojochuang Wei-Chiu Chuang added a comment - LGTM
        Hide
        drankye Kai Zheng added a comment -

        Hi Huafeng Wang,

        This looks close. Two minors by the way:
        1. FSNamesystem->addECPolicies might be addErasureCodingPolicies to be consistent.
        2. Your way to put the logAuditEvent statement in the finally block is better, would you refine other places in the same way?

        Thanks!

        Show
        drankye Kai Zheng added a comment - Hi Huafeng Wang , This looks close. Two minors by the way: 1. FSNamesystem->addECPolicies might be addErasureCodingPolicies to be consistent. 2. Your way to put the logAuditEvent statement in the finally block is better, would you refine other places in the same way? Thanks!
        Hide
        HuafengWang Huafeng Wang added a comment -

        Thanks Kai Zheng for your review, I just updated the patch.

        Show
        HuafengWang Huafeng Wang added a comment - Thanks Kai Zheng for your review, I just updated the patch.
        Hide
        hadoopqa Hadoop QA added a comment -
        -1 overall



        Vote Subsystem Runtime Comment
        0 reexec 0m 14s Docker mode activated.
              Prechecks
        +1 @author 0m 0s The patch does not contain any @author tags.
        -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.
              trunk Compile Tests
        +1 mvninstall 13m 55s trunk passed
        +1 compile 0m 48s trunk passed
        +1 checkstyle 0m 38s trunk passed
        +1 mvnsite 0m 53s trunk passed
        -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings.
        +1 javadoc 0m 41s trunk passed
              Patch Compile Tests
        +1 mvninstall 0m 49s the patch passed
        +1 compile 0m 45s the patch passed
        +1 javac 0m 45s the patch passed
        +1 checkstyle 0m 35s the patch passed
        +1 mvnsite 0m 50s the patch passed
        +1 whitespace 0m 0s The patch has no whitespace issues.
        +1 findbugs 1m 45s the patch passed
        +1 javadoc 0m 38s the patch passed
              Other Tests
        -1 unit 65m 30s hadoop-hdfs in the patch failed.
        +1 asflicense 0m 16s The patch does not generate ASF License warnings.
        91m 10s



        Reason Tests
        Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting
          hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits
          hadoop.hdfs.TestDFSStripedInputStream
          hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070



        Subsystem Report/Notes
        Docker Image:yetus/hadoop:14b5c93
        JIRA Issue HDFS-12036
        JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880603/HDFS-12036.003.patch
        Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle
        uname Linux d0c294f14302 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux
        Build tool maven
        Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh
        git revision trunk / d91b7a8
        Default Java 1.8.0_131
        findbugs v3.1.0-RC1
        findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20577/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html
        unit https://builds.apache.org/job/PreCommit-HDFS-Build/20577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt
        Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20577/testReport/
        modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs
        Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20577/console
        Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org

        This message was automatically generated.

        Show
        hadoopqa Hadoop QA added a comment - -1 overall Vote Subsystem Runtime Comment 0 reexec 0m 14s Docker mode activated.       Prechecks +1 @author 0m 0s The patch does not contain any @author tags. -1 test4tests 0m 0s The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch.       trunk Compile Tests +1 mvninstall 13m 55s trunk passed +1 compile 0m 48s trunk passed +1 checkstyle 0m 38s trunk passed +1 mvnsite 0m 53s trunk passed -1 findbugs 1m 39s hadoop-hdfs-project/hadoop-hdfs in trunk has 9 extant Findbugs warnings. +1 javadoc 0m 41s trunk passed       Patch Compile Tests +1 mvninstall 0m 49s the patch passed +1 compile 0m 45s the patch passed +1 javac 0m 45s the patch passed +1 checkstyle 0m 35s the patch passed +1 mvnsite 0m 50s the patch passed +1 whitespace 0m 0s The patch has no whitespace issues. +1 findbugs 1m 45s the patch passed +1 javadoc 0m 38s the patch passed       Other Tests -1 unit 65m 30s hadoop-hdfs in the patch failed. +1 asflicense 0m 16s The patch does not generate ASF License warnings. 91m 10s Reason Tests Failed junit tests hadoop.hdfs.server.datanode.TestDataNodeVolumeFailureReporting   hadoop.hdfs.server.namenode.ha.TestFailureToReadEdits   hadoop.hdfs.TestDFSStripedInputStream   hadoop.hdfs.TestDFSStripedOutputStreamWithFailure070 Subsystem Report/Notes Docker Image:yetus/hadoop:14b5c93 JIRA Issue HDFS-12036 JIRA Patch URL https://issues.apache.org/jira/secure/attachment/12880603/HDFS-12036.003.patch Optional Tests asflicense compile javac javadoc mvninstall mvnsite unit findbugs checkstyle uname Linux d0c294f14302 3.13.0-119-generic #166-Ubuntu SMP Wed May 3 12:18:55 UTC 2017 x86_64 x86_64 x86_64 GNU/Linux Build tool maven Personality /testptch/hadoop/patchprocess/precommit/personality/provided.sh git revision trunk / d91b7a8 Default Java 1.8.0_131 findbugs v3.1.0-RC1 findbugs https://builds.apache.org/job/PreCommit-HDFS-Build/20577/artifact/patchprocess/branch-findbugs-hadoop-hdfs-project_hadoop-hdfs-warnings.html unit https://builds.apache.org/job/PreCommit-HDFS-Build/20577/artifact/patchprocess/patch-unit-hadoop-hdfs-project_hadoop-hdfs.txt Test Results https://builds.apache.org/job/PreCommit-HDFS-Build/20577/testReport/ modules C: hadoop-hdfs-project/hadoop-hdfs U: hadoop-hdfs-project/hadoop-hdfs Console output https://builds.apache.org/job/PreCommit-HDFS-Build/20577/console Powered by Apache Yetus 0.6.0-SNAPSHOT http://yetus.apache.org This message was automatically generated.
        Hide
        drankye Kai Zheng added a comment -

        Thanks Huafeng Wang for the update!

        Just noticed another minor in existing codes. Could you fix it by the way? Thanks!

            * Get available erasure coding codecs and corresponding coders.
            */
           HashMap<String, String> getErasureCodingCodecs() throws IOException {
        +    final String operationName = "getErasureCodingCodecs";
        +    boolean success = false;
             checkOperation(OperationCategory.READ);
             readLock();
             try {
               checkOperation(OperationCategory.READ);
        -      return FSDirErasureCodingOp.getErasureCodingCodecs(this);
        +      final HashMap<String, String> ret =
        +          FSDirErasureCodingOp.getErasureCodingCodecs(this);
        +      success = true;
        

        The function would be better to return a Map instead of a HashMap. And also to FSDirErasureCodingOp.getErasureCodingCodecs

        Show
        drankye Kai Zheng added a comment - Thanks Huafeng Wang for the update! Just noticed another minor in existing codes. Could you fix it by the way? Thanks! * Get available erasure coding codecs and corresponding coders. */ HashMap< String , String > getErasureCodingCodecs() throws IOException { + final String operationName = "getErasureCodingCodecs" ; + boolean success = false ; checkOperation(OperationCategory.READ); readLock(); try { checkOperation(OperationCategory.READ); - return FSDirErasureCodingOp.getErasureCodingCodecs( this ); + final HashMap< String , String > ret = + FSDirErasureCodingOp.getErasureCodingCodecs( this ); + success = true ; The function would be better to return a Map instead of a HashMap. And also to FSDirErasureCodingOp.getErasureCodingCodecs
        Hide
        HuafengWang Huafeng Wang added a comment -

        Hi Kai, the function is defined in ClientProtocol so I think it should be fixed in another issue. I just created one: https://issues.apache.org/jira/browse/HDFS-12269

        Show
        HuafengWang Huafeng Wang added a comment - Hi Kai, the function is defined in ClientProtocol so I think it should be fixed in another issue. I just created one: https://issues.apache.org/jira/browse/HDFS-12269
        Hide
        drankye Kai Zheng added a comment -

        Thanks Huafeng! The idea to do it separately sounds good to me. The latest patch LGTM and +1.

        Show
        drankye Kai Zheng added a comment - Thanks Huafeng! The idea to do it separately sounds good to me. The latest patch LGTM and +1.
        Hide
        drankye Kai Zheng added a comment -

        Committed to trunk. Thanks Huafeng Wang for the contribution and Wei-Chiu Chuang for the review.

        Show
        drankye Kai Zheng added a comment - Committed to trunk. Thanks Huafeng Wang for the contribution and Wei-Chiu Chuang for the review.
        Hide
        kshukla Kuhu Shukla added a comment - - edited

        Huafeng Wang, Kai Zheng, was the intent of this patch to log all IOExceptions as well, since that is not what most FSNameSystem calls do at the moment. My understanding is have audit logs for AccessControlException (allowed=false) and in successful cases (allowed=true) since logging allowed=false in the case of IOException could be misleading. Let me know your thoughts on this and I will rebase my patch for HDFS-11246 accordingly. Thanks!

        P.S. The commit has the wrong JIRA number in it (points to HDFS-12306).

        Show
        kshukla Kuhu Shukla added a comment - - edited Huafeng Wang , Kai Zheng , was the intent of this patch to log all IOExceptions as well, since that is not what most FSNameSystem calls do at the moment. My understanding is have audit logs for AccessControlException (allowed=false) and in successful cases (allowed=true) since logging allowed=false in the case of IOException could be misleading. Let me know your thoughts on this and I will rebase my patch for HDFS-11246 accordingly. Thanks! P.S. The commit has the wrong JIRA number in it (points to HDFS-12306 ).
        Hide
        drankye Kai Zheng added a comment -

        Thanks Kuhu Shukla for the good catch!!

        The commit has the wrong JIRA number in it (points to HDFS-12306)

        Hi Andrew Wang, do you know there is any chance to correct the commit message given we have released it? Thanks!

        Show
        drankye Kai Zheng added a comment - Thanks Kuhu Shukla for the good catch!! The commit has the wrong JIRA number in it (points to HDFS-12306 ) Hi Andrew Wang , do you know there is any chance to correct the commit message given we have released it? Thanks!
        Hide
        andrew.wang Andrew Wang added a comment -

        Git hashes include the commit message, so it's part of our immutable history.

        I maintain a fixup file for JIRA->commit matching in my versions repo:

        https://github.com/umbrant/versions

        Show
        andrew.wang Andrew Wang added a comment - Git hashes include the commit message, so it's part of our immutable history. I maintain a fixup file for JIRA->commit matching in my versions repo: https://github.com/umbrant/versions

          People

          • Assignee:
            HuafengWang Huafeng Wang
            Reporter:
            jojochuang Wei-Chiu Chuang
          • Votes:
            0 Vote for this issue
            Watchers:
            6 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development