Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1202

DataBlockScanner throws NPE when updated before initialized

        Details

        • Type: Bug Bug
        • Status: Closed
        • Priority: Major Major
        • Resolution: Fixed
        • Affects Version/s: 0.20-append, 0.22.0
        • Fix Version/s: 0.20-append, 0.20.205.0, 0.22.0
        • Component/s: datanode
        • Labels:
          None
        • Hadoop Flags:
          Reviewed

          Description

          Missing an isInitialized() check in updateScanStatusInternal

          1. Text File
            hdfs-1202.20s.patch
            4 kB
            Suresh Srinivas
          2. Text File
            hdfs-1202.txt
            2 kB
            Todd Lipcon
          3. Text File
            hdfs-1202-0.20-append.txt
            2 kB
            Todd Lipcon

            Activity

            Ascending order - Click to sort in descending order
            Hide
            Permalink
            Todd Lipcon added a comment -

            Patch against 0.20-append branch (only seen this there, haven't checked trunk yet, but will do so down the road)

            Show
            Todd Lipcon added a comment - Patch against 0.20-append branch (only seen this there, haven't checked trunk yet, but will do so down the road)
            Hide
            Permalink
            dhruba borthakur added a comment -

            There seems to be many lines that have whitespace changes only.

            Show
            dhruba borthakur added a comment - There seems to be many lines that have whitespace changes only.
            Hide
            Permalink
            Todd Lipcon added a comment -

            If you look carefully, those lines fix a spelling error. It's a private method so I figured it was worth fixing the typo in the method name.

            Show
            Todd Lipcon added a comment - If you look carefully, those lines fix a spelling error. It's a private method so I figured it was worth fixing the typo in the method name.
            Hide
            Permalink
            sam rash added a comment -

            this looks good.

            I checked trunk and I think it is needed there also

            Show
            sam rash added a comment - this looks good. I checked trunk and I think it is needed there also
            Hide
            Permalink
            Todd Lipcon added a comment -

            Patch attached for trunk.

            No unit test as this is pretty trivial and difficult to isolate in a test.

            Show
            Todd Lipcon added a comment - Patch attached for trunk. No unit test as this is pretty trivial and difficult to isolate in a test.
            Hide
            Permalink
            dhruba borthakur added a comment -

            I will commit this to trunk as well as 0.20-append branch as soon as HadoopQA runs its tests on it.

            BTW, the patch for 0.20-append branch does not apply cleanly. Todd: can you pl upload a new version of this patch? Thanks a lot once again.

            Show
            dhruba borthakur added a comment - I will commit this to trunk as well as 0.20-append branch as soon as HadoopQA runs its tests on it. BTW, the patch for 0.20-append branch does not apply cleanly. Todd: can you pl upload a new version of this patch? Thanks a lot once again.
            Hide
            Permalink
            Konstantin Shvachko added a comment -

            0.20 is also affected, right? We should fix it there too.

            Show
            Konstantin Shvachko added a comment - 0.20 is also affected, right? We should fix it there too.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
            against trunk revision 957669.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed core unit tests.

            -1 contrib tests. The patch failed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/checkstyle-errors.html
            Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt against trunk revision 957669. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/console This message is automatically generated.
            Hide
            Permalink
            Hadoop QA added a comment -

            -1 overall. Here are the results of testing the latest attachment
            http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
            against trunk revision 957669.

            +1 @author. The patch does not contain any @author tags.

            -1 tests included. The patch doesn't appear to include any new or modified tests.
            Please justify why no new tests are needed for this patch.
            Also please list what manual steps were performed to verify this patch.

            +1 javadoc. The javadoc tool did not generate any warning messages.

            +1 javac. The applied patch does not increase the total number of javac compiler warnings.

            +1 findbugs. The patch does not introduce any new Findbugs warnings.

            +1 release audit. The applied patch does not increase the total number of release audit warnings.

            -1 core tests. The patch failed core unit tests.

            -1 contrib tests. The patch failed contrib unit tests.

            Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/testReport/
            Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
            Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/checkstyle-errors.html
            Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/console

            This message is automatically generated.

            Show
            Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt against trunk revision 957669. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/console This message is automatically generated.
            Hide
            Permalink
            dhruba borthakur added a comment -

            I just committed this to trunk and 0.20-append. I did not commit this to 0.20 branch because no existing sites have complained of this bug.

            Show
            dhruba borthakur added a comment - I just committed this to trunk and 0.20-append. I did not commit this to 0.20 branch because no existing sites have complained of this bug.
            Hide
            Permalink
            Hudson added a comment -

            Integrated in Hadoop-Hdfs-trunk-Commit #329 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/329/)
            HDFS-1202. DataBlockScanner throws NPE when updated before
            initialized. (Todd Lipcon via dhruba)

            Show
            Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #329 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/329/ ) HDFS-1202 . DataBlockScanner throws NPE when updated before initialized. (Todd Lipcon via dhruba)
            Hide
            Permalink
            Suresh Srinivas added a comment -

            attaching merge patch from 0.20-append to 0.20-security

            Show
            Suresh Srinivas added a comment - attaching merge patch from 0.20-append to 0.20-security
            Hide
            Permalink
            Jitendra Nath Pandey added a comment -

            +1 for hdfs-1202.20s.patch.

            Show
            Jitendra Nath Pandey added a comment - +1 for hdfs-1202.20s.patch.
            Hide
            Permalink
            Suresh Srinivas added a comment -

            I committed the patch to 0.20-security branch.

            Show
            Suresh Srinivas added a comment - I committed the patch to 0.20-security branch.
            Hide
            Permalink
            Matt Foley added a comment -

            Closed upon release of 0.20.205.0

            Show
            Matt Foley added a comment - Closed upon release of 0.20.205.0

              People

              • Assignee:
                Todd Lipcon
                Reporter:
                Todd Lipcon
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated:
                  Resolved:

                  Development