Patch against 0.20-append branch (only seen this there, haven't checked trunk yet, but will do so down the road)

There seems to be many lines that have whitespace changes only.

If you look carefully, those lines fix a spelling error. It's a private method so I figured it was worth fixing the typo in the method name.

this looks good.

I checked trunk and I think it is needed there also

Patch attached for trunk.

No unit test as this is pretty trivial and difficult to isolate in a test.

I will commit this to trunk as well as 0.20-append branch as soon as HadoopQA runs its tests on it.

BTW, the patch for 0.20-append branch does not apply cleanly. Todd: can you pl upload a new version of this patch? Thanks a lot once again.

0.20 is also affected, right? We should fix it there too.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
against trunk revision 957669.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/console

This message is automatically generated.

-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
against trunk revision 957669.

+1 @author. The patch does not contain any @author tags.

-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.

+1 javadoc. The javadoc tool did not generate any warning messages.

+1 javac. The applied patch does not increase the total number of javac compiler warnings.

+1 findbugs. The patch does not introduce any new Findbugs warnings.

+1 release audit. The applied patch does not increase the total number of release audit warnings.

-1 core tests. The patch failed core unit tests.

-1 contrib tests. The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/console

This message is automatically generated.

I just committed this to trunk and 0.20-append. I did not commit this to 0.20 branch because no existing sites have complained of this bug.

Integrated in Hadoop-Hdfs-trunk-Commit #329 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/329/)
HDFS-1202. DataBlockScanner throws NPE when updated before
initialized. (Todd Lipcon via dhruba)

attaching merge patch from 0.20-append to 0.20-security

+1 for hdfs-1202.20s.patch.

I committed the patch to 0.20-security branch.

Closed upon release of 0.20.205.0