Hadoop HDFS
  1. Hadoop HDFS
  2. HDFS-1202

DataBlockScanner throws NPE when updated before initialized

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 0.20-append, 0.22.0
    • Fix Version/s: 0.20-append, 0.20.205.0, 0.22.0
    • Component/s: datanode
    • Labels:
      None
    • Hadoop Flags:
      Reviewed

      Description

      Missing an isInitialized() check in updateScanStatusInternal

      1. hdfs-1202-0.20-append.txt
        2 kB
        Todd Lipcon
      2. hdfs-1202.txt
        2 kB
        Todd Lipcon
      3. hdfs-1202.20s.patch
        4 kB
        Suresh Srinivas

        Activity

        Todd Lipcon created issue -
        Hide
        Todd Lipcon added a comment -

        Patch against 0.20-append branch (only seen this there, haven't checked trunk yet, but will do so down the road)

        Show
        Todd Lipcon added a comment - Patch against 0.20-append branch (only seen this there, haven't checked trunk yet, but will do so down the road)
        Todd Lipcon made changes -
        Field Original Value New Value
        Attachment hdfs-1202-0.20-append.txt [ 12446922 ]
        Todd Lipcon made changes -
        Fix Version/s 0.20-append [ 12315103 ]
        Affects Version/s 0.20-append [ 12315103 ]
        Hide
        dhruba borthakur added a comment -

        There seems to be many lines that have whitespace changes only.

        Show
        dhruba borthakur added a comment - There seems to be many lines that have whitespace changes only.
        Hide
        Todd Lipcon added a comment -

        If you look carefully, those lines fix a spelling error. It's a private method so I figured it was worth fixing the typo in the method name.

        Show
        Todd Lipcon added a comment - If you look carefully, those lines fix a spelling error. It's a private method so I figured it was worth fixing the typo in the method name.
        Hide
        sam rash added a comment -

        this looks good.

        I checked trunk and I think it is needed there also

        Show
        sam rash added a comment - this looks good. I checked trunk and I think it is needed there also
        Hide
        Todd Lipcon added a comment -

        Patch attached for trunk.

        No unit test as this is pretty trivial and difficult to isolate in a test.

        Show
        Todd Lipcon added a comment - Patch attached for trunk. No unit test as this is pretty trivial and difficult to isolate in a test.
        Todd Lipcon made changes -
        Attachment hdfs-1202.txt [ 12447746 ]
        Todd Lipcon made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Fix Version/s 0.22.0 [ 12314241 ]
        Hide
        dhruba borthakur added a comment -

        I will commit this to trunk as well as 0.20-append branch as soon as HadoopQA runs its tests on it.

        BTW, the patch for 0.20-append branch does not apply cleanly. Todd: can you pl upload a new version of this patch? Thanks a lot once again.

        Show
        dhruba borthakur added a comment - I will commit this to trunk as well as 0.20-append branch as soon as HadoopQA runs its tests on it. BTW, the patch for 0.20-append branch does not apply cleanly. Todd: can you pl upload a new version of this patch? Thanks a lot once again.
        Hide
        Konstantin Shvachko added a comment -

        0.20 is also affected, right? We should fix it there too.

        Show
        Konstantin Shvachko added a comment - 0.20 is also affected, right? We should fix it there too.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
        against trunk revision 957669.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt against trunk revision 957669. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/411/console This message is automatically generated.
        Hide
        Hadoop QA added a comment -

        -1 overall. Here are the results of testing the latest attachment
        http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt
        against trunk revision 957669.

        +1 @author. The patch does not contain any @author tags.

        -1 tests included. The patch doesn't appear to include any new or modified tests.
        Please justify why no new tests are needed for this patch.
        Also please list what manual steps were performed to verify this patch.

        +1 javadoc. The javadoc tool did not generate any warning messages.

        +1 javac. The applied patch does not increase the total number of javac compiler warnings.

        +1 findbugs. The patch does not introduce any new Findbugs warnings.

        +1 release audit. The applied patch does not increase the total number of release audit warnings.

        -1 core tests. The patch failed core unit tests.

        -1 contrib tests. The patch failed contrib unit tests.

        Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/testReport/
        Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
        Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/checkstyle-errors.html
        Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/console

        This message is automatically generated.

        Show
        Hadoop QA added a comment - -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12447746/hdfs-1202.txt against trunk revision 957669. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. -1 contrib tests. The patch failed contrib unit tests. Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/testReport/ Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/artifact/trunk/build/test/checkstyle-errors.html Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/412/console This message is automatically generated.
        Hide
        dhruba borthakur added a comment -

        I just committed this to trunk and 0.20-append. I did not commit this to 0.20 branch because no existing sites have complained of this bug.

        Show
        dhruba borthakur added a comment - I just committed this to trunk and 0.20-append. I did not commit this to 0.20 branch because no existing sites have complained of this bug.
        dhruba borthakur made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Hadoop Flags [Reviewed]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in Hadoop-Hdfs-trunk-Commit #329 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/329/)
        HDFS-1202. DataBlockScanner throws NPE when updated before
        initialized. (Todd Lipcon via dhruba)

        Show
        Hudson added a comment - Integrated in Hadoop-Hdfs-trunk-Commit #329 (See http://hudson.zones.apache.org/hudson/job/Hadoop-Hdfs-trunk-Commit/329/ ) HDFS-1202 . DataBlockScanner throws NPE when updated before initialized. (Todd Lipcon via dhruba)
        Suresh Srinivas made changes -
        Fix Version/s 0.20.205.0 [ 12316392 ]
        Hide
        Suresh Srinivas added a comment -

        attaching merge patch from 0.20-append to 0.20-security

        Show
        Suresh Srinivas added a comment - attaching merge patch from 0.20-append to 0.20-security
        Suresh Srinivas made changes -
        Attachment hdfs-1202.20s.patch [ 12491270 ]
        Hide
        Jitendra Nath Pandey added a comment -

        +1 for hdfs-1202.20s.patch.

        Show
        Jitendra Nath Pandey added a comment - +1 for hdfs-1202.20s.patch.
        Hide
        Suresh Srinivas added a comment -

        I committed the patch to 0.20-security branch.

        Show
        Suresh Srinivas added a comment - I committed the patch to 0.20-security branch.
        Hide
        Matt Foley added a comment -

        Closed upon release of 0.20.205.0

        Show
        Matt Foley added a comment - Closed upon release of 0.20.205.0
        Matt Foley made changes -
        Status Resolved [ 5 ] Closed [ 6 ]
        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        10d 22h 1 Todd Lipcon 22/Jun/10 22:46
        Patch Available Patch Available Resolved Resolved
        13d 9h 7m 1 dhruba borthakur 06/Jul/10 07:53
        Resolved Resolved Closed Closed
        469d 17h 32m 1 Matt Foley 19/Oct/11 01:26

          People

          • Assignee:
            Todd Lipcon
            Reporter:
            Todd Lipcon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development